Tweak

Author: jahidulpabelislam

src/CronLinter.php

@@ -152,19 +152,16 @@ function ($v) {
                         }
                     }
 
-                    // Check if range is ordered (only if both values are valid and numeric)
                     if (!$hasInvalidValue && count($rangeValues) === 2) {
-                        $start = $rangeValues[0];
-                        $end = $rangeValues[1];
-                        
-                        // Only check ordering for numeric values
-                        if (is_numeric($start) && is_numeric($end)) {
-                            $startValue = (int)$start;
-                            $endValue = (int)$end;
-                            
-                            if ($startValue > $endValue) {
+                        $numericalValues = array_filter($rangeValues, "is_numeric");
+                        if (count($numericalValues) === 2) {
+                            $sorted = $rangeValues;
+                            sort($sorted);
+                            if ($sorted !== $rangeValues) {
                                 $this->errors[] = "$valueErrorPrefix $steppedValue - values must be ordered";
                             }
+                        } else {
+                            $this->errors[] = "$valueErrorPrefix " . implode("-", array_diff($rangeValues, $numericalValues)) .  " - values in range must be numeric";
                         }
                     }
                 }
@@ -178,6 +175,4 @@ function ($v) {
             $this->errors[] = "Line $lineNo has invalid Cmd: $cmd";
         }
     }
-
-
 }

tests/LinterTest.php

@@ -45,8 +45,6 @@ public static function validProvider(): array {
             ["* * * 6-12/2 * php test.php"],
             ["* * * feb * php test.php"],
             ["* * * JUN * php test.php"],
-            ["* * * dec-jan * php test.php"],
-            ["* * * mar-feb * php test.php"],
 
             ["* * * * 0 php test.php"],
             ["* * * * 6 php test.php"],
@@ -56,7 +54,6 @@ public static function validProvider(): array {
             ["* * * * 1-5/4 php test.php"],
             ["* * * * fri php test.php"],
             ["* * * * TuE php test.php"],
-            ["* * * * fri-mon php test.php"],
         ];
     }
 
@@ -122,6 +119,8 @@ public static function invalidProvider(): array {
             ["* * * 8/12 * php test.php", ["Line 1 has invalid value for Month: 8 - wildcard * or range supported only"]],
             ["* * * 8/12/16 * php test.php", ["Line 1 has invalid value for Month: 8/12/16 - too many steps"]],
             ["* * * june * php test.php", ["Line 1 has invalid value for Month: june"]],
+            ["* * * dec-jan * php test.php", ["Line 1 has invalid value for Month: dec-jan - values in range must be numeric"]],
+            ["* * * mar-feb * php test.php", ["Line 1 has invalid value for Month: mar-feb - values in range must be numeric"]],
             ["* * * 12-1 * php test.php", ["Line 1 has invalid value for Month: 12-1 - values must be ordered"]],
 
             ["* * * * -4 php test.php", ["Line 1 has invalid value for Day of week: -4"]],
@@ -137,6 +136,7 @@ public static function invalidProvider(): array {
             ["* * * * thurs php test.php", ["Line 1 has invalid value for Day of week: thurs"]],
             ["* * * * 6-0 php test.php", ["Line 1 has invalid value for Day of week: 6-0 - values must be ordered"]],
             ["* * * * 5-2 php test.php", ["Line 1 has invalid value for Day of week: 5-2 - values must be ordered"]],
+            ["* * * * fri-mon php test.php", ["Line 1 has invalid value for Day of week: fri-mon - values in range must be numeric"]],
         ];
     }