Revisit htmlunit usage in CDI TCK

[starksm64]

Is your feature request related to a problem? Please describe.
This is a port of the jakartaee/cdi-tck#441 to the new CDI EE TCK

According to jakartaee/cdi-tck#434, htmlunit is causing issues with newer javascript and at its core uses engine that's been problematic for some time.

For next (major/minor) version, we should look for a replacement that we could rewrite the affected tests with (estimated 20-30 tests?).
We don't mean to change what those tests do, just the tooling we use to make assertions.

One of the options (shown in jakartaee/cdi-tck#437) is Selenium.
We should pick something that provides similar testing capabilities and also allows impls to perform execution with as little hassle as possible.

[starksm64]

From @brideck

It should be noted that even if a wholesale change in technology isn't made for the 4.1 TCK, the version of HTMLUnit should be upgraded to 3.x to avoid a CVE.

Some changes to test source would be needed in order to migrate to a 3.x version.

[starksm64]

From @hpehl

We have had good experiences with Cypress for UI testing of HAL (WildFly management console).

We used to have a test suite based on Selenium but decided to switch to Cypress for performance reasons and tighter integration in the browser (see https://docs.cypress.io/guides/overview/key-differences for more details). Tests are written in JavaScript / TypeScript.

I don't know the exact details for testing the CDI TCK. So giving a recommendation is difficult. But I'm happy to share more details.

[arjantijms]

The Faces TCK has switched over to using Selenium, and did away with HTMLUnit testing. This was done specifically because newer JS versions were not supported with HTMLUnit.

One problem with Selenium is that the Eclipse CI blocks its usage. We should ask the Eclipse foundation to lift this block for our CIs. Currently we can only pass the Faces TCK by running it on someone's computer locally.

[jamezp]

I'm running into issues with Selenium not being compatible with the version of Chrome I have installed. This seems fairly fragile to me. I can pass the CDI TCK if I upgrade to 4.28.1 of Seleninium, but I can't upgrade to 4.29.0 because the org.jboss.cdi.tck.selenium.ChromeDevtoolsDriver is using deprecated types that have been removed, specifically org.openqa.selenium.mobile.NetworkConnection.

I've never used Selenium before, but it seems like we should have a way to upgrade this as Chrome will be released much faster than the TCK and there could be security reasons to upgrade it. However, these types are explicitly used:

import org.openqa.selenium.devtools.v126.network.Network;
import org.openqa.selenium.devtools.v126.network.model.Request;
import org.openqa.selenium.devtools.v126.network.model.RequestId;
import org.openqa.selenium.devtools.v126.network.model.ResponseReceived;
import org.openqa.selenium.devtools.v126.network.model.TimeSinceEpoch;

You can't simply upgrade the devtools to the latest version because of this.

[manovotn]

I have attempted to update the Platform TCK version in Weld, which runs Platform CDI TCKs on each PR, and that failed with a related error (PR with CI results can be viewed here).

Error: Failures:
Error: LongRunningConversationPropagatedByFacesContextTest>Arquillian.run:138->testConversationPropagatedAjax:136 » DevTools You are using a no-op implementation of the CDP. The most likely reason for this is that Selenium was unable to find an implementation of the CDP protocol that matches your browser. Please be sure to include an implementation on the classpath, possibly by adding a new (maven) dependency of org.seleniumhq.selenium:selenium-devtools-vNN:4.24.0 where NN matches the major version of the browser you're using.

EDIT: I have excluded the test from the above mentioned PR, hence the failure is no longer visible there.

Looking at commits, I can see two related commits that changed Selenium versions:

• 390a5c5
• b87f328

The latter suggests it was done to pass the tests in CI.
@arjantijms what's the setup you used in CI to get the tests to run?
I don't suppose base CI images even come with Chrome plus this seems fragile due to Chrome updates which I recall were forcing you to always run latest versions.

[manovotn]

@arjantijms ping in case you missed the previous message :)
Any hint on how you managed to run the selenium tests in CI would be much appreciated.