"vibrate on release" option for haptics

Author: jakedowns

src/android/app/src/main/java/org/citra/citra_emu/activities/EmulationActivity.java

@@ -96,6 +96,7 @@ public final class EmulationActivity extends AppCompatActivity
     public static final int MENU_ACTION_TOGGLE_DEPTH_SLIDER = 18;
     public static final int MENU_ACTION_ADJUST_OPACITY = 19;
     public static final int MENU_ACTION_FACE_BUTTON_SLIDE_ENABLE = 20;
+    public static final int MENU_ACTION_VIBRATE_ON_RELEASE = 21;
 
     public static final int REQUEST_SELECT_AMIIBO = 2;
     private static final int EMULATION_RUNNING_NOTIFICATION = 0x1000;
@@ -158,6 +159,8 @@ public final class EmulationActivity extends AppCompatActivity
                 EmulationActivity.MENU_ACTION_DPAD_SLIDE_ENABLE);
         buttonsActionsMap.append(R.id.menu_emulation_haptic_feedback,
                 EmulationActivity.MENU_ACTION_HAPTIC_FEEDBACK);
+        buttonsActionsMap.append(R.id.menu_emulation_vibrate_on_release,
+                EmulationActivity.MENU_ACTION_VIBRATE_ON_RELEASE);
     }
 
     private View mDecorView;
@@ -583,6 +586,11 @@ public boolean onOptionsItemSelected(MenuItem item) {
             case MENU_ACTION_HAPTIC_FEEDBACK:
                 adjustHapticFeedback();
                 break;
+            case MENU_ACTION_VIBRATE_ON_RELEASE:
+                final boolean isVibrateOnReleaseEnabled = !EmulationMenuSettings.getVibrateOnReleaseEnable();
+                EmulationMenuSettings.setVibrateOnReleaseEnable(isVibrateOnReleaseEnabled);
+                item.setChecked(isVibrateOnReleaseEnabled);
+                break;
         }
 
         return true;

src/android/app/src/main/java/org/citra/citra_emu/overlay/InputOverlay.java

@@ -676,7 +676,13 @@ else if (right)
                 newButtonsPressed++;
             }
         }
-        if(newButtonsPressed>0||numButtonsReleased>0){
+        if(
+            newButtonsPressed > 0
+            || (
+                EmulationMenuSettings.getVibrateOnReleaseEnable()
+                && numButtonsReleased > 0
+            )
+        ){
             // Not all devices that support VibrationEffect (API>=26) allow Amplitude Control
             // TODO: could expose vibration duration (ms) and amplitude as separate user preferences
             // Could also allow them (if they're crazy enough) to let it keep vibrating for the duration of the press?

src/android/app/src/main/java/org/citra/citra_emu/utils/EmulationMenuSettings.java

@@ -79,9 +79,20 @@ public static void setShowOverlay(boolean value) {
     public static boolean getFaceButtonSlideEnable() {
         return mPreferences.getBoolean("EmulationMenuSettings_FaceButtonSlideEnable", true);
     }
+
     public static void setFaceButtonSlideEnable(boolean value) {
         final SharedPreferences.Editor editor = mPreferences.edit();
         editor.putBoolean("EmulationMenuSettings_FaceButtonSlideEnable", value);
         editor.apply();
     }
+
+    public static void setVibrateOnReleaseEnable(boolean value) {
+        final SharedPreferences.Editor editor = mPreferences.edit();
+        editor.putBoolean("EmulationMenuSettings_VibrateOnReleaseEnable", value);
+        editor.apply();
+    }
+
+    public static boolean getVibrateOnReleaseEnable() {
+        return mPreferences.getBoolean("EmulationMenuSettings_VibrateOnReleaseEnable", false);
+    }
 }

src/android/app/src/main/res/menu/menu_emulation.xml

@@ -35,6 +35,12 @@
                 android:id="@+id/menu_emulation_adjust_opacity"
                 android:title="@string/emulation_control_opacity" />
 
+            <item
+                android:id="@+id/menu_emulation_toggle_depth_slider"
+                app:showAsAction="never"
+                android:title="@string/emulation_toggle_depth_slider"
+                android:checkable="true" />
+
             <group android:checkableBehavior="all">
                 <item
                     android:id="@+id/menu_emulation_joystick_rel_center"
@@ -48,6 +54,11 @@
                     android:id="@+id/menu_emulation_face_button_slide_enable"
                     android:checkable="true"
                     android:title="@string/emulation_control_face_button_slide_enable" />
+
+                <item
+                    android:id="@+id/menu_emulation_vibrate_on_release"
+                    android:checkable="true"
+                    android:title="@string/emulation_control_vibrate_on_release" />
             </group>
 
             <item
@@ -117,12 +128,6 @@
         android:title="@string/emulation_show_overlay"
         android:checkable="true" />
 
-    <item
-        android:id="@+id/menu_emulation_toggle_depth_slider"
-        app:showAsAction="never"
-        android:title="@string/emulation_toggle_depth_slider"
-        android:checkable="true" />
-
     <item
         android:id="@+id/menu_emulation_open_settings"
         app:showAsAction="never"

src/android/app/src/main/res/values/strings.xml

@@ -228,4 +228,5 @@
     <string name="preparing_shaders">Preparing shaders</string>
     <string name="building_shaders">Building shaders</string>
     <string name="emulation_control_opacity">Adjust Opacity</string>
+    <string name="emulation_control_vibrate_on_release">Vibrate on Release</string>
 </resources>