Less RuboCop, fix use on projects with rubocop config

Author: jakeonfire

Dockerfile

@@ -4,7 +4,7 @@ LABEL maintainer="Jacob Frautschi <[email protected]>"
 
 WORKDIR /usr/src/app
 
-RUN adduser -u 9000 -D app
+RUN adduser -u 9000 -g 9000 -D app
 
 COPY Gemfile Gemfile.lock /usr/src/app/
 

engine.json

@@ -1,11 +1,11 @@
 {
-  "name": "Standard",
+  "name": "codeclimate-standard",
   "description": "Standard is an opinionated wrapper around RuboCop with no configuration necessary.",
   "maintainer": {
     "name": "Jacob Frautschi",
     "email": "[email protected]"
   },
   "languages" : ["Ruby"],
-  "version": "0.6.0a",
+  "version": "0.6.0b",
   "spec_version": "0.3.1"
 }

lib/cc/engine/file_list_resolver.rb

@@ -1,26 +1,20 @@
 module CC
   module Engine
     class FileListResolver
-      def initialize(root:, config_store:, engine_config: {})
+      def initialize(root:, builds_config:, engine_config: {})
         @root = root
         @include_paths = engine_config["include_paths"] || ["./"]
-        @config_store = config_store
+        @builds_config = builds_config
       end
 
       def expanded_list
         absolute_include_paths.flat_map { |path|
-          if Dir.exist?(path)
-            rubocop_runner.send(:find_target_files, [path])
-          elsif rubocop_file_to_include?(path)
-            path
-          end
+          find_target_files(path)
         }.compact
       end
 
       private
 
-      attr_reader :config_store
-
       def absolute_include_paths
         @include_paths.map { |path| to_absolute_path(path) }.compact
       end
@@ -31,17 +25,13 @@ def to_absolute_path(path)
         nil
       end
 
-      def rubocop_file_to_include?(file)
-        root, basename = File.split(file)
-        store = config_store.for(root)
-
-        return false if store.file_to_exclude?(basename)
-
-        file =~ /\.rb$/ || store.file_to_include?(basename)
+      def find_target_files(path)
+        target_files = target_finder.find([path], :all_file_types)
+        target_files.each(&:freeze).freeze
       end
 
-      def rubocop_runner
-        @rubocop_runner ||= RuboCop::Runner.new({}, @config_store)
+      def target_finder
+        @target_finder ||= RuboCop::TargetFinder.new(@builds_config.rubocop_config_store)
       end
     end
   end

lib/cc/engine/source_file.rb

@@ -1,8 +1,8 @@
 module CC
   module Engine
     class SourceFile
-      def initialize(config_store:, io:, path:, root:)
-        @config_store = config_store
+      def initialize(builds_config:, io:, path:, root:)
+        @builds_config = builds_config
         @io = io
         @path = path
         @root = root
@@ -19,23 +19,23 @@ def inspect
 
       private
 
-      attr_reader :config_store, :io, :path, :root
+      attr_reader :builds_config, :io, :path, :root
 
       def processed_source
         RuboCop::ProcessedSource.from_file(path, target_ruby_version)
       end
 
+      def config_store
+        builds_config.rubocop_config_store.for_file(path)
+      end
+
       def target_ruby_version
         config_store.target_ruby_version
       end
 
       def rubocop_team
-        config = ::Standard::BuildsConfig.new.call([])
-
         cop_classes = RuboCop::Cop::Registry.all
-        registry = RuboCop::Cop::Registry.new(cop_classes, config.rubocop_options)
-
-        config_store = config.rubocop_config_store.for_file(path)
+        registry = RuboCop::Cop::Registry.new(cop_classes, builds_config.rubocop_options)
 
         RuboCop::Cop::Team.new(registry, config_store, display_cop_names: false)
       end

lib/cc/engine/standard.rb

@@ -24,7 +24,7 @@ def run
         Dir.chdir(root) do
           files_to_inspect.each do |path|
             SourceFile.new(
-              config_store: config_store.for(path),
+              builds_config: builds_config,
               io: io,
               path: path,
               root: root
@@ -39,14 +39,14 @@ def run
 
       def files_to_inspect
         @files_to_inspect ||= FileListResolver.new(
-          config_store: config_store,
+          builds_config: builds_config,
           engine_config: engine_config,
           root: root
         ).expanded_list
       end
 
-      def config_store
-        @config_store ||= RuboCop::ConfigStore.new
+      def builds_config
+        @builds_config ||= ::Standard::BuildsConfig.new.call([])
       end
     end
   end