Remove remaining Metrics/ references and Fingerprint functionality

Author: jakeonfire

lib/cc/engine/category_parser.rb

@@ -16,14 +16,14 @@ def category
         "Lint" => "Style",
         "Lint/Eval" => "Security",
         "Metrics" => "Complexity",
-        "Metrics/LineLength" => "Style",
         "Performance" => "Bug Risk",
         "Rails" => "Bug Risk",
         "Rails/ActionFilter" => "Style",
         "Rails/Delegate" => "Clarity",
         "Rails/HasAndBelongsToMany" => "Style",
         "Rails/TimeZone" => "Style",
         "Rails/Validation" => "Style",
+        "Standard/SemanticBlocks" => "Style",
         "Style" => "Style",
         "Migrations/RemoveIndex" => "Performance"
       }.freeze

lib/cc/engine/fingerprint.rb

@@ -14,7 +14,6 @@ def initialize(issue, path)
         @path = path
       end
 
-      # rubocop:disable Metrics/MethodLength
       def to_json(*_)
         hash = {
           type: "Issue",
@@ -29,13 +28,8 @@ def to_json(*_)
         }
         hash[:content] = {body: content_body} if content_body.present?
 
-        if (fingerprint = Fingerprint.new(path, cop_name, message).compute)
-          hash[:fingerprint] = fingerprint
-        end
-
         hash.to_json
       end
-      # rubocop:enable Metrics/MethodLength
 
       def check_name
         "Rubocop/#{cop_name}"

lib/cc/engine/issue.rb

@@ -8,7 +8,6 @@
 require "cc/engine/category_parser"
 require "cc/engine/file_list_resolver"
 require "cc/engine/issue"
-require "cc/engine/fingerprint" # TODO: delete? what's fingerprint?
 require "active_support"
 require "active_support/core_ext"
 

lib/cc/engine/standard.rb

@@ -12,8 +12,8 @@ module CC::Engine
         location.last_column = 99
 
         offense = OpenStruct.new
-        offense.cop_name = "Metrics/CyclomaticComplexity"
-        offense.message = "Cyclomatic complexity for complex_method is too high [10/5]"
+        offense.cop_name = "Standard/SemanticBlocks"
+        offense.message = "Prefer `{...}` over `do...end` for functional blocks."
         offense.location = location
         offense
       end
@@ -23,9 +23,9 @@ module CC::Engine
         attributes = JSON.parse(issue.to_json)
 
         expect(attributes["type"]).to eq("Issue")
-        expect(attributes["check_name"]).to eq("Rubocop/Metrics/CyclomaticComplexity")
-        expect(attributes["description"]).to eq("Cyclomatic complexity for complex_method is too high [10/5]")
-        expect(attributes["categories"]).to eq(["Complexity"])
+        expect(attributes["check_name"]).to eq("Rubocop/Standard/SemanticBlocks")
+        expect(attributes["description"]).to eq("Prefer `{...}` over `do...end` for functional blocks.")
+        expect(attributes["categories"]).to eq(["Style"])
         expect(attributes["remediation_points"]).to eq(50_000)
         expect(attributes["location"]["path"]).to eq("app/models/user.rb")
         expect(attributes["location"]["positions"]["begin"]["line"]).to eq(10)
@@ -36,22 +36,6 @@ module CC::Engine
           "This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum."
         )
       end
-
-      it "sets a fingerprint for method/class offenses" do
-        offense.cop_name = "Metrics/AbcSize"
-        issue = Issue.new(offense, "app/models/user.rb")
-        attributes = JSON.parse(issue.to_json)
-
-        expect(attributes).to have_key("fingerprint")
-      end
-
-      it "does not set a fingerprint for other offenses" do
-        offense.cop_name = "Style/AlignParameters"
-        issue = Issue.new(offense, "app/models/user.rb")
-        attributes = JSON.parse(issue.to_json)
-
-        expect(attributes).not_to have_key("fingerprint")
-      end
     end
 
     describe "#remediation points" do