Skip to content

Commit ac751bd

Browse files
committed
Fix some specs
1 parent 7f21f72 commit ac751bd

File tree

1 file changed

+28
-18
lines changed

1 file changed

+28
-18
lines changed

spec/cc/engine/file_list_resolver_spec.rb

Lines changed: 28 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,32 @@
11
require "spec_helper"
2-
require "rubocop"
2+
require "standard"
33
require "cc/engine/file_list_resolver"
44

55
module CC::Engine
66
describe FileListResolver do
77
include FilesystemHelpers
88

99
before { @code = Dir.mktmpdir }
10-
let(:rubocop_config) { RuboCop::ConfigStore.new }
10+
let(:builds_config) { ::Standard::BuildsConfig.new.call([]) }
1111

1212
it "uses default include path" do
1313
Dir.chdir(@code) do
1414
create_source_file("a.rb", "def a; true; end")
1515
create_source_file("not_ruby.txt", "some text")
1616

17-
resolver = FileListResolver.new(root: @code, engine_config: {}, config_store: rubocop_config)
17+
resolver = FileListResolver.new(root: @code, engine_config: {}, builds_config: builds_config)
1818
expect(resolver.expanded_list).to eq [Pathname.new("a.rb").realpath.to_s]
1919
end
2020
end
2121

2222
it "finds ruby scripts without extensions" do
2323
Dir.chdir(@code) do
2424
create_source_file("a.rb", "def a; true; end")
25-
create_source_file("bin/some_script", "#!/usr/bin/env ruby")
26-
create_source_file("bin/some_other_script", "#!/usr/bin/env sh")
25+
create_source_file("scripts/some_script", "#!/usr/bin/env ruby")
26+
create_source_file("scripts/some_other_script", "#!/usr/bin/env sh")
2727

28-
resolver = FileListResolver.new(root: @code, engine_config: {}, config_store: rubocop_config)
29-
expect(resolver.expanded_list).to eq %w[a.rb bin/some_script].map { |fn| Pathname.new(fn).realpath.to_s }
28+
resolver = FileListResolver.new(root: @code, engine_config: {}, builds_config: builds_config)
29+
expect(resolver.expanded_list).to eq %w[a.rb scripts/some_script].map { |fn| Pathname.new(fn).realpath.to_s }
3030
end
3131
end
3232

@@ -35,25 +35,35 @@ module CC::Engine
3535
create_source_file("a.rb", "def a; true; end")
3636
create_source_file("src/b.rb", "def a; true; end")
3737

38-
resolver = FileListResolver.new(root: @code, engine_config: {"include_paths" => %w[src/]}, config_store: rubocop_config)
38+
resolver = FileListResolver.new(root: @code, engine_config: {"include_paths" => %w[src/]}, builds_config: builds_config)
3939
expect(resolver.expanded_list).to eq [Pathname.new("src/b.rb").realpath.to_s]
4040
end
4141
end
4242

43-
it "respects rubocop excludes" do
43+
it "respects default ignore list" do
44+
Dir.chdir(@code) do
45+
create_source_file("vendor/foo/a.rb", "def a; true; end")
46+
create_source_file("bin/b.rb", "def a; true; end")
47+
create_source_file("tmp/c.rb", "def a; true; end")
48+
create_source_file("db/schema.rb", "ActiveRecord::Schema.define(:version => #{Time.current.to_i}) do; end")
49+
50+
resolver = FileListResolver.new(root: @code, engine_config: {}, builds_config: builds_config)
51+
expect(resolver.expanded_list).to be_empty
52+
end
53+
end
54+
55+
it "respects ignore list in standard config" do
4456
Dir.chdir(@code) do
4557
create_source_file("Gemfile", "source 'https://rubygems.org'")
4658
create_source_file("src/b.rb", "def a; true; end")
4759
create_source_file("src/c.rb", "def a; true; end")
48-
create_source_file(".rubocop.yml", <<~YML)
49-
AllCops:
50-
NewCops: enable
51-
Exclude:
52-
- src/c.rb
53-
- Gemfile
54-
YML
60+
create_source_file(".standard.yml", <<~YAML)
61+
ignore:
62+
- src/c.rb
63+
- Gemfile
64+
YAML
5565

56-
resolver = FileListResolver.new(root: @code, engine_config: {"include_paths" => %w[Gemfile src/]}, config_store: rubocop_config)
66+
resolver = FileListResolver.new(root: @code, engine_config: {}, builds_config: builds_config)
5767
expect(resolver.expanded_list).to eq [Pathname.new("src/b.rb").realpath.to_s]
5868
end
5969
end
@@ -62,7 +72,7 @@ module CC::Engine
6272
Dir.chdir(@code) do
6373
create_source_file("src/b.rb", "def a; true; end")
6474

65-
resolver = FileListResolver.new(root: @code, engine_config: {"include_paths" => %w[src/ public/assets]}, config_store: rubocop_config)
75+
resolver = FileListResolver.new(root: @code, engine_config: {"include_paths" => %w[src/ public/assets]}, builds_config: builds_config)
6676
expect(resolver.expanded_list).to eq [Pathname.new("src/b.rb").realpath.to_s]
6777
end
6878
end

0 commit comments

Comments
 (0)