Skip to content

Commit 758818a

Browse files
committed
fix path for vulkan runtime detection
1 parent 952b662 commit 758818a

File tree

5 files changed

+12
-5
lines changed

5 files changed

+12
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1717

1818
- fixed MAC Installer filename
1919
- fixed ubuntu-24.04-arm release not found
20+
- fix path for Vulkan Runtime detection on Windows
2021

2122
## [1.2.2] - 2025-05-06
2223

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/installer_vulkan.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,12 +441,18 @@ export function runVulkanInfo(vulkanInfoPath: string): void {
441441
*
442442
* @export
443443
* @param {string} sdk_install_path - The installation path of the Vulkan SDK, e.g. "C:\VulkanSDK\1.3.250.1".
444+
* @param {string} version - The version of the Vulkan SDK.
444445
* @return {*} {boolean}
445446
*/
446-
export function verifyInstallationOfRuntime(sdkInstallPath: string): boolean {
447+
export function verifyInstallationOfRuntime(sdkInstallPath: string, version: string): boolean {
447448
let r = false
448449
if (platform.IS_WINDOWS || platform.IS_WINDOWS_ARM) {
449-
const file = `${sdkInstallPath}/runtime/x64/vulkan-1.dll`
450+
let file = ''
451+
if (version <= '1.4.309.0') {
452+
file = `${sdkInstallPath}/runtime/x64/vulkan-1.dll`
453+
} else if (version > '1.4.309.0') {
454+
file = `${sdkInstallPath}/runtime/vulkan-1.dll`
455+
}
450456
r = fs.existsSync(file)
451457
}
452458
return r

src/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ export async function run(): Promise<void> {
175175

176176
if ((platform.IS_WINDOWS || platform.IS_WINDOWS_ARM) && inputs.installRuntime) {
177177
const runtimePath = `${installPath}\\runtime`
178-
if (installerVulkan.verifyInstallationOfRuntime(installPath)) {
178+
if (installerVulkan.verifyInstallationOfRuntime(installPath, version)) {
179179
core.info(`✔️ [INFO] Path to Vulkan Runtime: ${runtimePath}`)
180180
} else {
181181
core.warning(`Could not find Vulkan Runtime in ${runtimePath}`)

0 commit comments

Comments
 (0)