Skip to content

Commit 758ee83

Browse files
committed
several smaller bugfies to parameter handling, removed unused parameters, added more tests to raise coverage in general and cover installer edge cases, updated packages
1 parent 83a1075 commit 758ee83

21 files changed

+777
-90
lines changed

.devcontainer/devcontainer.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,7 @@
4545
"terminal.integrated.defaultProfile.linux": "zsh",
4646
"terminal.integrated.shell.linux": "/bin/zsh",
4747
// tell VSCode that you want the shell to be a login, interactive shell
48-
"terminal.integrated.shellArgs.linux": [
49-
"-l",
50-
"-i"
51-
]
48+
"terminal.integrated.shellArgs.linux": ["-l", "-i"]
5249
}
5350
}
5451
// Use 'forwardPorts' to make a list of ports inside the container available locally.

CHANGELOG.md

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111

1212
- "It was a bright day in April, and the clocks were striking thirteen." - 1984
1313

14-
## [1.2.5] - 2025-12-06
14+
## [1.2.6] - 2025-09-22
15+
16+
## Fixed
17+
- Updated `getCacheKeys` function to remove the installation path parameter.
18+
- Modified `getVulkanSdk` to align with the new `getCacheKeys` signature.
19+
- Adjusted Vulkan runtime installation calls to match updated parameters.
20+
- Ensured proper handling of latest version retrieval in `getLatestVersionsJson`.
21+
- Improved error handling in `getLowerVersion` to return a rejected promise for empty version lists.
22+
- Added tests for unsupported platforms in the `extract` function.
23+
- Added more tests
24+
25+
## [1.2.5] - 2025-06-12
1526

1627
### Fixed
1728

@@ -22,7 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2233
This is done to ensure backwards compatibility with CI steps, which copy files from this location.
2334
- fixed verifyInstallationOfRuntime() to detect the runtime files correctly
2435

25-
## [1.2.4] - 2025-11-06
36+
## [1.2.4] - 2025-06-11
2637

2738
### Fixed
2839

biome.json

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,25 @@
11
{
2-
"$schema": "https://biomejs.dev/schemas/2.0.6/schema.json",
2+
"$schema": "https://biomejs.dev/schemas/2.2.0/schema.json",
33
"vcs": {
44
"enabled": false,
55
"clientKind": "git",
66
"useIgnoreFile": true
77
},
88
"files": {
99
"ignoreUnknown": false,
10-
"includes": ["**"]
10+
"includes": [
11+
"**",
12+
"!.devcontainer",
13+
"!.git",
14+
"!.github",
15+
"!.vscode",
16+
"!build-tools",
17+
"!coverage",
18+
"!dist",
19+
"!lib",
20+
"!node_modules",
21+
"!tests"
22+
]
1123
},
1224
"formatter": {
1325
"enabled": true,
@@ -21,13 +33,17 @@
2133
"bracketSpacing": true,
2234
"includes": [
2335
"**",
24-
"!.devcontainer/**",
25-
"!.github/**",
26-
"!build-tools/**",
27-
"!dist/**",
36+
"!**/.devcontainer/",
37+
"!**/.git/",
38+
"!**/.github/",
39+
"!**/.vscode/",
40+
"!**/build-tools/",
41+
"!**/coverage/**",
42+
"!**/dist/",
43+
"!**/lib/**",
2844
"!lib/**",
29-
"!node_modules/**",
30-
"!coverage/**"
45+
"!**/node_modules/",
46+
"!**/tests/"
3147
]
3248
},
3349
"assist": { "actions": { "source": { "organizeImports": "on" } } },
@@ -135,9 +151,10 @@
135151
"!**/.github/",
136152
"!**/.vscode/",
137153
"!**/build-tools/",
138-
"!**/coverage/",
154+
"!**/coverage/**",
139155
"!**/dist/",
140-
"!**/lib/",
156+
"!**/lib/**",
157+
"!lib/**",
141158
"!**/node_modules/",
142159
"!**/tests/"
143160
]

dist/index.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 36 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
"lint:fix": "npx @biomejs/biome lint --write",
1515
"local:run": "npx @github/local-action run . ./src/main.ts env.local",
1616
"package": "ncc build --source-map --minify",
17-
"test": "jest --no-cache --verbose --detectOpenHandles --runInBand",
17+
"test": "jest --verbose --detectOpenHandles --runInBand",
1818
"test:cov": "jest --verbose --coverage",
19+
"test:nocache": "jest --verbose --detectOpenHandles --runInBand --no-cache",
1920
"npm:audit": "npm audit --audit-level=high fix",
2021
"npm:outdated": "npm outdated",
2122
"npm:clean_install": "npm clean-install --no-audit --strict-peer-deps",
@@ -35,13 +36,13 @@
3536
"main": "lib/main.js",
3637
"dependencies": {
3738
"@actions/cache": "^4",
38-
"@actions/core": "^1.11.1",
39-
"@actions/http-client": "^2.1.1",
40-
"@actions/io": "^1.1.3",
41-
"@actions/tool-cache": "^2.0.1"
39+
"@actions/core": "^1",
40+
"@actions/http-client": "^2",
41+
"@actions/io": "^1",
42+
"@actions/tool-cache": "^2"
4243
},
4344
"devDependencies": {
44-
"@biomejs/biome": "2.2.0",
45+
"@biomejs/biome": "^2",
4546
"@github/local-action": "^6.0.0",
4647
"@types/jest": "^30",
4748
"@types/node": "^24.5",

src/downloader.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,11 +115,11 @@ export async function getUrlVulkanRuntime(version: string): Promise<string> {
115115
let vulkanRuntimeUrl = ''
116116
if (platformName === 'windows') {
117117
// https://sdk.lunarg.com/sdk/download/1.3.250.1/windows/VulkanRT-1.3.250.1-Components.zip
118-
vulkanRuntimeUrl = `https://sdk.lunarg.com/sdk/download/${currentVersion}/${platformName}/VulkanRT-${currentVersion}-Components.zip`
118+
vulkanRuntimeUrl = `https://sdk.lunarg.com/sdk/download/${currentVersion}/${platformName}/vulkan-runtime-components.zip`
119119
}
120120
if (platformName === 'warm') {
121121
// https://sdk.lunarg.com/sdk/download/1.4.309.0/warm/VulkanRT-ARM64-1.4.309.0-Components.zip
122-
vulkanRuntimeUrl = `https://sdk.lunarg.com/sdk/download/${currentVersion}/${platformName}/VulkanRT-ARM64-${currentVersion}-Components.zip`
122+
vulkanRuntimeUrl = `https://sdk.lunarg.com/sdk/download/${currentVersion}/${platformName}/vulkan-runtime-components.zip`
123123
}
124124
try {
125125
// isDownloadable throws, if the download is not available

src/github.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@ import * as http from './http'
99
export interface GithubReleaseAssets {
1010
name: string
1111
url: string
12-
// biome-ignore lint/style/useNamingConvention: <explanation>
12+
// biome-ignore lint: style/useNamingConvention
1313
browser_download_url: string
1414
}
1515

1616
export interface GithubRelease {
17-
// biome-ignore lint/style/useNamingConvention: <explanation>
17+
// biome-ignore lint: style/useNamingConvention
1818
tag_name: string
19-
// biome-ignore lint/style/useNamingConvention: <explanation>
19+
// biome-ignore lint: style/useNamingConvention
2020
assets_url: string
21-
// biome-ignore lint/style/useNamingConvention: <explanation>
21+
// biome-ignore lint: style/useNamingConvention
2222
upload_url: string
2323
assets: GithubReleaseAssets[]
2424
}
@@ -53,9 +53,7 @@ export const getLatestRelease = async (owner: string, repo: string): Promise<Git
5353
export const getLatestVersion = async (owner: string, repo: string): Promise<string | null> => {
5454
try {
5555
const response = await getLatestRelease(owner, repo)
56-
// biome-ignore lint/style/useNamingConvention: <explanation>
5756
if (response && response.tag_name) {
58-
// biome-ignore lint/style/useNamingConvention: <explanation>
5957
return response.tag_name
6058
} else {
6159
return null // Unable to retrieve the version.

src/installer_vulkan.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ export async function installVulkanSdkLinux(
6868
destination: string,
6969
optionalComponents: string[]
7070
): Promise<string> {
71+
optionalComponents = [] // no optional components on linux
72+
7173
const installPath = await archive.extract(sdkPath, destination)
7274

7375
return installPath
@@ -345,10 +347,9 @@ export async function installVulkanRuntime(runtimePath: string, destination: str
345347
*
346348
* @export
347349
* @param {string} destination
348-
* @param {string} version
349350
* @return {*} {string} - The installation path of the Vulkan Runtime.
350351
*/
351-
export function installVulkanRuntimeFromSdk(destination: string, version: string): string {
352+
export function installVulkanRuntimeFromSdk(destination: string): string {
352353
core.info(`📦 Placing Vulkan Runtime into the SDK folder...`)
353354

354355
// origin
@@ -517,10 +518,9 @@ export function runVulkanInfo(vulkanInfoPath: string): void {
517518
*
518519
* @export
519520
* @param {string} sdkRuntimePath - Path to the runtime folder, e.g. "C:\VulkanSDK\1.3.250.1\runtime".
520-
* @param {string} version - The version of the Vulkan SDK.
521521
* @return {*} {boolean}
522522
*/
523-
export function verifyInstallationOfRuntime(sdkRuntimePath: string, version: string): boolean {
523+
export function verifyInstallationOfRuntime(sdkRuntimePath: string): boolean {
524524
if (!(platform.IS_WINDOWS || platform.IS_WINDOWS_ARM)) return false
525525
const basePath = path.normalize(`${sdkRuntimePath}/x64`)
526526
const requiredFiles = ['vulkan-1.dll', 'vulkaninfo.exe']

0 commit comments

Comments
 (0)