Skip to content

Commit 47f882e

Browse files
committed
Release v1.2.0
- add emoji for security scanning action - update release.yml - login to docker/ghcr first, then do hadolint? - pull debian image manually - do not delete local docker images? - replace sklearn with scikit-learn
1 parent a48d0cb commit 47f882e

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ RUN pip3 config --user set global.disable-pip-version-check true && \
7777
pip3 install --upgrade wheel && \
7878
pip3 install tensorflow && \
7979
pip3 install ipykernel docutils jupyter notebook pyyaml pylint h5py && \
80-
pip3 install numpy pandas sklearn scipy && \
80+
pip3 install numpy pandas scikit-learn scipy && \
8181
pip3 install matplotlib seaborn pydotplus && \
8282
pip3 install keras --no-deps && \
8383
pip3 install opencv-python && \

.github/workflows/release.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,28 @@ jobs:
2626
uses: jlumbroso/free-disk-space@main # https://github.com/jlumbroso/free-disk-space
2727
with:
2828
tool-cache: true
29+
docker-images: false
2930

3031
- name: 🤘 Checkout Code
3132
uses: actions/checkout@v3 # https://github.com/actions/checkout
3233

33-
- uses: hadolint/hadolint-action@v3.1.0 # https://github.com/hadolint/hadolint-action
34-
with:
35-
dockerfile: .devcontainer/Dockerfile
36-
no-fail: true
37-
3834
- name: 🔒 Login to Container Registry
3935
uses: docker/login-action@v2 # https://github.com/docker/login-action
4036
with:
4137
registry: ghcr.io
4238
username: ${{ github.actor }}
4339
password: ${{ secrets.GITHUB_TOKEN }}
4440

41+
# https://hub.docker.com/_/debian
42+
- name: Pull Debian Slim manually
43+
run: |
44+
docker pull debian:bookworm-slim
45+
46+
- uses: hadolint/hadolint-action@v3.1.0 # https://github.com/hadolint/hadolint-action
47+
with:
48+
dockerfile: .devcontainer/Dockerfile
49+
no-fail: true
50+
4551
- name: 📝 Versionize
4652
run: |
4753
if [[ "$GITHUB_REF" =~ ^refs/tags/v* ]]; then
@@ -65,7 +71,7 @@ jobs:
6571
docker tag ghcr.io/${{ github.repository }}:$TAG ghcr.io/${{ github.repository }}:latest
6672
docker push ghcr.io/${{ github.repository }}:latest
6773
68-
- name: Scan Image for Vulnerabilities
74+
- name: 🛡️🔍 Scan Image for Vulnerabilities
6975
uses: aquasecurity/trivy-action@master # https://github.com/aquasecurity/trivy-action
7076
with:
7177
image-ref: 'ghcr.io/${{ github.repository }}:latest'
@@ -74,7 +80,7 @@ jobs:
7480
severity: 'CRITICAL,HIGH'
7581
ignore-unfixed: true
7682

77-
- name: Upload scan results to GitHub Security tab
83+
- name: 🛡️🔼 Upload scan results to GitHub Security tab
7884
uses: github/codeql-action/upload-sarif@v2 # https://github.com/github/codeql-action
7985
with:
8086
sarif_file: 'trivy-results.sarif'

0 commit comments

Comments
 (0)