Skip to content

Commit ca6fcf6

Browse files
authored
Merge pull request #24 from BenMorel/reenable
Re-enable stuff on PHP 8
2 parents 434a2fb + f0494a0 commit ca6fcf6

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ jobs:
3636
if: matrix.deps == 'high'
3737
run: make install test
3838

39-
# Separate package step until PHP 8.0 is supported
4039
- name: Coding standards
41-
if: matrix.php != '8.0' && matrix.php != '8.1'
4240
run: make package
4341

4442
- name: Test & package (min)

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
IS_PHP8:=$(shell php -r 'echo (int)version_compare(PHP_VERSION, "8.0", ">=");')
1+
IS_PHP81:=$(shell php -r 'echo (int)version_compare(PHP_VERSION, "8.1", ">=");')
22

33
default: build
44

@@ -31,15 +31,15 @@ test-package: test-package-tools
3131
cd tests/phar && ./tools/phpunit
3232
.PHONY: test-package
3333

34-
ifeq ($(IS_PHP8),1)
34+
ifeq ($(IS_PHP81),1)
3535
cs:
3636
else
3737
cs: tools/php-cs-fixer
3838
tools/php-cs-fixer --dry-run --allow-risky=yes --no-interaction --ansi fix
3939
endif
4040
.PHONY: cs
4141

42-
ifeq ($(IS_PHP8),1)
42+
ifeq ($(IS_PHP81),1)
4343
cs-fix:
4444
else
4545
cs-fix: tools/php-cs-fixer

0 commit comments

Comments
 (0)