Rename validate in presentation.*pp

Author: james-d-mitchell

benchmarks/bench-sims1.cpp

@@ -834,7 +834,7 @@ namespace libsemigroups {
     REQUIRE(S.size() == 81);
 
     auto p = to<Presentation<word_type>>(S);
-    p.validate();
+    p.throw_if_bad_alphabet_or_rules();
     REQUIRE(p.alphabet().size() == 10);
     REQUIRE(presentation::length(p) == 719);
 

include/libsemigroups/cong-class.tpp

@@ -180,7 +180,7 @@ namespace libsemigroups {
       return;
     }
     LIBSEMIGROUPS_EXCEPTION(
-        "No presentation has been set, so cannot validate the word!");
+        "No presentation has been set, so cannot check the word!");
   }
 
   template <typename Word>

include/libsemigroups/detail/felsch-graph.tpp

@@ -331,7 +331,7 @@ namespace libsemigroups {
     FelschGraph<Word, Node, Definitions>&
     FelschGraph<Word, Node, Definitions>::private_init_from_presentation() {
 #ifdef LIBSEMIGROUPS_DEBUG
-      _presentation.validate();
+      _presentation.throw_if_bad_alphabet_or_rules();
 #endif
       size_t r = (_presentation.contains_empty_word() ? 0 : 1);
       size_t c = _presentation.alphabet().size();

include/libsemigroups/detail/knuth-bendix-impl.hpp

@@ -729,10 +729,11 @@ namespace libsemigroups {
       // KnuthBendixImpl - member functions for rules and rewriting - public
       //////////////////////////////////////////////////////////////////////////
 
+      // TODO(1) remove
       template <typename Iterator1, typename Iterator2>
       void throw_if_letter_out_of_bounds(Iterator1 first,
                                          Iterator2 last) const {
-        internal_presentation().validate_word(first, last);
+        internal_presentation().throw_if_letter_not_in_alphabet(first, last);
       }
 
       [[nodiscard]] Presentation<std::string> const&

include/libsemigroups/detail/knuth-bendix-impl.tpp

@@ -252,7 +252,7 @@ namespace libsemigroups {
     KnuthBendixImpl<Rewriter, ReductionOrder>::init(
         congruence_kind             knd,
         Presentation<std::string>&& p) {
-      p.validate();
+      p.throw_if_bad_alphabet_or_rules();
       init();
       CongruenceCommon::init(knd);
       _presentation = std::move(p);

include/libsemigroups/detail/todd-coxeter-impl.hpp

@@ -363,10 +363,11 @@ namespace libsemigroups {
                             WordGraph<Node> const&         wg);
 #endif
 
+      // TODO(0) remove?
       template <typename Iterator1, typename Iterator2>
       void throw_if_letter_out_of_bounds(Iterator1 first,
                                          Iterator2 last) const {
-        internal_presentation().validate_word(first, last);
+        internal_presentation().throw_if_letter_not_in_alphabet(first, last);
       }
 
       ////////////////////////////////////////////////////////////////////////

include/libsemigroups/kambites-class.hpp

@@ -786,7 +786,7 @@ namespace libsemigroups {
     //! \p first to \p last is out of bounds.
     template <typename Iterator1, typename Iterator2>
     void throw_if_letter_out_of_bounds(Iterator1 first, Iterator2 last) const {
-      _presentation.validate_word(first, last);
+      _presentation.throw_if_letter_not_in_alphabet(first, last);
     }
 
     //! \ingroup kambites_class_init_group

include/libsemigroups/kambites-class.tpp

@@ -143,7 +143,7 @@ namespace libsemigroups {
   Kambites<Word>& Kambites<Word>::init(congruence_kind                  knd,
                                        Presentation<native_word_type>&& p) {
     throw_if_1_sided(knd);
-    p.validate();
+    p.throw_if_bad_alphabet_or_rules();
     init();
     _presentation = std::move(p);
     ukkonen::add_words_no_checks(
@@ -184,7 +184,7 @@ namespace libsemigroups {
     if (success()) {
       _tmp_value1.assign(first1, last1);
       _tmp_value2.assign(first2, last2);
-      // Words aren't validated, the below returns false if they contain
+      // Words aren't checked, the below returns false if they contain
       // letters not in the alphabet.
       // The Kambites class requires that input to contains to be actual
       // objects not iterators. This is different from KnuthBendixImpl and

include/libsemigroups/knuth-bendix-class.hpp

@@ -260,9 +260,10 @@ namespace libsemigroups {
     //!
     //! \throw LibsemigroupsException if any letter in the range from
     //! \p first to \p last is out of bounds.
+    // TODO(0) remove this
     template <typename Iterator1, typename Iterator2>
     void throw_if_letter_out_of_bounds(Iterator1 first, Iterator2 last) const {
-      presentation().validate_word(first, last);
+      presentation().throw_if_letter_not_in_alphabet(first, last);
     }
 
 #ifdef LIBSEMIGROUPS_PARSED_BY_DOXYGEN

include/libsemigroups/knuth-bendix-helpers.tpp

@@ -241,7 +241,7 @@ namespace libsemigroups {
     redundant_rule(Presentation<Word> const& p, Time t) {
       constexpr static congruence_kind twosided = congruence_kind::twosided;
 
-      p.validate();
+      p.throw_if_bad_alphabet_or_rules();
       Presentation<Word> q;
       q.alphabet(p.alphabet());
       q.contains_empty_word(p.contains_empty_word());
@@ -302,7 +302,7 @@ namespace libsemigroups {
     //   constexpr static congruence_kind twosided =
     //   congruence_kind::twosided;
 
-    //   // TODO(1) validate lhs and rhs
+    //   // TODO(1) throw_if_bad_alphabet_or_rules lhs and rhs
     //   KnuthBendixImpl         kb(twosided, p);
     //   std::string         lphbt = p.alphabet();
     //   std::vector<size_t> perm(lphbt.size(), 0);
@@ -312,7 +312,7 @@ namespace libsemigroups {
     //     detail::apply_permutation(lphbt, perm);
 
     //     p.alphabet(lphbt);
-    //     p.validate();
+    //     p.throw_if_bad_alphabet_or_rules();
 
     //     kb.init(twosided, p);
     //     // TODO(1) no checks