Skip to content

Commit 691ec36

Browse files
jamesgeorge007tuunit
authored andcommitted
fix: prevent showing stack trace on the course of error
1 parent 762c517 commit 691ec36

File tree

2 files changed

+44
-26
lines changed

2 files changed

+44
-26
lines changed

dist/index.js

Lines changed: 22 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1840,20 +1840,31 @@ const toUrlFormat = (item) => {
18401840

18411841
const exec = (cmd, args = []) =>
18421842
new Promise((resolve, reject) => {
1843-
const app = spawn(cmd, args, { stdio: "pipe" });
1843+
const app = spawn(cmd, args);
1844+
18441845
let stdout = "";
1845-
app.stdout.on("data", (data) => {
1846-
stdout = data;
1847-
});
1846+
if (app.stdout) {
1847+
app.stdout.on("data", (data) => {
1848+
stdout += data.toString();
1849+
});
1850+
}
1851+
1852+
let stderr = "";
1853+
if (app.stderr) {
1854+
app.stderr.on("data", (data) => {
1855+
stderr += data.toString();
1856+
});
1857+
}
1858+
18481859
app.on("close", (code) => {
18491860
if (code !== 0 && !stdout.includes("nothing to commit")) {
1850-
err = new Error(`Invalid status code: ${code}`);
1851-
err.code = code;
1852-
return reject(err);
1861+
return reject({ code, message: stderr });
18531862
}
1854-
return resolve(code);
1863+
1864+
return resolve({ code, stdout });
18551865
});
1856-
app.on("error", reject);
1866+
1867+
app.on("error", () => reject({ code: 1, message: stderr }));
18571868
});
18581869

18591870
/**
@@ -1981,8 +1992,7 @@ Toolkit.run(
19811992
try {
19821993
await commitFile();
19831994
} catch (err) {
1984-
tools.log.debug("Something went wrong");
1985-
return tools.exit.failure(err);
1995+
return tools.exit.failure(err.message);
19861996
}
19871997
tools.exit.success("Wrote to README");
19881998
}
@@ -2032,8 +2042,7 @@ Toolkit.run(
20322042
try {
20332043
await commitFile();
20342044
} catch (err) {
2035-
tools.log.debug("Something went wrong");
2036-
return tools.exit.failure(err);
2045+
return tools.exit.failure(err.message);
20372046
}
20382047
tools.exit.success("Pushed to remote repository");
20392048
},

index.js

Lines changed: 22 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,20 +57,31 @@ const toUrlFormat = (item) => {
5757

5858
const exec = (cmd, args = []) =>
5959
new Promise((resolve, reject) => {
60-
const app = spawn(cmd, args, { stdio: "pipe" });
60+
const app = spawn(cmd, args);
61+
6162
let stdout = "";
62-
app.stdout.on("data", (data) => {
63-
stdout = data;
64-
});
63+
if (app.stdout) {
64+
app.stdout.on("data", (data) => {
65+
stdout += data.toString();
66+
});
67+
}
68+
69+
let stderr = "";
70+
if (app.stderr) {
71+
app.stderr.on("data", (data) => {
72+
stderr += data.toString();
73+
});
74+
}
75+
6576
app.on("close", (code) => {
6677
if (code !== 0 && !stdout.includes("nothing to commit")) {
67-
err = new Error(`Invalid status code: ${code}`);
68-
err.code = code;
69-
return reject(err);
78+
return reject({ code, message: stderr });
7079
}
71-
return resolve(code);
80+
81+
return resolve({ code, stdout });
7282
});
73-
app.on("error", reject);
83+
84+
app.on("error", () => reject({ code: 1, message: stderr }));
7485
});
7586

7687
/**
@@ -198,8 +209,7 @@ Toolkit.run(
198209
try {
199210
await commitFile();
200211
} catch (err) {
201-
tools.log.debug("Something went wrong");
202-
return tools.exit.failure(err);
212+
return tools.exit.failure(err.message);
203213
}
204214
tools.exit.success("Wrote to README");
205215
}
@@ -249,8 +259,7 @@ Toolkit.run(
249259
try {
250260
await commitFile();
251261
} catch (err) {
252-
tools.log.debug("Something went wrong");
253-
return tools.exit.failure(err);
262+
return tools.exit.failure(err.message);
254263
}
255264
tools.exit.success("Pushed to remote repository");
256265
},

0 commit comments

Comments
 (0)