Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Commit b2d6b9b

Browse files
committed
Make change from $modal/Instance to $uibModal/Instance
1 parent 92cb988 commit b2d6b9b

File tree

4 files changed

+26
-26
lines changed

4 files changed

+26
-26
lines changed

angular-confirm.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
/*
22
* angular-confirm
33
* https://github.com/Schlogen/angular-confirm
4-
* @version v1.1.2 - 2015-09-26
4+
* @version v1.2.0 - 2015-11-18
55
* @license Apache
66
*/
77
angular.module('angular-confirm', ['ui.bootstrap.modal'])
8-
.controller('ConfirmModalController', function ($scope, $modalInstance, data) {
8+
.controller('ConfirmModalController', function ($scope, $uibModalInstance, data) {
99
$scope.data = angular.copy(data);
1010

1111
$scope.ok = function () {
12-
$modalInstance.close();
12+
$uibModalInstance.close();
1313
};
1414

1515
$scope.cancel = function () {
16-
$modalInstance.dismiss('cancel');
16+
$uibModalInstance.dismiss('cancel');
1717
};
1818

1919
})
@@ -31,7 +31,7 @@ angular.module('angular-confirm', ['ui.bootstrap.modal'])
3131
cancel: 'Cancel'
3232
}
3333
})
34-
.factory('$confirm', function ($modal, $confirmModalDefaults) {
34+
.factory('$confirm', function ($uibModal, $confirmModalDefaults) {
3535
return function (data, settings) {
3636
var defaults = angular.copy($confirmModalDefaults);
3737
settings = angular.extend(defaults, (settings || {}));
@@ -48,7 +48,7 @@ angular.module('angular-confirm', ['ui.bootstrap.modal'])
4848
}
4949
};
5050

51-
return $modal.open(settings).result;
51+
return $uibModal.open(settings).result;
5252
};
5353
})
5454
.directive('confirm', function ($confirm) {

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "angular-confirm-modal",
33
"main": "angular-confirm.min.js",
4-
"version": "1.1.2",
4+
"version": "1.2.0",
55
"homepage": "https://github.com/Schlogen/angular-confirm",
66
"authors": [
77
"James Kleeh"

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-confirm",
3-
"version": "1.1.2",
3+
"version": "1.2.0",
44
"description": "Angular Confirm Modal",
55
"main": "angular-confirm.min.js",
66
"scripts": {
@@ -23,9 +23,9 @@
2323
},
2424
"homepage": "https://github.com/Schlogen/angular-confirm",
2525
"devDependencies": {
26-
"angular": "1.4.2",
26+
"angular": "1.4.7",
2727
"angular-ui-bootstrap": "0.14.3",
28-
"angular-mocks": "^1.4.2",
28+
"angular-mocks": "^1.4.7",
2929
"gulp": "3.9.0",
3030
"gulp-bump": "^1.0.0",
3131
"gulp-git": "^1.6.0",

test/unit/confirmSpec.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
describe('angular-confirm', function() {
22

3-
var $rootScope, $modal;
3+
var $rootScope, $uibModal;
44

55
beforeEach(angular.mock.module('angular-confirm', function ($provide) {
66

7-
$provide.decorator('$modal', function($delegate) {
8-
$modal = {
9-
open: jasmine.createSpy('$modal.open', function(settings) {
7+
$provide.decorator('$uibModal', function($delegate) {
8+
$uibModal = {
9+
open: jasmine.createSpy('$uibModal.open', function(settings) {
1010
return {result: settings};
1111
})
1212
};
13-
return $modal;
13+
return $uibModal;
1414
});
1515

1616
$provide.decorator('$confirm', function($delegate) {
@@ -24,18 +24,18 @@ describe('angular-confirm', function() {
2424
}));
2525

2626
describe('ConfirmModalController', function() {
27-
var $scope, controller, data = {testVal: 1}, $modalInstance;
27+
var $scope, controller, data = {testVal: 1}, $uibModalInstance;
2828

2929
beforeEach(angular.mock.inject(function($controller) {
3030
$scope = $rootScope.$new();
31-
$modalInstance = {
32-
close: jasmine.createSpy('modalInstance.close'),
33-
dismiss: jasmine.createSpy('modalInstance.dismiss'),
31+
$uibModalInstance = {
32+
close: jasmine.createSpy('$uibModalInstance.close'),
33+
dismiss: jasmine.createSpy('$uibModalInstance.dismiss'),
3434
result: {
35-
then: jasmine.createSpy('modalInstance.result.then')
35+
then: jasmine.createSpy('$uibModalInstance.result.then')
3636
}
3737
};
38-
controller = $controller('ConfirmModalController', {"$scope": $scope, "$modalInstance": $modalInstance, "data": data});
38+
controller = $controller('ConfirmModalController', {"$scope": $scope, "$uibModalInstance": $uibModalInstance, "data": data});
3939
}));
4040

4141
it("should copy the data, not use it as a reference", function() {
@@ -45,12 +45,12 @@ describe('angular-confirm', function() {
4545

4646
it("should call close when $scope.ok is invoked", function() {
4747
$scope.ok();
48-
expect($modalInstance.close).toHaveBeenCalled();
48+
expect($uibModalInstance.close).toHaveBeenCalled();
4949
});
5050

5151
it("should call dismiss when $scope.cancel is invoked", function() {
5252
$scope.cancel();
53-
expect($modalInstance.dismiss).toHaveBeenCalledWith('cancel');
53+
expect($uibModalInstance.dismiss).toHaveBeenCalledWith('cancel');
5454
});
5555

5656
});
@@ -63,12 +63,12 @@ describe('angular-confirm', function() {
6363
$confirm = _$confirm_;
6464
$confirm.and.callThrough();
6565
$confirmModalDefaults = _$confirmModalDefaults_;
66-
$modal.open.and.callThrough();
66+
$uibModal.open.and.callThrough();
6767
}));
6868

69-
it("should call $modal.open", function() {
69+
it("should call $uibModal.open", function() {
7070
$confirm();
71-
expect($modal.open).toHaveBeenCalled();
71+
expect($uibModal.open).toHaveBeenCalled();
7272
});
7373

7474
it("should override the defaults with settings passed in", function() {

0 commit comments

Comments
 (0)