flake8 -> ruff, ci updates

Author: jamesob

.github/workflows/run-tests.yml

@@ -9,14 +9,14 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [3.9.12, 3.10.6, 3.11.0, 3.12.0, 3.13.0]
-        os: [ubuntu-18.04, macOS-latest]
+        python-version: [3.11.0, 3.12.0, 3.13.0]
+        os: [ubuntu-24.04, macos-latest]
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
 
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
 
@@ -30,11 +30,10 @@ jobs:
     - name: yapf
       run: yapf --diff coldcore
 
-    - name: flake8
+    - name: ruff
       run: |
-        flake8 coldcore --count --show-source --statistics
-        # When linting the tests, ignore long line errors
-        flake8 test/ --count --show-source --statistics --extend-ignore E501
+        ruff check coldcore
+        ruff check test
 
     - name: pytest
       run: |

Makefile

@@ -9,7 +9,7 @@ test: docker-build
 		-v $$(pwd):/src:ro coldcore/test pytest -vv --color=yes test/
 
 lint: docker-build
-	docker run --rm -v $$(pwd):/src:ro coldcore/test flake8 coldcore
+	docker run --rm -v $$(pwd):/src:ro coldcore/test ruff coldcore
 	docker run --rm -v $$(pwd):/src:ro coldcore/test yapf --diff coldcore
 	docker run --rm -v $$(pwd):/src:ro coldcore/test mypy coldcore
 

coldcore

@@ -155,7 +155,7 @@ class Arg:
             if kwargs.get("type") == inspect.Parameter.empty:
                 kwargs.pop("type")
 
-        if self.type == bool or any(self.default is i for i in [True, False]):
+        if self.type is bool or any(self.default is i for i in [True, False]):
             kwargs["action"] = "store_false" if self.default else "store_true"
             kwargs.pop("type", "")
 

requirements-dev.txt

@@ -1,4 +1,4 @@
 mypy==0.942
 pytest==7.1.1
-flake8==4.0.1
+ruff==0.9.4
 yapf==0.43.0