Skip to content

Commit 663cf1f

Browse files
committed
Merge pull request #10 from jamesryanbell/phantomjs2
Added support for PhantomJS 2. Phantom JS is now installed via NPM so no external dependencies are required.
2 parents 69d9900 + ae88b27 commit 663cf1f

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

lib/wraith.js

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
'use strict';
22

3-
var fs = require('fs');
4-
var async = require('async');
5-
var mkdirp = require('mkdirp');
6-
var path = require('path');
7-
var resemble = require('node-resemble-js');
8-
var progress = require('progress');
9-
var gallery = require('./gallery');
10-
var helpers = require('./helpers');
11-
var log = require('./logger');
3+
var fs = require('fs');
4+
var async = require('async');
5+
var mkdirp = require('mkdirp');
6+
var path = require('path');
7+
var resemble = require('node-resemble-js');
8+
var progress = require('progress');
9+
var gallery = require('./gallery');
10+
var helpers = require('./helpers');
11+
var log = require('./logger');
12+
var phantomjs = require('phantomjs2');
1213

1314
function Wraith(config, cb) {
1415
var self = this;
@@ -185,7 +186,7 @@ Wraith.prototype.takeScreenshots = function () {
185186
height: 'all'
186187
},
187188
defaultWhiteBackground: true,
188-
phantomPath: task.engine,
189+
phantomPath: self.getEnginePath[task.engine],
189190
phantomConfig: {
190191
'debug': 'false',
191192
'load-images': 'true'
@@ -216,6 +217,14 @@ Wraith.prototype.takeScreenshots = function () {
216217
});
217218
};
218219

220+
Wraith.prototype.getEnginePath = function(engine) {
221+
if(engine == 'phantomjs') {
222+
return phantomjs.path;
223+
} else {
224+
return engine;
225+
}
226+
};
227+
219228
Wraith.prototype.compareScreenshots = function() {
220229
var self = this;
221230
var fileLabels = [];

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
"moment": "^2.8.4",
5555
"mustache": "~0.8.1",
5656
"node-resemble-js": "0.0.4",
57+
"phantomjs2": "^2.2.0",
5758
"progress": "^1.1.8",
5859
"rimraf": "~2.2.6",
5960
"w3counter": "^1.0.3",

0 commit comments

Comments
 (0)