fix: inject version into SEA bundle and remove incompatible Node v23 flag

- Modified pullcraft.ts to use VERSION_PLACEHOLDER that gets replaced at bundle time
- Updated build.bundle.js to read version from package.json and inject via esbuild define
- Removed --experimental-default-type=module flag from build.sea.js (incompatible with Node v23)
- Version now works correctly for both npm installs and SEA bundles

Author: jamesvillarrubia

build/scripts/build.bundle.js

@@ -6,7 +6,7 @@ const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 
 async function createBundle (options) {
-  const { entryPoint, outfile } = options;
+  const { entryPoint, outfile, version } = options;
 
   console.log('Starting bundle creation process...');
 
@@ -17,9 +17,15 @@ async function createBundle (options) {
       platform: 'node',
       target: 'node18',
       outfile,
-      format: 'cjs'
+      format: 'cjs',
+      define: version ? {
+        '__VERSION_PLACEHOLDER__': `"${version}"`
+      } : {}
     });
     console.log(`Bundle created successfully at ${outfile}`);
+    if (version) {
+      console.log(`Version ${version} injected into bundle`);
+    }
   } catch (error) {
     console.error('Bundling failed:', error);
     process.exit(1);
@@ -52,9 +58,21 @@ function validateArgs (options) {
 const cliOptions = parseArgs();
 validateArgs(cliOptions);
 
+// Read version from package.json to inject into bundle
+let version;
+try {
+  const packageJsonPath = path.join(__dirname, '../..', 'package.json');
+  const { readFileSync } = await import('fs');
+  const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf8'));
+  version = packageJson.version;
+} catch (error) {
+  console.warn('Could not read version from package.json:', error.message);
+}
+
 const bundleOptions = {
   entryPoint: cliOptions.entryPoint,
-  outfile: cliOptions.outfile || path.join(__dirname, '..', 'bundle.js')
+  outfile: cliOptions.outfile || path.join(__dirname, '..', 'bundle.js'),
+  version
 };
 
 createBundle(bundleOptions).catch(console.error);

build/scripts/build.sea.js

@@ -60,7 +60,7 @@ async function createSEA (options) {
   console.log('Permissions set');
 
   // Step 3: Generate the blob
-  const generateBlobCommand = `node --experimental-sea-config ${seaConfigPath} --experimental-default-type=module`;
+  const generateBlobCommand = `node --experimental-sea-config ${seaConfigPath}`;
   console.log(`Generating blob: ${generateBlobCommand}`);
   execSync(generateBlobCommand, { stdio: 'inherit' });
 

src/bin/pullcraft.ts

@@ -8,14 +8,24 @@ import { fileURLToPath } from 'url';
 import { dirname, join } from 'path';
 
 // Read version from package.json
-// This bin file is only used from the ESM build (see package.json "bin" field)
-// When compiled, this file is at dist/esm/bin/pullcraft.js
-// package.json is at the root, so we go up 3 levels
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = dirname(__filename);
-const packageJsonPath = join(__dirname, '../../../package.json');
-const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf8'));
-const VERSION = packageJson.version;
+// For npm installs: read from package.json at runtime
+// For SEA bundles: VERSION_PLACEHOLDER is replaced at build time by esbuild
+let VERSION = '__VERSION_PLACEHOLDER__';
+
+// If running from npm install (not bundled), read version from package.json
+if (VERSION === '__VERSION_PLACEHOLDER__') {
+  try {
+    if (import.meta.url) {
+      const __filename = fileURLToPath(import.meta.url);
+      const __dirname = dirname(__filename);
+      const packageJsonPath = join(__dirname, '../../../package.json');
+      const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf8'));
+      VERSION = packageJson.version;
+    }
+  } catch (error) {
+    VERSION = '0.0.0-dev';
+  }
+}
 
 // Load environment variables from a .env file if it exists
 dotenv.config();