General clean up. Ensure my current email address is used. General documentation clean up. Added package-info.java files.

Signed-off-by: James R. Perkins <jperkins@ibm.com>

Author: jamezp

CODE_OF_CONDUCT.md

@@ -60,7 +60,7 @@ representative at an online or offline event.
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
 reported to the community leaders responsible for enforcement at
-James Perkins <jpekrins@ibm.com>.
+James Perkins <jperkins@ibm.com>.
 All complaints will be reviewed and investigated promptly and fairly.
 
 All community leaders are obligated to respect the privacy and security of the

CONTRIBUTING.adoc

@@ -2,13 +2,13 @@
 
 = Contributing Guide
 
-Want to contribute to the WildFly Plugin Tools? We try to make it easy, and all contributions, even the smaller ones,
+Want to contribute to the WildFly Testing Tools? We try to make it easy, and all contributions, even the smaller ones,
 are more than welcome. This includes bug reports, fixes, documentation, etc. First though, please read this page
 (including the small print at the end).
 
 == Legal
 
-All original contributions to the WildFly Plugin Tools are licensed under the
+All original contributions to the WildFly Testing Tools are licensed under the
 https://www.apache.org/licenses/LICENSE-2.0[ASL - Apache License], version 2.0 or later, or, if another license is
 specified as governing the file or directory being modified, such other license.
 
@@ -17,12 +17,10 @@ The DCO text is also included verbatim in the [dco.txt](dco.txt) file in the roo
 
 == Reporting an issue
 
-This project uses https://issues.redhat.com/browse/WFMP[JIRA] for filing issues. An account is required, However,
-if you do not wish to signup for an account, you can open a
-https://github.com/wildfly/wildfly-plugin-tools/discussions[discussion] and we will assist you in filing an issue.
+This project uses https://github.com/wildfly-extras/wildfly-testing-tools/issues[GitHub Issues] for tracking bugs and
+feature requests.
 
-If you believe you found a bug, and it's likely possible, please indicate a way to reproduce it, what you are seeing and
-what you would expect to see.
+If you believe you found a bug, please indicate a way to reproduce it, what you are seeing and what you would expect to see.
 
 == Before you contribute
 
@@ -44,27 +42,28 @@ We use this information to acknowledge your contributions in release announcemen
 If you have not done so on this machine, you need to:
 
 * Install Git and configure your GitHub access
-* Install Java SDK 11+ (OpenJDK recommended)
+* Install Java SDK 17+ (OpenJDK recommended)
 
 === IDE Config and Code Style
 
-The WildFly Plugin Tools has a strictly enforced code style. Code formatting is done by the Eclipse code formatter,
-using the config files found in the
-https://github.com/wildfly/wildfly-dev-tools/tree/main/ide-config/src/main/resources[eclipse-code-formatter.xml]
-file. By default, when you run `./mvnw install`, the code will be formatted automatically. When submitting a pull
-request the CI build will fail if running the formatter results in any code changes, so it is recommended that you
-always run a full Maven build before submitting a pull request.
+The WildFly Testing Tools has a strictly enforced code style. Code formatting is done by the Eclipse code formatter,
+using the config files provided by the `org.wildfly.tools:ide-config` dependency. By default, when you run
+`./mvnw install`, the code will be formatted automatically. When submitting a pull request the CI build will fail if
+running the formatter results in any code changes, so it is recommended that you always run a full Maven build before
+submitting a pull request.
 
 If you want to run the formatting without doing a full build, you can run `mvn process-sources`.
 
 ==== Eclipse Setup
 
 Open the *Preferences* window, and then navigate to _Java_ -> _Code Style_ -> _Formatter_. Click _Import_ and then
-select the `eclipse-code-formatter.xml` downloaded from the above link or clone the repository and navigate to the file.
+select the `eclipse-code-formatter.xml` file from the https://github.com/wildfly/wildfly-dev-tools/tree/main/ide-config[wildfly-dev-tools ide-config] resources.
 
-Next navigate to _Java_ -> _Code Style_ -> _Organize Imports_. Click _Import_ and select the `eclipse.importorder` file.
+Next navigate to _Java_ -> _Code Style_ -> _Organize Imports_. Click _Import_ and select the `eclipse.importorder` file
+from the same location.
 
 ==== IDEA Setup
 
 Install the https://plugins.jetbrains.com/plugin/6546-adapter-for-eclipse-code-formatter/[Adapter for Eclipse Code Formatter].
-See the https://github.com/krasa/EclipseCodeFormatter#instructions[documentation] on how to configure the plugin.
+See the https://github.com/krasa/EclipseCodeFormatter#instructions[documentation] on how to configure the plugin with
+the `eclipse-code-formatter.xml` file from https://github.com/wildfly/wildfly-dev-tools/tree/main/ide-config[wildfly-dev-tools ide-config].

README.adoc

@@ -30,7 +30,7 @@ To use the tooling you can simply import the Bill of Materials POM:
 === JUnit API
 
 The JUnit API contains annotations for skipping tests if minimal module requirements are not met. It also supports
-injecting the value of the JBoss Home directory. This can be used with JUnit 5+ and the WildFly JUnit Extension
+injecting the value of the JBoss Home directory. This can be used with JUnit 6+ and the WildFly JUnit Extension
 or WildFly Arquillian.
 
 [source,xml]

api/src/main/java/org/wildfly/testing/junit/annotation/package-info.java

@@ -0,0 +1,50 @@
+/*
+ * Copyright The WildFly Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+/**
+ * Annotations for conditional test execution and resource injection in WildFly-based tests.
+ * <p>
+ * This package provides JUnit annotations that can be used with any testing framework to conditionally
+ * execute tests based on WildFly server configuration and inject server-related information.
+ * </p>
+ *
+ * <h2>Key Annotations</h2>
+ * <ul>
+ * <li>{@link org.wildfly.testing.junit.annotation.RequiresModule @RequiresModule} - Skip tests when specific
+ * WildFly modules are not available</li>
+ * <li>{@link org.wildfly.testing.junit.annotation.AnyOf @AnyOf} - Run tests if any of multiple module
+ * requirements are met</li>
+ * <li>{@link org.wildfly.testing.junit.annotation.JBossHome @JBossHome} - Inject the WildFly installation
+ * directory path</li>
+ * </ul>
+ *
+ * <h2>Usage with WildFly JUnit Extension</h2>
+ * <p>
+ * These annotations work seamlessly with the {@code wildfly-junit-extension} module for full server lifecycle
+ * management:
+ * </p>
+ *
+ * <pre>{@code
+ * @WildFlyTest
+ * @RequiresModule("org.jboss.as.ejb3")
+ * public class EjbTest {
+ *     // Test only runs if EJB module is available
+ * }
+ * }</pre>
+ *
+ * <h2>Usage with Other Frameworks</h2>
+ * <p>
+ * These annotations can also be used independently with Arquillian or other testing frameworks that
+ * manage the WildFly server lifecycle. Simply add the {@code wildfly-junit-api} dependency and the
+ * annotations will work as JUnit extensions.
+ * </p>
+ *
+ * @author <a href="mailto:jperkins@ibm.com">James R. Perkins</a>
+ *
+ * @see org.wildfly.testing.junit.annotation.RequiresModule
+ * @see org.wildfly.testing.junit.annotation.AnyOf
+ * @see org.wildfly.testing.junit.annotation.JBossHome
+ */
+package org.wildfly.testing.junit.annotation;

api/src/main/java/org/wildfly/testing/junit/condition/JBossHomeParameterResolver.java

@@ -37,7 +37,6 @@ public boolean supportsParameter(final ParameterContext parameterContext, final
     @Override
     public Object resolveParameter(final ParameterContext parameterContext, final ExtensionContext extensionContext)
             throws ParameterResolutionException {
-        // TODO (jrp) look at how we did this before
         final Optional<Path> value = Support.resolveJBossHome(extensionContext);
         if (value.isEmpty()) {
             throw new ParameterResolutionException(

api/src/main/java/org/wildfly/testing/junit/condition/RequiresModuleExecutionCondition.java

@@ -26,6 +26,7 @@
 import org.junit.jupiter.api.extension.ConditionEvaluationResult;
 import org.junit.jupiter.api.extension.ExecutionCondition;
 import org.junit.jupiter.api.extension.ExtensionContext;
+import org.junit.platform.commons.JUnitException;
 import org.junit.platform.commons.support.AnnotationSupport;
 import org.wildfly.plugin.tools.VersionComparator;
 import org.wildfly.testing.junit.annotation.AnyOf;
@@ -149,7 +150,11 @@ private static ModuleDefinition parse(final Path moduleXmlFile) throws IOExcepti
             final DocumentBuilder builder = factory.newDocumentBuilder();
             final org.w3c.dom.Document document = builder.parse(in);
             final var moduleNode = document.getDocumentElement();
-            name = moduleNode.getAttributes().getNamedItem("name").getTextContent();
+            final var nameAttr = moduleNode.getAttributes().getNamedItem("name");
+            if (nameAttr == null) {
+                throw new JUnitException("Malformed module.xml: missing 'name' attribute in " + moduleXmlFile);
+            }
+            name = nameAttr.getTextContent();
             final var resources = document.getElementsByTagName("resources");
             if (resources.getLength() > 0) {
                 // Use only the first resources, which there should only be one of
@@ -159,14 +164,25 @@ private static ModuleDefinition parse(final Path moduleXmlFile) throws IOExcepti
                     final var node = nodes.item(i);
                     if (node.getNodeName().equals("artifact")) {
                         // Use the Maven GAV where the third entry should be the version
-                        final var artifactName = node.getAttributes().getNamedItem("name").getTextContent();
+                        final var artifactNameAttr = node.getAttributes().getNamedItem("name");
+                        if (artifactNameAttr == null) {
+                            throw new JUnitException(
+                                    "Malformed module.xml: 'artifact' element missing 'name' attribute in " + moduleXmlFile);
+                        }
+                        final var artifactName = artifactNameAttr.getTextContent();
                         final var gav = artifactName.split(":");
                         if (gav.length > 2) {
                             version = sanitizeVersion(gav[2]);
                         }
                         break;
                     } else if (node.getNodeName().equals("resource-root")) {
-                        final String path = node.getAttributes().getNamedItem("path").getTextContent();
+                        final var pathAttr = node.getAttributes().getNamedItem("path");
+                        if (pathAttr == null) {
+                            throw new JUnitException(
+                                    "Malformed module.xml: 'resource-root' element missing 'path' attribute in "
+                                            + moduleXmlFile);
+                        }
+                        final String path = pathAttr.getTextContent();
                         final Path parent = moduleXmlFile.getParent();
                         final Path jar = parent == null ? Path.of(path) : parent.resolve(path);
                         try (JarFile jarFile = new JarFile(jar.toFile())) {

api/src/main/java/org/wildfly/testing/junit/condition/Support.java

@@ -15,7 +15,7 @@
  *
  * @author <a href="mailto:jperkins@ibm.com">James R. Perkins</a>
  */
-public class Support {
+class Support {
 
     /**
      * Resolves the servers base directory. This first uses the

api/src/test/java/org/wildfly/testing/junit/JBossHomeParameterTestCase.java

@@ -15,7 +15,7 @@
 
 /**
  *
- * @author <a href="mailto:jpekrins@ibm.com">James R. Perkins</a>
+ * @author <a href="mailto:jperkins@ibm.com">James R. Perkins</a>
  */
 @Tag("env.var")
 @Tag("system.property")

api/src/test/java/org/wildfly/testing/junit/RequireArtifact.java

@@ -10,7 +10,7 @@
 import org.wildfly.testing.junit.annotation.RequiresModule;
 
 /**
- * @author <a href="mailto:jpekrins@ibm.com">James R. Perkins</a>
+ * @author <a href="mailto:jperkins@ibm.com">James R. Perkins</a>
  */
 @SuppressWarnings("NewClassNamingConvention")
 @RequiresModule("org.wildfly.testing.junit.test.artifact")

api/src/test/java/org/wildfly/testing/junit/RequireMultiModules.java

@@ -11,7 +11,7 @@
 import org.wildfly.testing.junit.annotation.RequiresModules;
 
 /**
- * @author <a href="mailto:jpekrins@ibm.com">James R. Perkins</a>
+ * @author <a href="mailto:jperkins@ibm.com">James R. Perkins</a>
  */
 @SuppressWarnings("NewClassNamingConvention")
 @RequiresModule("org.wildfly.testing.junit.test.resource-root")