Skip to content

Commit d22e068

Browse files
committed
Test pass
1 parent 123b8ce commit d22e068

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

dump.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -233,13 +233,13 @@ func (data *metaData) updateServerVersion(db *sql.DB) (err error) {
233233

234234
func (data *Data) createTable(name string) (*table, error) {
235235
var err error
236-
t := &table{Name: fmt.Sprintf("`%s`", name)}
236+
t := &table{Name: "`" + name + "`"}
237237

238-
if t.SQL, err = data.createTableSQL(t.Name); err != nil {
238+
if t.SQL, err = data.createTableSQL(name); err != nil {
239239
return nil, err
240240
}
241241

242-
if t.Values, err = data.createTableValues(t.Name); err != nil {
242+
if t.Values, err = data.createTableValues(name); err != nil {
243243
return nil, err
244244
}
245245

@@ -248,7 +248,7 @@ func (data *Data) createTable(name string) (*table, error) {
248248

249249
func (data *Data) createTableSQL(name string) (string, error) {
250250
var tableReturn, tableSQL sql.NullString
251-
err := data.Connection.QueryRow("SHOW CREATE TABLE "+name).Scan(&tableReturn, &tableSQL)
251+
err := data.Connection.QueryRow("SHOW CREATE TABLE `"+name+"`").Scan(&tableReturn, &tableSQL)
252252

253253
if err != nil {
254254
return "", err
@@ -261,7 +261,7 @@ func (data *Data) createTableSQL(name string) (string, error) {
261261
}
262262

263263
func (data *Data) createTableValues(name string) (string, error) {
264-
rows, err := data.Connection.Query("SELECT * FROM " + name)
264+
rows, err := data.Connection.Query("SELECT * FROM `" + name + "`")
265265
if err != nil {
266266
return "", err
267267
}

dump_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ func TestCreateTableSQLOk(t *testing.T) {
156156
rows := sqlmock.NewRows([]string{"Table", "Create Table"}).
157157
AddRow("Test_Table", "CREATE TABLE 'Test_Table' (`id` int(11) NOT NULL AUTO_INCREMENT,`s` char(60) DEFAULT NULL, PRIMARY KEY (`id`))ENGINE=InnoDB DEFAULT CHARSET=latin1")
158158

159-
mock.ExpectQuery("^SHOW CREATE TABLE Test_Table$").WillReturnRows(rows)
159+
mock.ExpectQuery("^SHOW CREATE TABLE `Test_Table`$").WillReturnRows(rows)
160160

161161
data := Data{
162162
Connection: db,
@@ -192,7 +192,7 @@ func TestCreateTableValuesOk(t *testing.T) {
192192
AddRow(1, "[email protected]", "Test Name 1").
193193
AddRow(2, "[email protected]", "Test Name 2")
194194

195-
mock.ExpectQuery("^SELECT (.+) FROM test$").WillReturnRows(rows)
195+
mock.ExpectQuery("^SELECT (.+) FROM `test`$").WillReturnRows(rows)
196196

197197
data := Data{
198198
Connection: db,
@@ -228,7 +228,7 @@ func TestCreateTableValuesNil(t *testing.T) {
228228
AddRow(2, "[email protected]", "Test Name 2").
229229
AddRow(3, "", "Test Name 3")
230230

231-
mock.ExpectQuery("^SELECT (.+) FROM test$").WillReturnRows(rows)
231+
mock.ExpectQuery("^SELECT (.+) FROM `test`$").WillReturnRows(rows)
232232

233233
data := Data{
234234
Connection: db,
@@ -266,8 +266,8 @@ func TestCreateTableOk(t *testing.T) {
266266
AddRow(1, nil, "Test Name 1").
267267
AddRow(2, "[email protected]", "Test Name 2")
268268

269-
mock.ExpectQuery("^SHOW CREATE TABLE Test_Table$").WillReturnRows(createTableRows)
270-
mock.ExpectQuery("^SELECT (.+) FROM Test_Table$").WillReturnRows(createTableValueRows)
269+
mock.ExpectQuery("^SHOW CREATE TABLE `Test_Table`$").WillReturnRows(createTableRows)
270+
mock.ExpectQuery("^SELECT (.+) FROM `Test_Table`$").WillReturnRows(createTableValueRows)
271271

272272
data := Data{
273273
Connection: db,

mysqldump_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ func TestDumpOk(t *testing.T) {
3737

3838
mock.ExpectQuery("^SELECT version()").WillReturnRows(serverVersionRows)
3939
mock.ExpectQuery("^SHOW TABLES$").WillReturnRows(showTablesRows)
40-
mock.ExpectQuery("^SHOW CREATE TABLE Test_Table$").WillReturnRows(createTableRows)
41-
mock.ExpectQuery("^SELECT (.+) FROM Test_Table$").WillReturnRows(createTableValueRows)
40+
mock.ExpectQuery("^SHOW CREATE TABLE `Test_Table`$").WillReturnRows(createTableRows)
41+
mock.ExpectQuery("^SELECT (.+) FROM `Test_Table`$").WillReturnRows(createTableValueRows)
4242

4343
buf := new(bytes.Buffer)
4444
err = Dump(db, buf)

0 commit comments

Comments
 (0)