With data streams

Author: BrandonRoehl

dump.go

@@ -47,6 +47,7 @@ type metaData struct {
 
 const version = "0.3.5"
 
+// takes a *metaData
 const headerTmpl = `-- Go SQL Dump {{ .DumpVersion }}
 --
 -- ------------------------------------------------------
@@ -64,6 +65,21 @@ const headerTmpl = `-- Go SQL Dump {{ .DumpVersion }}
 /*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */;
 `
 
+// takes a *metaData
+const footerTmpl = `/*!40103 SET TIME_ZONE=@OLD_TIME_ZONE */;
+
+/*!40101 SET SQL_MODE=@OLD_SQL_MODE */;
+/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */;
+/*!40014 SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS */;
+/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;
+/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;
+/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;
+/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;
+
+-- Dump completed on {{ .CompleteTime }}
+`
+
+// Takes a *table
 const tableTmpl = `
 --
 -- Table structure for table {{ .NameEsc }}
@@ -89,19 +105,6 @@ INSERT INTO {{ .NameEsc }} VALUES {{ .RowValues }}
 UNLOCK TABLES;
 `
 
-const footerTmpl = `/*!40103 SET TIME_ZONE=@OLD_TIME_ZONE */;
-
-/*!40101 SET SQL_MODE=@OLD_SQL_MODE */;
-/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */;
-/*!40014 SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS */;
-/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;
-/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;
-/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;
-/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;
-
--- Dump completed on {{ .CompleteTime }}
-`
-
 const nullType = "NULL"
 
 // Dump data using struct

mysqldump_test.go

@@ -2,47 +2,14 @@ package mysqldump
 
 import (
 	"bytes"
-	"os"
 	"strings"
 	"testing"
 
 	sqlmock "github.com/DATA-DOG/go-sqlmock"
 	"github.com/stretchr/testify/assert"
 )
 
-func TestDumpOk(t *testing.T) {
-
-	tmpFile := "/tmp/test_format.sql"
-	os.Remove(tmpFile)
-
-	db, mock, err := sqlmock.New()
-	assert.NoError(t, err, "an error was not expected when opening a stub database connection")
-	defer db.Close()
-
-	showTablesRows := sqlmock.NewRows([]string{"Tables_in_Testdb"}).
-		AddRow("Test_Table")
-
-	serverVersionRows := sqlmock.NewRows([]string{"Version()"}).
-		AddRow("test_version")
-
-	createTableRows := sqlmock.NewRows([]string{"Table", "Create Table"}).
-		AddRow("Test_Table", "CREATE TABLE 'Test_Table' (`id` int(11) NOT NULL AUTO_INCREMENT,`email` char(60) DEFAULT NULL, `name` char(60), PRIMARY KEY (`id`))ENGINE=InnoDB DEFAULT CHARSET=latin1")
-
-	createTableValueRows := sqlmock.NewRows([]string{"id", "email", "name"}).
-		AddRow(1, nil, "Test Name 1").
-		AddRow(2, "[email protected]", "Test Name 2")
-
-	mock.ExpectQuery("^SELECT version()").WillReturnRows(serverVersionRows)
-	mock.ExpectQuery("^SHOW TABLES$").WillReturnRows(showTablesRows)
-	mock.ExpectQuery("^SHOW CREATE TABLE `Test_Table`$").WillReturnRows(createTableRows)
-	mock.ExpectQuery("^SELECT (.+) FROM `Test_Table`$").WillReturnRows(createTableValueRows)
-
-	buf := new(bytes.Buffer)
-	assert.NoError(t, Dump(db, buf), "an error was not expected when dumping a stub database connection")
-
-	result := strings.Replace(strings.Split(buf.String(), "-- Dump completed")[0], "`", "~", -1)
-
-	expected := `-- Go SQL Dump ` + version + `
+const expected = `-- Go SQL Dump ` + version + `
 --
 -- ------------------------------------------------------
 -- Server version	test_version
@@ -88,5 +55,46 @@ UNLOCK TABLES;
 /*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;
 
 `
+
+func RunDump(t testing.TB) string {
+	db, mock, err := sqlmock.New()
+	assert.NoError(t, err, "an error was not expected when opening a stub database connection")
+	defer db.Close()
+
+	showTablesRows := sqlmock.NewRows([]string{"Tables_in_Testdb"}).
+		AddRow("Test_Table")
+
+	serverVersionRows := sqlmock.NewRows([]string{"Version()"}).
+		AddRow("test_version")
+
+	createTableRows := sqlmock.NewRows([]string{"Table", "Create Table"}).
+		AddRow("Test_Table", "CREATE TABLE 'Test_Table' (`id` int(11) NOT NULL AUTO_INCREMENT,`email` char(60) DEFAULT NULL, `name` char(60), PRIMARY KEY (`id`))ENGINE=InnoDB DEFAULT CHARSET=latin1")
+
+	createTableValueRows := sqlmock.NewRows([]string{"id", "email", "name"}).
+		AddRow(1, nil, "Test Name 1").
+		AddRow(2, "[email protected]", "Test Name 2")
+
+	mock.ExpectQuery("^SELECT version()").WillReturnRows(serverVersionRows)
+	mock.ExpectQuery("^SHOW TABLES$").WillReturnRows(showTablesRows)
+	mock.ExpectQuery("^SHOW CREATE TABLE `Test_Table`$").WillReturnRows(createTableRows)
+	mock.ExpectQuery("^SELECT (.+) FROM `Test_Table`$").WillReturnRows(createTableValueRows)
+
+	var buf bytes.Buffer
+	assert.NoError(t, Dump(db, &buf), "an error was not expected when dumping a stub database connection")
+
+	return buf.String()
+}
+
+func TestDumpOk(t *testing.T) {
+	out := RunDump(t)
+
+	result := strings.Replace(strings.Split(out, "-- Dump completed")[0], "`", "~", -1)
+
 	assert.Equal(t, expected, result)
 }
+
+func BenchmarkDump(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		_ = RunDump(b)
+	}
+}