Skip to content

Commit fd3ebcf

Browse files
committed
Ability to ignore tables
1 parent c9037df commit fd3ebcf

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

dump.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -275,16 +275,14 @@ func (data *Data) createTableValues(name string) (string, error) {
275275
st := tp.ScanType()
276276
if tp.DatabaseTypeName() == "BLOB" {
277277
types[i] = reflect.TypeOf(sql.RawBytes{})
278-
} else if st == nil || st.Kind() == reflect.Slice {
279-
types[i] = reflect.TypeOf(sql.NullString{})
280-
} else if st.Kind() == reflect.Int ||
278+
} else if st != nil && (st.Kind() == reflect.Int ||
281279
st.Kind() == reflect.Int8 ||
282280
st.Kind() == reflect.Int16 ||
283281
st.Kind() == reflect.Int32 ||
284-
st.Kind() == reflect.Int64 {
282+
st.Kind() == reflect.Int64) {
285283
types[i] = reflect.TypeOf(sql.NullInt64{})
286284
} else {
287-
types[i] = st
285+
types[i] = reflect.TypeOf(sql.NullString{})
288286
}
289287
}
290288
values := make([]interface{}, len(tt))

dump_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ func TestCreateTableValuesNil(t *testing.T) {
244244
t.Errorf("there were unfulfilled expections: %s", err)
245245
}
246246

247-
expectedResult := "('1',null,'Test Name 1'),('2','[email protected]','Test Name 2'),('3','','Test Name 3')"
247+
expectedResult := "('1',NULL,'Test Name 1'),('2','[email protected]','Test Name 2'),('3','','Test Name 3')"
248248

249249
if !reflect.DeepEqual(result, expectedResult) {
250250
t.Fatalf("expected %#v, got %#v", expectedResult, result)
@@ -284,9 +284,9 @@ func TestCreateTableOk(t *testing.T) {
284284
}
285285

286286
expectedResult := &table{
287-
Name: "Test_Table",
287+
Name: "`Test_Table`",
288288
SQL: "CREATE TABLE 'Test_Table' (`id` int(11) NOT NULL AUTO_INCREMENT,`s` char(60) DEFAULT NULL, PRIMARY KEY (`id`))ENGINE=InnoDB DEFAULT CHARSET=latin1",
289-
Values: "('1',null,'Test Name 1'),('2','[email protected]','Test Name 2')",
289+
Values: "('1',NULL,'Test Name 1'),('2','[email protected]','Test Name 2')",
290290
}
291291

292292
if !reflect.DeepEqual(result, expectedResult) {

mysqldump_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ CREATE TABLE 'Test_Table' (\id\ int(11) NOT NULL AUTO_INCREMENT,\email\ char(60)
8080
8181
LOCK TABLES \Test_Table\ WRITE;
8282
/*!40000 ALTER TABLE \Test_Table\ DISABLE KEYS */;
83-
INSERT INTO \Test_Table\ VALUES (1,null,'Test Name 1'),(2,'[email protected]','Test Name 2');
83+
INSERT INTO \Test_Table\ VALUES ('1',NULL,'Test Name 1'),('2','[email protected]','Test Name 2');
8484
/*!40000 ALTER TABLE \Test_Table\ ENABLE KEYS */;
8585
UNLOCK TABLES;
8686
/*!40103 SET TIME_ZONE=@OLD_TIME_ZONE */;

0 commit comments

Comments
 (0)