chore: update @svelte/tsconfig

The default config has stricter checks for the type system. So we need to make changes across the codebase to fix these issues.

Author: jamiebrynes7

package.json

@@ -13,10 +13,10 @@
   "author": "Jamie Brynes",
   "license": "ISC",
   "dependencies": {
-    "camelize": "^1.0.1",
+    "camelize-ts": "^3.0.0",
     "moment": "^2.29.4",
     "obsidian": "0.15",
-    "snakeize": "^0.1.0",
+    "snakify-ts": "^2.3.0",
     "svelte": "^4.2.10",
     "svelte-select": "^5.0.1",
     "tslib": "^2.4.1",
@@ -26,7 +26,7 @@
     "@rollup/plugin-commonjs": "^24.0.0",
     "@rollup/plugin-node-resolve": "^15.0.1",
     "@rollup/plugin-typescript": "^10.0.1",
-    "@tsconfig/svelte": "^3.0.0",
+    "@tsconfig/svelte": "^5.0.0",
     "@types/chai": "^4.3.4",
     "@types/mocha": "^10.0.1",
     "@types/node": "^18.11.17",

src/api/fetcher.ts

@@ -5,7 +5,7 @@ export interface WebFetcher {
 export type RequestParams = {
   url: string,
   method: string,
-  headers?: Record<string, string>,
+  headers: Record<string, string>,
   body?: string,
 };
 

src/api/index.ts

@@ -4,8 +4,8 @@ import type { Project } from "./domain/project";
 import type { Section } from "./domain/section";
 import type { CreateTaskParams, Task, TaskId } from "./domain/task";
 import type { RequestParams, WebFetcher, WebResponse } from "./fetcher";
-import camelize from "camelize";
-import snakeize from "snakeize";
+import camelize from "camelize-ts";
+import snakify from "snakify-ts";
 
 export class TodoistApiClient {
   private token: string;
@@ -29,7 +29,7 @@ export class TodoistApiClient {
   }
 
   public async createTask(content: string, options?: CreateTaskParams): Promise<void> {
-    const body = snakeize({ content: content, ...(options ?? {}) });
+    const body = snakify({ content: content, ...(options ?? {}) });
     await this.do("/tasks", "POST", body);
   }
 

src/components/MarkdownRenderer.svelte

@@ -1,6 +1,7 @@
 <script lang="ts">
   import { MarkdownRenderer } from "obsidian";
   import { onMount } from "svelte";
+    import { getComponent } from "../ui/contexts";
 
   export let content: string;
 
@@ -9,17 +10,19 @@
 
   let containerEl: HTMLDivElement;
 
+  const component = getComponent();
+
   onMount(async () => {
-    await MarkdownRenderer.renderMarkdown(content, containerEl, "", null);
+    await MarkdownRenderer.renderMarkdown(content, containerEl, "", component);
 
     if (containerEl.childElementCount > 1) {
       return;
     }
 
     const markdownContent = containerEl.querySelector("p");
 
-    if (markdownContent) {
-      markdownContent.parentElement.removeChild(markdownContent);
+    if (markdownContent !== null) {
+      markdownContent.parentElement?.removeChild(markdownContent);
       containerEl.innerHTML = markdownContent.innerHTML;
     }
   });

src/contextMenu.ts

@@ -33,7 +33,7 @@ export function showTaskContext(
         .setIcon("popup-open")
         .onClick(() =>
           openExternal(
-            `https://todoist.com/app/project/${taskCtx.task.project.id}/task/${taskCtx.task.id}`
+            `https://todoist.com/app/project/${taskCtx.task.project?.id}/task/${taskCtx.task.id}`
           )
         )
     )

src/data/index.ts

@@ -129,7 +129,7 @@ export class TodoistAdapter {
 
       project: project,
       section: section,
-      parentId: apiTask.parentId,
+      parentId: apiTask.parentId ?? undefined,
 
       labels: apiTask.labels,
       priority: apiTask.priority,

src/data/transformations.test.ts

@@ -8,7 +8,7 @@ import { SortingVariant } from "../query/query";
 function makeTask(id: string, opts?: Partial<Task>): Task {
   return {
     id,
-    createdAt: opts?.createdAt,
+    createdAt: opts?.createdAt ?? "1970-01-01",
     parentId: opts?.parentId,
     content: "",
     description: "",

src/data/transformations.ts

@@ -28,7 +28,7 @@ export function groupByProject(tasks: Task[]): GroupedTasks[] {
         }
 
         const tasks = projects.get(project);
-        tasks.push(task);
+        tasks!.push(task);
     }
 
     return Array.from(projects.entries()).map(([project, tasks]) => { return { project: project, tasks: tasks }; })
@@ -91,8 +91,8 @@ function compareTaskDate<T extends Task>(self: T, other: T): number {
         return 0;
     }
 
-    const selfDate = selfInfo.m;
-    const otherDate = otherInfo.m;
+    const selfDate = selfInfo.m!;
+    const otherDate = otherInfo.m!;
 
     // Then lets check if we are the same day, if not
     // sort just based on the day.
@@ -140,9 +140,11 @@ export function buildTaskTree(tasks: Task[]): TaskTree[] {
         }
 
         const parent = mapping.get(task.parentId);
-        const child = mapping.get(task.id);
-        parent.children.push(child)
+        if (parent !== undefined) {
+            const child = mapping.get(task.id);
+            parent.children.push(child!)
+        }
     }
 
-    return roots.map(id => mapping.get(id));
+    return roots.map(id => mapping.get(id)!);
 }

src/index.ts

@@ -1,7 +1,7 @@
 import { settings, SettingsTab } from "./settings";
 import type { ISettings } from "./settings";
 import debug from "./log";
-import { App, Plugin, requestUrl } from "obsidian";
+import { App, Notice, Plugin, requestUrl } from "obsidian";
 import type { PluginManifest } from "obsidian";
 import TodoistApiTokenModal from "./modals/enterToken/enterTokenModal";
 import CreateTaskModal from "./modals/createTask/createTaskModal";
@@ -48,6 +48,11 @@ export default class TodoistPlugin extends Plugin {
             id: "todoist-add-task",
             name: "Add Todoist task",
             callback: () => {
+                if (this.options === null) {
+                    new Notice("Failed to load settings, cannot open task creation modal.");
+                    return;
+                }
+
                 new CreateTaskModal(
                     this.app,
                     this.todoistAdapter,
@@ -61,6 +66,11 @@ export default class TodoistPlugin extends Plugin {
             id: "todoist-add-task-current-page",
             name: "Add Todoist task with the current page",
             callback: () => {
+                if (this.options === null) {
+                    new Notice("Failed to load settings, cannot open task creation modal.");
+                    return;
+                }
+
                 new CreateTaskModal(
                     this.app,
                     this.todoistAdapter,

src/log.ts

@@ -5,7 +5,7 @@ let _settings: ISettings | undefined = undefined;
 settings.subscribe((update) => _settings = update);
 
 export default function debug(log: string | LogMessage) {
-  if (!_settings.debugLogging) {
+  if (!_settings?.debugLogging ?? false) {
     return;
   }