jmvbar: fix missing error bars bug

Previously, no error bars were shown when the continuous
variable was named "y". This commit fixes that.

Author: raviselker

R/jmvbar.b.R

@@ -97,10 +97,11 @@ jmvbarClass <- if (requireNamespace("jmvcore", quietly = TRUE)) {
                 if (is.null(group1)) {
                     df <- self$data |>
                         dplyr::mutate("{var}" := jmvcore::toNumeric(!!sym(var))) |>
+                        dplyr::rename(y_full = !!sym(var)) |>
                         dplyr::summarize(
-                            y = mean(!!sym(var), na.rm = TRUE),
+                            y = mean(y_full, na.rm = TRUE),
                             n = dplyr::n(),
-                            sd = sd(!!sym(var), na.rm = TRUE),
+                            sd = sd(y_full, na.rm = TRUE),
                         ) |>
                         dplyr::mutate(se = sd / sqrt(n)) |>
                         dplyr::mutate(ci = se * qt((self$options$ciWidth / 100) / 2 + .5, n - 1)) |>
@@ -109,28 +110,32 @@ jmvbarClass <- if (requireNamespace("jmvcore", quietly = TRUE)) {
                     df <- self$data |>
                         dplyr::mutate("{var}" := jmvcore::toNumeric(!!sym(var))) |>
                         dplyr::group_by(!!sym(group1)) |>
+                        dplyr::rename(y_full = !!sym(var), x = !!sym(group1)) |>
                         dplyr::summarize(
-                            y = mean(!!sym(var), na.rm = TRUE),
+                            y = mean(y_full, na.rm = TRUE),
                             n = dplyr::n(),
-                            sd = sd(!!sym(var), na.rm = TRUE),
+                            sd = sd(y_full, na.rm = TRUE),
                         ) |>
                         dplyr::mutate(se = sd / sqrt(n)) |>
                         dplyr::mutate(ci = se * qt((self$options$ciWidth / 100) / 2 + .5, n - 1)) |>
-                        dplyr::ungroup() |>
-                        dplyr::rename(x = !!sym(group1))
+                        dplyr::ungroup()
                 } else {
                     df <- self$data |>
                         dplyr::mutate("{var}" := jmvcore::toNumeric(!!sym(var))) |>
                         dplyr::group_by(!!sym(group1), !!sym(group2)) |>
+                        dplyr::rename(
+                            y_full = !!sym(var),
+                            x = !!sym(group1),
+                            group = !!sym(group2)
+                        ) |>
                         dplyr::summarize(
-                            y = mean(!!sym(var), na.rm = TRUE),
+                            y = mean(y_full, na.rm = TRUE),
                             n = dplyr::n(),
-                            sd = sd(!!sym(var), na.rm = TRUE),
+                            sd = sd(y_full, na.rm = TRUE),
                         ) |>
                         dplyr::mutate(se = sd / sqrt(n)) |>
                         dplyr::mutate(ci = se * qt((self$options$ciWidth / 100) / 2 + .5, n - 1)) |>
-                        dplyr::ungroup() |>
-                        dplyr::rename(x = !!sym(group1), group = !!sym(group2))
+                        dplyr::ungroup()
                 }
 
                 return(df)

tests/testthat/_snaps/testbar/jmvbar-ses.svg

@@ -252,6 +252,7 @@ testthat::test_that("jmvbar: manual limits do not remove bars", {
     # THEN the bar should still be drawn (cropped)
     vdiffr::expect_doppelganger("jmvbar-manual-limits-zoom", disp_bar_zoom)
 })
+
 #' Font Face Tests
 testthat::test_that("jmvbar: custom font faces, sizes, and alignment", {
     # GIVEN categorical data with custom font faces, sizes, and alignment
@@ -285,3 +286,25 @@ testthat::test_that("jmvbar: custom font faces, sizes, and alignment", {
     # THEN the plot should match the snapshot
     vdiffr::expect_doppelganger("jmvbar-custom-styling", disp_bar_jmvplot)
 })
+
+#' Bar plot shows SEs
+testthat::test_that("jmvbar: SEs are shown (regression test)", {
+    # GIVEN grouped continuous data
+    df <- data.frame(
+        # The name "y" previously caused problems
+        y = c(94, 59, 84, 100, 61, 62, 30, 24, 11, 86),
+        group = rep(c("Group_A", "Group_B"), each = 5)
+    )
+
+    # WHEN a continuous bar plot with SEs is created
+    disp_bar_ses <- scatr::jmvbar(
+        data = df,
+        mode = "continuous",
+        convar = "y",
+        congroup1 = "group",
+        errorBars = "se"
+    )
+
+    # THEN the plot should show SE bars and match the snapshot
+    vdiffr::expect_doppelganger("jmvbar-ses", disp_bar_ses)
+})