Skip to content

Commit 1b2375f

Browse files
committed
improve javadoc
1 parent 60d33ec commit 1b2375f

File tree

1 file changed

+3
-4
lines changed
  • x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/approximate

1 file changed

+3
-4
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/approximate/Approximate.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,15 +197,14 @@ public interface LogicalPlanRunner {
197197

198198
/**
199199
* These multivalued aggregate functions work well with random sampling.
200+
* However, confidence intervals make no sense anymore and are dropped.
200201
*/
201202
private static final Set<Class<? extends AggregateFunction>> SUPPORTED_MULTIVALUED_AGGS = Set.of(
202203
org.elasticsearch.xpack.esql.expression.function.aggregate.Sample.class
203204
);
204205

205206
/**
206-
* These scalar functions produce multivalued output. When they are applied
207-
* to an approximated field, confidence intervals make no sense anymore and
208-
* are dropped.
207+
* These scalar functions produce multivalued output.
209208
*/
210209
private static final Set<Class<? extends EsqlScalarFunction>> MULTIVALUED_OUTPUT_FUNCTIONS = Set.of(MvAppend.class);
211210

@@ -422,7 +421,7 @@ private long rowCount(Result countResult) {
422421
* <li> Source command
423422
* <li> {@code SAMPLE} with the provided sample probability
424423
* <li> All commands before the {@code STATS} command
425-
* <li> {@code EVAL} adding a new column with a random bucket ID for each trial
424+
* <li> {@code EVAL} adding a new column with random bucket IDs for each trial
426425
* <li> {@code STATS} command with:
427426
* <ul>
428427
* <li> Each aggregate function replaced by a sample-corrected version (if needed)

0 commit comments

Comments
 (0)