logs for debugging heap size

Author: jan-elastic

distribution/tools/server-cli/src/main/java/org/elasticsearch/server/cli/JvmOption.java

@@ -9,6 +9,8 @@
 
 package org.elasticsearch.server.cli;
 
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.elasticsearch.common.Strings;
 import org.elasticsearch.core.SuppressForbidden;
 
@@ -33,6 +35,8 @@ class JvmOption {
     private final String value;
     private final String origin;
 
+    private static final Logger logger = LogManager.getLogger(JvmOption.class);
+
     JvmOption(String value, String origin) {
         if (origin == null) {
             throw new IllegalStateException(Strings.format("""
@@ -43,6 +47,11 @@ class JvmOption {
         this.origin = origin;
     }
 
+    @Override
+    public String toString() {
+        return "{value=" + value + ", origin=" + origin + "}";
+    }
+
     public Optional<String> getValue() {
         return Optional.ofNullable(value);
     }
@@ -124,6 +133,7 @@ private static List<String> flagsFinal(final List<String> userDefinedJvmOptions)
             );
             throw new RuntimeException(message);
         } else {
+            logger.info("@@@ JvmOption flagsFinal: {}", String.join("\n", output));
             return output;
         }
     }

distribution/tools/server-cli/src/main/java/org/elasticsearch/server/cli/MachineDependentHeap.java

@@ -9,6 +9,9 @@
 
 package org.elasticsearch.server.cli;
 
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.elasticsearch.cli.Terminal;
 import org.elasticsearch.cluster.node.DiscoveryNodeRole;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.common.util.FeatureFlag;
@@ -40,7 +43,17 @@ public class MachineDependentHeap {
 
     private static final FeatureFlag NEW_ML_MEMORY_COMPUTATION_FEATURE_FLAG = new FeatureFlag("new_ml_memory_computation");
 
-    public MachineDependentHeap() {}
+    private static final Logger logger = LogManager.getLogger(MachineDependentHeap.class);
+
+    private final Terminal terminal;
+
+    public MachineDependentHeap() {
+        this.terminal = null;
+    }
+
+    public MachineDependentHeap(Terminal terminal) {
+        this.terminal = terminal;
+    }
 
     /**
      * Calculate heap options.
@@ -57,6 +70,11 @@ public final List<String> determineHeapSettings(
     ) throws IOException, InterruptedException {
         // TODO: this could be more efficient, to only parse final options once
         final Map<String, JvmOption> finalJvmOptions = JvmOption.findFinalOptions(userDefinedJvmOptions);
+        if (terminal != null) {
+            terminal.println(
+                "@@@ MachineDependentHeap determineHeapSettings: MaxHeap=" + finalJvmOptions.get("MaxHeapSize") + " FeatureFlag="
+                    + NEW_ML_MEMORY_COMPUTATION_FEATURE_FLAG.isEnabled());
+        }
         if (isMaxHeapSpecified(finalJvmOptions) || isMinHeapSpecified(finalJvmOptions) || isInitialHeapSpecified(finalJvmOptions)) {
             // User has explicitly set memory settings so we use those
             return Collections.emptyList();
@@ -65,6 +83,13 @@ public final List<String> determineHeapSettings(
         List<DiscoveryNodeRole> roles = NodeRoleSettings.NODE_ROLES_SETTING.get(nodeSettings);
         long availableSystemMemory = systemMemoryInfo.availableSystemMemory();
         MachineNodeRole nodeRole = mapNodeRole(roles);
+        if (terminal != null) {
+            terminal.println("@@@ MachineDependentHeap determineHeapSettings: setMaxHeap: " + getHeapSizeMb(
+                nodeSettings,
+                nodeRole,
+                availableSystemMemory
+            ));
+        }
         return options(getHeapSizeMb(nodeSettings, nodeRole, availableSystemMemory));
     }
 

distribution/tools/server-cli/src/main/java/org/elasticsearch/server/cli/ServerCli.java

@@ -265,8 +265,13 @@ protected Command loadTool(Map<String, String> sysprops, String toolname, String
 
     // protected to allow tests to override
     protected ServerProcess startServer(Terminal terminal, ProcessInfo processInfo, ServerArgs args) throws Exception {
+        terminal.println("@@@ ServerCli startServer");
+
         var tempDir = ServerProcessUtils.setupTempDir(processInfo);
         var jvmOptions = JvmOptionsParser.determineJvmOptions(args, processInfo, tempDir, new MachineDependentHeap());
+
+        terminal.println("@@@ ServerCli startServer: jvmOptions=" + jvmOptions);
+
         var serverProcessBuilder = new ServerProcessBuilder().withTerminal(terminal)
             .withProcessInfo(processInfo)
             .withServerArgs(args)