ESQL: take INLINE STATS out of snapshot (elastic#135403)

Author: astefan

docs/changelog/135403.yaml

@@ -0,0 +1,12 @@
+pr: 135403
+summary: Take INLINE STATS out of snapshot
+area: ES|QL
+type: enhancement
+issues: []
+highlight:
+  title: Enable INLINE STATS in non-snapshot builds
+  body: |-
+    This effectively releases INLINE STATS into tech preview.
+    - Enable the lexing/grammar for INLINE STATS in non-snapshot builds.
+    - Enable more tests with FORK and INLINE STATS
+  notable: true

x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/RestEsqlIT.java

@@ -479,7 +479,6 @@ public void assertDriverData(Map<String, Object> driverMetadata, Map<String, Obj
 
     @AwaitsFix(bugUrl = "disabled until JOIN infrastructrure properly lands")
     public void testInlineStatsProfile() throws IOException {
-        assumeTrue("INLINE STATS only available on snapshots", Build.current().isSnapshot());
         indexTimestampData(1);
 
         RequestObjectBuilder builder = requestObjectBuilder().query(fromIndex() + " | INLINE STATS AVG(value) | SORT value ASC");

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/RestEsqlTestCase.java

@@ -11,7 +11,6 @@
 import org.apache.http.entity.ContentType;
 import org.apache.http.nio.entity.NByteArrayEntity;
 import org.apache.http.util.EntityUtils;
-import org.elasticsearch.Build;
 import org.elasticsearch.client.Request;
 import org.elasticsearch.client.RequestOptions;
 import org.elasticsearch.client.Response;
@@ -1221,7 +1220,7 @@ public void testComplexFieldNames() throws IOException {
      * </p>
      */
     public void testInlineStatsNow() throws IOException {
-        assumeTrue("INLINE STATS only available on snapshots", Build.current().isSnapshot());
+        assumeTrue("INLINE STATS only available on snapshots", EsqlCapabilities.Cap.INLINE_STATS.isEnabled());
         indexTimestampData(1);
 
         RequestObjectBuilder builder = requestObjectBuilder().query(

x-pack/plugin/esql/qa/testFixtures/src/main/resources/fork.csv-spec

@@ -688,8 +688,7 @@ emp_no:integer | job_positions:keyword | _fork:keyword
 10087          | Junior Developer      | fork2
 ;
 
-// INLINE STATS is under development, we enable this once it will be available
-forkBeforeInlineStats-Ignore
+forkBeforeInlineStats
 required_capability: fork_v9
 required_capability: inline_stats
 
@@ -703,11 +702,13 @@ FROM employees
 ;
 
 emp_no:integer | languages:integer | _fork:keyword | max_lang:integer | gender:keyword
-1 | 2 | 3 | 4 | 5
+10048          |3                  |fork1          |3                 |M              
+10081          |2                  |fork1          |3                 |M              
+10081          |2                  |fork2          |3                 |M              
+10087          |5                  |fork2          |5                 |F
 ;
 
-// INLINE STATS is under development, we enable this once it will be available
-forkBranchWithInlineStats-Ignore
+forkBranchWithInlineStats
 required_capability: fork_v9
 required_capability: inline_stats
 
@@ -729,8 +730,7 @@ emp_no:integer | languages:integer | x:integer | gender:keyword | _fork:keyword
 10087          | 5                 | 2         | F              | fork2
 ;
 
-// INLINE STATS is under development, we enable this once it will be available
-forkAfterInlineStats-Ignore
+forkAfterInlineStats
 required_capability: fork_v9
 required_capability: inline_stats
 

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/TelemetryIT.java

@@ -10,7 +10,6 @@
 import com.carrotsearch.randomizedtesting.annotations.Name;
 import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
 
-import org.elasticsearch.Build;
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.cluster.metadata.IndexMetadata;
 import org.elasticsearch.cluster.node.DiscoveryNode;
@@ -184,11 +183,13 @@ public static Iterable<Object[]> parameters() {
                         | EVAL ip = TO_IP(host), x = TO_STRING(host), y = TO_STRING(host)
                         | INLINE STATS MAX(id)
                         """,
-                    Build.current().isSnapshot() ? Map.of("FROM", 1, "EVAL", 1, "INLINE STATS", 1) : Collections.emptyMap(),
-                    Build.current().isSnapshot()
+                    EsqlCapabilities.Cap.INLINE_STATS.isEnabled()
+                        ? Map.of("FROM", 1, "EVAL", 1, "INLINE STATS", 1)
+                        : Collections.emptyMap(),
+                    EsqlCapabilities.Cap.INLINE_STATS.isEnabled()
                         ? Map.ofEntries(Map.entry("MAX", 1), Map.entry("TO_IP", 1), Map.entry("TO_STRING", 2))
                         : Collections.emptyMap(),
-                    Build.current().isSnapshot()
+                    EsqlCapabilities.Cap.INLINE_STATS.isEnabled()
                 ) }
         );
     }

x-pack/plugin/esql/src/main/antlr/EsqlBaseLexer.tokens

@@ -65,8 +65,8 @@ processingCommand
     | sampleCommand
     | forkCommand
     | rerankCommand
+    | inlineStatsCommand
     // in development
-    | {this.isDevVersion()}? inlineStatsCommand
     | {this.isDevVersion()}? lookupCommand
     | {this.isDevVersion()}? insistCommand
     | {this.isDevVersion()}? fuseCommand
@@ -320,19 +320,19 @@ completionCommand
     : COMPLETION (targetField=qualifiedName ASSIGN)? prompt=primaryExpression commandNamedParameters
     ;
 
+inlineStatsCommand
+    : INLINE INLINE_STATS stats=aggFields (BY grouping=fields)?
+    // TODO: drop after next minor release
+    | INLINESTATS stats=aggFields (BY grouping=fields)?
+    ;
+
 //
 // In development
 //
 lookupCommand
     : DEV_LOOKUP tableName=indexPattern ON matchFields=qualifiedNamePatterns
     ;
 
-inlineStatsCommand
-    : DEV_INLINE INLINE_STATS stats=aggFields (BY grouping=fields)?
-    // TODO: drop after next minor release
-    | DEV_INLINESTATS stats=aggFields (BY grouping=fields)?
-    ;
-
 insistCommand
     : DEV_INSIST qualifiedNamePatterns
     ;

x-pack/plugin/esql/src/main/antlr/EsqlBaseParser.g4

@@ -7,8 +7,8 @@
 
 lexer grammar Inline;
 
-DEV_INLINE : {this.isDevVersion()}? 'inline' -> pushMode(INLINE_MODE);
-DEV_INLINESTATS : {this.isDevVersion()}? 'inlinestats' -> pushMode(EXPRESSION_MODE); // TODO: drop after next minor release
+INLINE : 'inline' -> pushMode(INLINE_MODE);
+INLINESTATS : 'inlinestats' -> pushMode(EXPRESSION_MODE); // TODO: drop after next minor release
 
 mode INLINE_MODE;
 

x-pack/plugin/esql/src/main/antlr/EsqlBaseParser.tokens

@@ -14,7 +14,6 @@
 import org.elasticsearch.rest.action.admin.cluster.RestNodesCapabilitiesAction;
 import org.elasticsearch.xpack.esql.core.plugin.EsqlCorePlugin;
 import org.elasticsearch.xpack.esql.plugin.EsqlFeatures;
-import org.elasticsearch.xpack.esql.plugin.EsqlPlugin;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -269,12 +268,12 @@ public enum Cap {
         /**
          * Support for the {@code INLINESTATS} syntax.
          */
-        INLINESTATS(EsqlPlugin.INLINE_STATS_FEATURE_FLAG),
+        INLINESTATS(),
 
         /**
          * Support for the expressions in grouping in {@code INLINESTATS} syntax.
          */
-        INLINESTATS_V2(EsqlPlugin.INLINE_STATS_FEATURE_FLAG),
+        INLINESTATS_V2(),
 
         /**
          * Support for aggregation function {@code TOP}.
@@ -993,12 +992,12 @@ public enum Cap {
          * Fixes a series of issues with inlinestats which had an incomplete implementation after lookup and inlinestats
          * were refactored.
          */
-        INLINESTATS_V11(EsqlPlugin.INLINE_STATS_FEATURE_FLAG),
+        INLINESTATS_V11,
 
         /**
          * Renamed `INLINESTATS` to `INLINE STATS`.
          */
-        INLINE_STATS(EsqlPlugin.INLINE_STATS_FEATURE_FLAG),
+        INLINE_STATS,
 
         /**
          * Support partial_results