Skip to content

Commit b91f28a

Browse files
ES|QL: unmute INLINE STATS generative tests (elastic#136798)
Since elastic#135679 was fixed, we can re-enable INLINE STATS generative tests. Unfortunately, there is a new failure, see elastic#136797, so I had to add an exception for that (that means `PostOptimizationPhasePlanVerifier` checks won't be considered by generative tests)
1 parent 59fb5b6 commit b91f28a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/GenerativeRestTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ public abstract class GenerativeRestTest extends ESRestTestCase implements Query
6767
"Data too large", // Circuit breaker exceptions eg. https://github.com/elastic/elasticsearch/issues/130072
6868
"optimized incorrectly due to missing references", // https://github.com/elastic/elasticsearch/issues/131509
6969
"long overflow", // https://github.com/elastic/elasticsearch/issues/135759
70-
"can't build page out of released blocks", // https://github.com/elastic/elasticsearch/issues/135679
7170
"cannot be cast to class", // https://github.com/elastic/elasticsearch/issues/133992
7271
"can't find input for", // https://github.com/elastic/elasticsearch/issues/136596
7372
"unexpected byte", // https://github.com/elastic/elasticsearch/issues/136598
7473
"Rule execution limit", // https://github.com/elastic/elasticsearch/issues/136599
74+
"Output has changed from", // https://github.com/elastic/elasticsearch/issues/136797
7575

7676
// Awaiting fixes for correctness
7777
"Expecting at most \\[.*\\] columns, got \\[.*\\]", // https://github.com/elastic/elasticsearch/issues/129561

x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/generator/EsqlQueryGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import org.elasticsearch.xpack.esql.generator.command.pipe.EvalGenerator;
1818
import org.elasticsearch.xpack.esql.generator.command.pipe.ForkGenerator;
1919
import org.elasticsearch.xpack.esql.generator.command.pipe.GrokGenerator;
20+
import org.elasticsearch.xpack.esql.generator.command.pipe.InlineStatsGenerator;
2021
import org.elasticsearch.xpack.esql.generator.command.pipe.KeepGenerator;
2122
import org.elasticsearch.xpack.esql.generator.command.pipe.LimitGenerator;
2223
import org.elasticsearch.xpack.esql.generator.command.pipe.LookupJoinGenerator;
@@ -69,8 +70,7 @@ public class EsqlQueryGenerator {
6970
ForkGenerator.INSTANCE,
7071
GrokGenerator.INSTANCE,
7172
KeepGenerator.INSTANCE,
72-
// awaits fix for https://github.com/elastic/elasticsearch/issues/135679
73-
// InlineStatsGenerator.INSTANCE,
73+
InlineStatsGenerator.INSTANCE,
7474
LimitGenerator.INSTANCE,
7575
LookupJoinGenerator.INSTANCE,
7676
MvExpandGenerator.INSTANCE,

0 commit comments

Comments
 (0)