Skip to content

Commit 5beac05

Browse files
authored
Merge pull request udacity#17 from thiago-grabe/dev_basic_cleaning
fix: unsetting arguments
2 parents 962ff21 + c41f59c commit 5beac05

File tree

1 file changed

+25
-22
lines changed

1 file changed

+25
-22
lines changed

src/basic_cleaning/run.py

Lines changed: 25 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
logging.basicConfig(level=logging.INFO, format="%(asctime)-15s %(message)s")
1212
logger = logging.getLogger()
1313

14-
14+
# DO NOT MODIFY
1515
def go(args):
1616

1717
run = wandb.init(job_type="basic_cleaning")
@@ -43,51 +43,54 @@ def go(args):
4343
)
4444
artifact.add_file("clean_sample.csv")
4545
run.log_artifact(artifact)
46-
if __name__ == "__main__":
4746

48-
parser = argparse.ArgumentParser(description="A very basic data cleaning")
4947

48+
# TODO: In the code below, fill in the data type for each argumemt. The data type should be str, float or int.
49+
# TODO: In the code below, fill in a description for each argument. The description should be a string.
50+
if __name__ == "__main__":
5051

52+
parser = argparse.ArgumentParser(description="A very basic data cleaning")
53+
5154
parser.add_argument(
5255
"--input_artifact",
53-
type=str,
54-
help='Input data',
55-
required=True
56+
type = ## INSERT TYPE HERE: str, float or int,
57+
help = ## INSERT DESCRIPTION HERE,
58+
required = True
5659
)
5760

5861
parser.add_argument(
5962
"--output_artifact",
60-
type=str,
61-
help='Cleaned data',
62-
required=True
63+
type = ## INSERT TYPE HERE: str, float or int,
64+
help = ## INSERT DESCRIPTION HERE,
65+
required = True
6366
)
6467

6568
parser.add_argument(
6669
"--output_type",
67-
type=str,
68-
help='Csv file',
69-
required=True
70+
type = ## INSERT TYPE HERE: str, float or int,
71+
help = ## INSERT DESCRIPTION HERE,
72+
required = True
7073
)
7174

7275
parser.add_argument(
7376
"--output_description",
74-
type=str,
75-
help='Preprocessed data',
76-
required=True
77+
type = ## INSERT TYPE HERE: str, float or int,
78+
help = ## INSERT DESCRIPTION HERE,
79+
required = True
7780
)
7881

7982
parser.add_argument(
8083
"--min_price",
81-
type=float,
82-
help='Minimum rent price',
83-
required=True
84+
type = ## INSERT TYPE HERE: str, float or int,
85+
help = ## INSERT DESCRIPTION HERE,
86+
required = True
8487
)
8588

8689
parser.add_argument(
87-
"--max_price",
88-
type=float,
89-
help='Maximum rent price',
90-
required=True
90+
"--max_price",
91+
type = ## INSERT TYPE HERE: str, float or int,
92+
help = ## INSERT DESCRIPTION HERE,
93+
required = True
9194
)
9295

9396

0 commit comments

Comments
 (0)