fix link issue on windows

Author: namchuai

engine/common/message.h

@@ -21,16 +21,16 @@ namespace OpenAi {
 
 inline std::string ExtractFileId(const std::string& path) {
   // Handle both forward and backward slashes
-  size_t lastSlash = path.find_last_of("/\\");
-  if (lastSlash == std::string::npos)
+  auto last_slash = path.find_last_of("/\\");
+  if (last_slash == std::string::npos)
     return "";
 
-  std::string filename = path.substr(lastSlash + 1);
-  size_t dotPosition = filename.find('.');
-  if (dotPosition == std::string::npos)
+  auto filename = path.substr(last_slash + 1);
+  auto dot_pos = filename.find('.');
+  if (dot_pos == std::string::npos)
     return "";
 
-  return filename.substr(0, dotPosition);
+  return filename.substr(0, dot_pos);
 }
 
 // Represents a message within a thread.

engine/common/repository/file_repository.h

@@ -22,7 +22,7 @@ class FileRepository {
   virtual cpp::result<std::pair<std::unique_ptr<char[]>, size_t>, std::string>
   RetrieveFileContentByPath(const std::string& path) const = 0;
 
-  virtual cpp::result<void, std::string> DeleteFile(
+  virtual cpp::result<void, std::string> DeleteFileLocal(
       const std::string& file_id) = 0;
 
   virtual ~FileRepository() = default;

engine/controllers/files.cc

@@ -169,7 +169,7 @@ void Files::RetrieveFile(const HttpRequestPtr& req,
 void Files::DeleteFile(const HttpRequestPtr& req,
                        std::function<void(const HttpResponsePtr&)>&& callback,
                        const std::string& file_id) {
-  auto res = file_service_->DeleteFile(file_id);
+  auto res = file_service_->DeleteFileLocal(file_id);
   if (res.has_error()) {
     Json::Value ret;
     ret["message"] = res.error();

engine/repositories/file_fs_repository.cc

@@ -135,7 +135,7 @@ FileFsRepository::RetrieveFileContentByPath(const std::string& path) const {
   }
 }
 
-cpp::result<void, std::string> FileFsRepository::DeleteFile(
+cpp::result<void, std::string> FileFsRepository::DeleteFileLocal(
     const std::string& file_id) {
   CTL_INF("Deleting file: " + file_id);
   auto file_container_path = GetFilePath();

engine/repositories/file_fs_repository.h

@@ -25,7 +25,7 @@ class FileFsRepository : public FileRepository {
   cpp::result<std::pair<std::unique_ptr<char[]>, size_t>, std::string>
   RetrieveFileContentByPath(const std::string& path) const override;
 
-  cpp::result<void, std::string> DeleteFile(
+  cpp::result<void, std::string> DeleteFileLocal(
       const std::string& file_id) override;
 
   explicit FileFsRepository(std::filesystem::path data_folder_path)

engine/services/file_service.cc

@@ -39,9 +39,9 @@ cpp::result<OpenAi::File, std::string> FileService::RetrieveFile(
   return file_repository_->RetrieveFile(file_id);
 }
 
-cpp::result<void, std::string> FileService::DeleteFile(
+cpp::result<void, std::string> FileService::DeleteFileLocal(
     const std::string& file_id) {
-  return file_repository_->DeleteFile(file_id);
+  return file_repository_->DeleteFileLocal(file_id);
 }
 
 cpp::result<std::pair<std::unique_ptr<char[]>, size_t>, std::string>

engine/services/file_service.h

@@ -21,7 +21,7 @@ class FileService {
   cpp::result<OpenAi::File, std::string> RetrieveFile(
       const std::string& file_id) const;
 
-  cpp::result<void, std::string> DeleteFile(const std::string& file_id);
+  cpp::result<void, std::string> DeleteFileLocal(const std::string& file_id);
 
   cpp::result<std::pair<std::unique_ptr<char[]>, size_t>, std::string>
   RetrieveFileContent(const std::string& file_id) const;