Skip to content

Commit f8590f2

Browse files
CISCMinh141120
authored andcommitted
chore : clean up relative source dir paths (ggml-org#14128)
1 parent 170b187 commit f8590f2

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

common/CMakeLists.txt

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ llama_add_compile_flags()
77
# Build info header
88
#
99

10+
if(EXISTS "${PROJECT_SOURCE_DIR}/.git")
11+
set(GIT_DIR "${PROJECT_SOURCE_DIR}/.git")
1012
if(EXISTS "${PROJECT_SOURCE_DIR}/.git")
1113
set(GIT_DIR "${PROJECT_SOURCE_DIR}/.git")
1214

@@ -32,10 +34,19 @@ else()
3234
message(WARNING "Git repository not found; to enable automatic generation of build info, make sure Git is installed and the project is a Git repository.")
3335
endif()
3436

35-
set(TEMPLATE_FILE "${CMAKE_CURRENT_SOURCE_DIR}/build-info.cpp.in")
36-
set(OUTPUT_FILE "${CMAKE_CURRENT_BINARY_DIR}/build-info.cpp")
37-
configure_file(${TEMPLATE_FILE} ${OUTPUT_FILE})
38-
37+
# Add a custom command to rebuild build-info.cpp when .git/index changes
38+
add_custom_command(
39+
OUTPUT "${CMAKE_CURRENT_SOURCE_DIR}/build-info.cpp"
40+
COMMENT "Generating build details from Git"
41+
COMMAND ${CMAKE_COMMAND} -DMSVC=${MSVC} -DCMAKE_C_COMPILER_VERSION=${CMAKE_C_COMPILER_VERSION}
42+
-DCMAKE_C_COMPILER_ID=${CMAKE_C_COMPILER_ID} -DCMAKE_VS_PLATFORM_NAME=${CMAKE_VS_PLATFORM_NAME}
43+
-DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
44+
-DCMAKE_SYSTEM_NAME=${CMAKE_SYSTEM_NAME} -DCMAKE_SYSTEM_PROCESSOR=${CMAKE_SYSTEM_PROCESSOR}
45+
-P "${CMAKE_CURRENT_SOURCE_DIR}/cmake/build-info-gen-cpp.cmake"
46+
WORKING_DIRECTORY "${PROJECT_SOURCE_DIR}"
47+
DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/build-info.cpp.in" ${GIT_INDEX}
48+
VERBATIM
49+
)
3950
set(TARGET build_info)
4051
add_library(${TARGET} OBJECT ${OUTPUT_FILE})
4152
if (BUILD_SHARED_LIBS)

tests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ if (NOT WIN32)
130130
${CMAKE_CURRENT_SOURCE_DIR}/test-tokenizers-repo.sh
131131
NAME test-tokenizers-ggml-vocabs
132132
WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
133-
ARGS https://huggingface.co/ggml-org/vocabs ${CMAKE_CURRENT_SOURCE_DIR}/../models/ggml-vocabs
133+
ARGS https://huggingface.co/ggml-org/vocabs ${PROJECT_SOURCE_DIR}/models/ggml-vocabs
134134
)
135135
endif()
136136

0 commit comments

Comments
 (0)