fixed duplicate posts being fetched, some cli improvements

Author: janithl

ui/cli.go

@@ -74,7 +74,7 @@ func (c *CLI) listAll() {
 	}
 
 	for _, pub := range pubs {
-		fmt.Printf("%s (%s)\n", pub.Title, pub.URL)
+		fmt.Printf("%-20s %-60s %4d posts\n", pub.Title, pub.URL, len(pub.Posts))
 	}
 }
 

usecases/publicationServiceImpl.go

@@ -60,13 +60,7 @@ func (p *PublicationServiceImpl) Find(id string) (entities.Publication, error) {
 func (p *PublicationServiceImpl) FetchPublicationPosts(pub entities.Publication) error {
 	posts := p.reader.Read(pub.URL)
 	for _, post := range posts {
-		if post.ID == "" {
-			post.ID = p.generateID()
-		}
-		post.AddedAt = time.Now()
-		post.UpdatedAt = time.Now()
-
-		pub.AddPost(post)
+		pub = p.addUniquePost(pub, post)
 	}
 
 	pub.FetchedAt = time.Now()
@@ -77,3 +71,21 @@ func (p *PublicationServiceImpl) FetchPublicationPosts(pub entities.Publication)
 func (p *PublicationServiceImpl) generateID() string {
 	return fmt.Sprintf("%x-%x-%x", p.random.Uint32(), p.random.Uint32(), p.random.Uint32())
 }
+
+func (p *PublicationServiceImpl) addUniquePost(pub entities.Publication, post entities.Post) entities.Publication {
+	for _, item := range pub.Posts {
+		if item.URL == post.URL {
+			return pub
+		}
+	}
+
+	if post.ID == "" {
+		post.ID = p.generateID()
+	}
+	post.AddedAt = time.Now()
+	post.UpdatedAt = time.Now()
+
+	pub.AddPost(post)
+
+	return pub
+}

usecases/publicationServiceImpl_test.go

@@ -172,8 +172,8 @@ func TestFetchPublicationPostsAddAndListAll(t *testing.T) {
 	} else {
 		t.Run("Make sure all the posts have been added in...", func(t *testing.T) {
 			matches := 0
-			for _, wants := range mockFeedReader.Posts {
-				for _, gots := range pub.Posts {
+			for _, gots := range pub.Posts {
+				for _, wants := range mockFeedReader.Posts {
 					if gots.Title == wants.Title && gots.URL == wants.URL {
 						t.Logf("Got '%s', want '%s'", gots, wants)
 						matches++