Cleanup: Fix core-test Deps Order, Remove Unused, etc. (#798)

* Cleanup

* More cleanup

* Fix cljr

* Next round

* More!

* Remove superfluous paren

* WIP

* WIP

* Fix more parens

* More!

* Whoops

* Add back

* clj the kondo

* WIP

* int

* Next batch

* Some more

* WIP

* Next round

* Another round

* 4 more

* mooooooore

* Trickier ones

* Fix num

* Next round

* more more more!

* Fix parse-double

* Next one

* Fix `parse-uuid`

* Tricky ones

* Fix `parse-long`

* updates

* Fix

* Fix

* Fix `unsigned-bit-shift-right`

* Last batch

* grammar

* Add space

* `is` before `testing`

* Missed a whole batch

* is before testing

* Move common case to `:default`

* Remove whitespace

* Whoops

* Some more cleanup

* Some more

* Syntax!

* Provide defaults

* Cleanup

* Fix syntax issue

* Take 2

Author: E-A-Griffin

.clj-kondo/config.edn

@@ -0,0 +1,11 @@
+{:linters {:inline-def             {:level :off}
+           :invalid-arity          {:level :off}
+           :missing-body-in-when   {:level :off}
+           :single-logical-operand {:level :off}
+           :type-mismatch          {:level :off}
+           :unresolved-symbol      {:level :off}
+           :uninitialized-var      {:level :off}
+           :unused-namespace       {:level :off}
+           :unused-referred-var    {:level :off}
+           :unused-value           {:level :off}}
+ :lint-as {clojure.core-test.portability/when-var-exists clojure.core/when}}

.gitignore

@@ -11,8 +11,10 @@ pom.xml.asc
 /.prepl-port
 .hgignore
 .hg/
-/.clj-kondo
-/.lsp
+/.clj-kondo/*
+!/.clj-kondo/config.edn
+/.lsp/*
+!/.lsp/config.edn
 *~
 .*.swp
 /node_modules

.lsp/config.edn

@@ -0,0 +1 @@
+{:linters {:clojure-lsp/unused-public-var {:level :off}}}

templates/test-template.cljc

@@ -1,6 +1,6 @@
 (ns {{base-ns}}-test.{{ns-suffix}}
   (:require {% if not base-ns = "clojure.core" %}{{base-ns}}
-            {% endif %}[clojure.test :as t :refer [deftest testing is are]]
+            {% endif %}[clojure.test :as t :refer [are deftest is testing]]
             [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
 
 (when-var-exists {% if not base-ns = "clojure.core" %}{{base-ns}}/{% endif %}{{sym-name}}

test/clojure/core_test/abs.cljc

@@ -1,29 +1,32 @@
 (ns clojure.core-test.abs
-  (:require [clojure.test :as t :refer [deftest testing is are]]
+  (:require [clojure.test :as t :refer [are deftest is testing]]
             [clojure.core-test.number-range :as r]
-            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer)  [when-var-exists]]))
+            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
 
-(when-var-exists clojure.core/abs
+(when-var-exists abs
   (deftest test-abs
     (testing "common"
      (are [in ex] (= ex (abs in))
-       -1             1
-       1              1
-       (inc r/min-int)      (- (inc r/min-int))
-       #?@(:clj [r/min-int r/min-int])  ; fixed int 2's complement oddity, see below for :cljr
-       -1.0           1.0
-       -0.0           0.0
-       ##-Inf         ##Inf
-       ##Inf          ##Inf
-       -123.456M      123.456M
-       -123N          123N
+       -1              1
+       1               1
+       (inc r/min-int) (- (inc r/min-int))
+       -1.0            1.0
+       -0.0            0.0
+       ##-Inf          ##Inf
+       ##Inf           ##Inf
+       -123.456M       123.456M
+       -123N           123N
+
+       #?@(:cljr []
+           :clj [r/min-int r/min-int] ; fixed int 2's complement oddity, see below for :cljr
+           :default [r/min-int (* -1 r/min-int)])
        #?@(:cljs []
            :default
-           [-1/5           1/5]))
+           [-1/5 1/5]))
      (is (NaN? (abs ##NaN)))
-	 #?(:cljr (is (thrown? System.OverflowException (abs r/min-int))))
+     #?(:cljr (is (thrown? System.OverflowException (abs r/min-int))))
      #?(:cljs (is (zero? (abs nil)))
-        :default (is (thrown? #?(:clj Exception :cljr Exception) (abs nil)))))
+        :default (is (thrown? Exception (abs nil)))))
 
     (testing "unboxed"
       (let [a  42

test/clojure/core_test/aclone.cljc

@@ -1,8 +1,8 @@
 (ns clojure.core-test.aclone
-  (:require [clojure.test :as t :refer [deftest testing is are]]
-            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer)  [when-var-exists]]))
+  (:require [clojure.test :as t :refer [deftest is testing]]
+            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
 
-(when-var-exists clojure.core/aclone
+(when-var-exists aclone
   (defn clone-test
     [a b]
     (aset a 0 1)

test/clojure/core_test/add_watch.cljc

@@ -1,8 +1,8 @@
 (ns clojure.core-test.add-watch
-  (:require [clojure.test :as t :refer [deftest testing is are]]
-            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer)  [when-var-exists sleep]]))
+  (:require [clojure.test :as t :refer [deftest is testing]]
+            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists sleep]]))
 
-(when-var-exists clojure.core/add-watch
+(when-var-exists add-watch
   (deftest test-add-watch
     (testing "watch atom"
       ;; checks atoms and interspersed multiple watches
@@ -156,7 +156,7 @@
                            (catch #?(:cljs :default
                                      :clj clojure.lang.ExceptionInfo
                                      :cljr clojure.lang.ExceptionInfo) e
-                             (let [{:keys [old] :as data} (ex-data e)]
+                             (let [{:keys [_old] :as data} (ex-data e)]
                                (vswap! state conj data)))))
                keyed (fn [k s] (filter #(= k (:key %)) s))]
 
@@ -216,14 +216,14 @@
         :default
         [(testing "watch agent"
            (let [state (volatile! [])
-                 tester1 (fn [key ref old new]
+                 tester1 (fn [key _ref old new]
                            (when (not= old new)
                              (vswap! state conj {:key key :old old :new new :tester 1})))
-                 tester2 (fn [key ref old new]
+                 tester2 (fn [key _ref old new]
                            (when (not= old new)
                              (vswap! state conj {:key key :old old :new new :tester 2})))
                  agent-end (promise)
-                 err (fn [key ref old new]
+                 err (fn [key _ref old new]
                        (deliver agent-end :done)
                        (throw (ex-info "test" {:key key :old old :new new :tester :err})))
                  g (agent 20)
@@ -232,7 +232,7 @@
                              (vswap! state conj (ex-data e))
                              (restart-agent g :ready))
                            (send g inc))
-                 keyed (fn [k s] (set (filter #(= k (:key %)) s)))]
+                 _keyed (fn [k s] (set (filter #(= k (:key %)) s)))]
 
              ;; add a watch to the agent
              (is (= g (add-watch g :g tester1)))

test/clojure/core_test/and.cljc

@@ -1,12 +1,13 @@
 (ns clojure.core-test.and
-  (:require [clojure.test :as t :refer [deftest testing is are]]
-            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer)  [when-var-exists]]))
+  (:require [clojure.test :as t :refer [are deftest is testing]]
+            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
 
-(when-var-exists clojure.core/and
+(when-var-exists and
   (deftest test-and
     (testing "common"
       (is (= true (and)))
-      (are [x] (= x (and x))
+      (are [x] (= x
+                  (and x))
         true
         false
         nil
@@ -33,4 +34,5 @@
         (is (= nil (and nil nil nil nil nil nil nil nil nil nil nil nil true)))))
 
    (testing "infinite-sequence"
-     (is (some? (and (range)))))))
+     (is (some?
+          (and (range)))))))

test/clojure/core_test/any_qmark.cljc

@@ -1,8 +1,8 @@
 (ns clojure.core-test.any-qmark
-  (:require [clojure.test :as t :refer [deftest testing is are]]
-            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer)  [when-var-exists]]))
+  (:require [clojure.test :as t :refer [are deftest is testing]]
+            [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
 
-(when-var-exists clojure.core/any?
+(when-var-exists any?
   (deftest test-any?
     (testing "common"
       (are [x] (= true (any? x))

test/clojure/core_test/assoc.cljc

@@ -1,5 +1,5 @@
 (ns clojure.core-test.assoc
-  (:require [clojure.test :refer [deftest testing is are]]
+  (:require [clojure.test :refer [are deftest is testing]]
             [clojure.core-test.portability #?(:cljs :refer-macros :default :refer) [when-var-exists]]))
 
 (when-var-exists assoc