Support running against Basilisp (#840)

* Support running against Basilisp

* Support Basilisp

* Fixes

* README and Babashka

* More updates

* Fix string tests

* Fix test

* More tests

* Parse tests

* Fixes

* Fixes

* Atom

* More changes

* More

* Use pip/setuptools

* fix bb.edn

* Fix

* More fixes

* More fixes

* More changes

* More

* More changes

* Ignore

* Missed it

* Pos int

* Fixing

* Ignore all sorted-set

* More fixes

* denominator / numerator

* Many more fixes

* More and more and more

* Fix CLJS

* More

* Changes

* Fix cycle

* assoc

* Fix

* rationalize

* Transients

* nth

* hierarchies

* subvec

* Flake

* merge

* byte

* Fix case

* Run tests in parallel

* Run in parallel

* Trigger build

* Fix

* Use `main`

* Update project description language

* Couple of PR comments

* Fixing some peculiar whitespace

* Align

* Comments and conditionals

Author: chrisrink10

.github/workflows/ci.yml

@@ -136,3 +136,26 @@ jobs:
 
       - name: Run ClojureCLR Tests
         run: cljr -X:test
+
+  test-basilisp:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.13"
+
+      - name: Install pip and dependencies
+        run: |
+          pip install -U pip
+          python -m venv .venv
+          source .venv/bin/activate
+          pip install .
+
+      - name: Run tests
+        run: |
+          source .venv/bin/activate
+          BASILISP_TEST_PATH="$(pwd)/test" \
+            BASILISP_TEST_FILE_PATTERN='.*\.(lpy|cljc)' \
+            basilisp test -p test -- -n auto

.gitignore

@@ -22,3 +22,7 @@ pom.xml.asc
 /.cpcache
 .idea
 *.iml
+__pycache__/
+.python-version
+poetry.lock
+*.egg-info/

README.md

@@ -86,6 +86,29 @@ npx nodemon -w target/js taget/js/node-tests.js --test=clojure.core-test.int-que
 cljr -X:test
 ```
 
+## Running the Basilisp tests
+
+### Pre-requisites
+- Python 3 / `pip`
+
+You can install Python and `pip` using a tool such as [pyenv](https://github.com/pyenv/pyenv).
+With `pip` installed, you can install Basilisp:
+
+```bash
+pip install -U pip
+python -m venv .venv
+source .venv/bin/activate
+pip install .
+```
+
+Tests can be run using the Babashka task:
+
+```bash
+source .venv/bin/activate
+bb test-lpy
+deactivate
+```
+
 ## Babashka Tasks
 
 You can see which Babashka tasks are available with:

bb.edn

@@ -11,6 +11,11 @@
            :exec-args {:patterns [".*"]}}
   test-cljs {:doc "Runs CLJS tests"
              :task (shell "npx shadow-cljs compile test")}
+  test-lpy {:doc  "Run Basilisp tests"
+            :task (shell
+                   {:extra-env {"BASILISP_TEST_PATH"         "./test"
+                                "BASILISP_TEST_FILE_PATTERN" ".*\\.(lpy|cljc)"}}
+                   "basilisp test -p test -- -n auto")}
   new-test {:doc "Creates new test for the Clojure symbols named by <args>. Unqualified symbols assume clojure.core"
             :requires ([new-test])
             :task (new-test/new-test *command-line-args*)}

pyproject.toml

@@ -0,0 +1,19 @@
+[project]
+name = "clojure-test-suite"
+version = "0.1.0"
+description = "Dialect-independent tests for clojure.core, and others, focused on characterizing how Clojure JVM behaves so that other dialects to reach parity."
+authors = []
+license = "MPL-2.0"
+readme = "README.md"
+requires-python = ">=3.10"
+dependencies = [
+   "basilisp[pytest] @ git+https://github.com/basilisp-lang/basilisp",
+   "pytest-xdist"
+]
+
+[tool.setuptools]
+packages = []
+
+[build-system]
+requires = ["setuptools >= 77.0.3"]
+build-backend = "setuptools.build_meta"

test/clojure/core_test/abs.cljc

@@ -9,15 +9,19 @@
      (are [in ex] (= ex (abs in))
        -1              1
        1               1
-       (inc r/min-int) (- (inc r/min-int))
        -1.0            1.0
        -0.0            0.0
        ##-Inf          ##Inf
        ##Inf           ##Inf
        -123.456M       123.456M
        -123N           123N
 
+       ;; Python VMs integer types are arbitrary precision and have no min or max
+       #?@(:lpy []
+           :default [(inc r/min-int) (- (inc r/min-int))])
+
        #?@(:cljr []
+           :lpy []
            :clj [r/min-int r/min-int] ; fixed int 2's complement oddity, see below for :cljr
            :default [r/min-int (* -1 r/min-int)])
        #?@(:cljs []

test/clojure/core_test/add_watch.cljc

@@ -19,7 +19,8 @@
                                           (swap! x inc)
                                           (catch #?(:cljs :default
                                                     :clj clojure.lang.ExceptionInfo
-                                                    :cljr clojure.lang.ExceptionInfo) e
+                                                    :cljr clojure.lang.ExceptionInfo
+                                                    :lpy basilisp.lang.exception/ExceptionInfo) e
                                             (let [data (ex-data e)]
                                               (vswap! state conj data)))))]
                         (do-update a)
@@ -89,7 +90,8 @@
                                                (alter-var-root x inc)
                                                (catch #?(:cljs :default
                                                          :clj clojure.lang.ExceptionInfo
-                                                         :cljr clojure.lang.ExceptionInfo) e
+                                                         :cljr clojure.lang.ExceptionInfo
+                                                         :lpy basilisp.lang.exception/ExceptionInfo) e
                                                  (let [{:keys [old] :as data} (ex-data e)]
                                                    (vswap! state conj data)))))]
                              (do-update #'testvar-a)
@@ -142,6 +144,7 @@
                               {:key :e :ref #'testvar-b :old 14 :new 15 :tester :err})))))])
 
     #?(:cljs nil
+       :lpy nil
        :default
        (testing "watch ref"
          (let [state (volatile! [])
@@ -213,6 +216,7 @@
                     (keyed :e @state)))))))
 
     #?@(:cljs []
+        :lpy []
         :default
         [(testing "watch agent"
            (let [state (volatile! [])

test/clojure/core_test/ancestors.cljc

@@ -5,8 +5,8 @@
 (when-var-exists ancestors
 
   ; Some classes for testing ancestors by type inheritance
-  (def AncestorT #?(:cljs js/Object :default Object))
-  (def ChildT #?(:cljs :default :default clojure.lang.PersistentHashSet))
+  (def AncestorT #?(:cljs js/Object :lpy python/object :default Object))
+  (def ChildT #?(:cljs :default :lpy basilisp.lang.set/PersistentSet :default clojure.lang.PersistentHashSet))
 
   ; Some custom types for testing ancestors by type inheritance
   (defprotocol TestAncestorsProtocol)
@@ -29,9 +29,11 @@
     (doseq [[tag parent] global-hierarchy]
       (underive tag parent)))
 
-  (defn with-global-hierarchy [tests]
+  ;; Basilisp does not support clojure.test style fixtures right now
+  ;; https://github.com/basilisp-lang/basilisp/issues/1306
+  (defn with-global-hierarchy [#?@(:lpy [] :default [tests])]
     (register-global-hierarchy)
-    (tests)
+    #?(:lpy (yield) :default (tests))
     (unregister-global-hierarchy))
 
   (use-fixtures :once with-global-hierarchy)
@@ -76,9 +78,9 @@
       #?(:bb      "bb doesn't report ancestors by type inheritance for custom types"
          :cljs    "cljs doesn't report ancestors by type inheritance yet (CLJS-3464)"
          :default (testing "returns ancestors by type inheritance when tag is a custom type"
-                    (is (contains? (ancestors TestAncestorsType) clojure.core_test.ancestors.TestAncestorsProtocol))
-                    (is (contains? (ancestors TestAncestorsRecord) clojure.core_test.ancestors.TestAncestorsProtocol))
-                    (is (contains? (ancestors TestAncestorsRecord) clojure.lang.Associative))
+                    (is (contains? (ancestors TestAncestorsType) #?(:lpy (:interface TestAncestorsProtocol) :default clojure.core_test.ancestors.TestAncestorsProtocol)))
+                    (is (contains? (ancestors TestAncestorsRecord) #?(:lpy (:interface TestAncestorsProtocol) :default clojure.core_test.ancestors.TestAncestorsProtocol)))
+                    (is (contains? (ancestors TestAncestorsRecord) #?(:lpy basilisp.lang.interfaces/IAssociative :default clojure.lang.Associative)))
                     (is (nil? (ancestors TestAncestorsProtocol)))))
 
       (testing "does not throw on invalid tag"
@@ -140,8 +142,8 @@
          :cljs    "cljs doesn't report ancestors by type inheritance yet (CLJS-3464)"
          :default (testing "returns ancestors by type inheritance when tag is a custom type, whether the tag is in h or not"
                     (are [h tag] (let [actual-ancestors (ancestors h tag)]
-                                   (and (contains? actual-ancestors clojure.core_test.ancestors.TestAncestorsProtocol)
-                                        (contains? actual-ancestors clojure.lang.Associative)))
+                                   (and (contains? actual-ancestors #?(:lpy (:interface TestAncestorsProtocol) :default clojure.core_test.ancestors.TestAncestorsProtocol))
+                                        (contains? actual-ancestors #?(:lpy basilisp.lang.interfaces/IAssociative :default clojure.lang.Associative))))
                                  ; tag in h
                                  datatypes TestAncestorsRecord
                                  ; tag not in h

test/clojure/core_test/assoc.cljc

@@ -19,9 +19,10 @@
                                 {:a 1 :b 2} {} [:a 1 :b 2]
                                 {:a 1 :b 3} {} [:a 1 :b 2 :b 3]
                                 {:a 1 :b 3 :c 5 :d 7} {:a 1 :b 2} [:b 3 :c 5 :d 7]))
-      (testing "maps - sorted type preservation"
-        (is (sorted? (assoc (sorted-map) :a 1 :b 2)))
-        (is (sorted? (assoc (sorted-map :a 1 :b 2) :b 3)))))
+      (when-var-exists sorted-map
+        (testing "maps - sorted type preservation"
+          (is (sorted? (assoc (sorted-map) :a 1 :b 2)))
+          (is (sorted? (assoc (sorted-map :a 1 :b 2) :b 3))))))
 
     (testing "vectors"
       (testing "vectors - single value"
@@ -37,14 +38,24 @@
                                 [1 2] [] [0 1 1 2]
                                 [1 3 5 7] [1 2] [1 3 2 5 3 7]))
       (testing "vectors - out-of-bounds indices"
+        ;; Basilisp vectors support indices 1 greater than the current max index
+        ;; and negative indices. Negative indices count backwards from the final
+        ;; element: -1 is the last element, -2 is the second-to-last, etc.
+        #?(:lpy
+           (are [expected vec ivs] (= expected (apply assoc vec ivs))
+             [0 1 -1] [0 1 2] [-1 -1]
+             [1 3 5]  [1 2]   [-1 3 2 5]))
+
         (are [vec ivs] (thrown? #?(:cljs js/Error :default Exception) (apply assoc vec ivs))
                        [] [-1 0]
                        [] [1 0]
-                       [0 1 2] [-1 -1]
                        [0 1 2] [4 4]
                        [1 2] [1 3 3 5]
-                       [1 2] [-1 3 2 5]
-                       [1 2] [-1 3 3 5])))
+                       [1 2] [-1 3 3 5]
+                       #?@(:lpy []
+                           :default
+                           [[0 1 2] [-1 -1]
+                            [1 2]   [-1 3 2 5]]))))
 
     (testing "meta preservation"
       (let [test-meta {:me "ta"}

test/clojure/core_test/assoc_bang.cljc

@@ -30,16 +30,21 @@
         (are [expected vec ivs] (= expected (persistent! (apply assoc! (transient vec) ivs)))
                                 [1 nil] [] [0 1 1]
                                 [1 2] [] [0 1 1 2]
-                                [1 3 5 7] [1 2] [1 3 2 5 3 7]))
+                                [1 3 5 7] [1 2] [1 3 2 5 3 7]
+                                #?@(:lpy
+                                    [[0 1 -1] [0 1 2] [-1 -1]
+                                     [1 3 5]  [1 2]   [-1 3 2 5]])))
       (testing "vectors - out-of-bounds indices"
         (are [vec ivs] (thrown? #?(:cljs js/Error :default Exception) (apply assoc! (transient vec) ivs))
                        [] [-1 0]
                        [] [1 0]
-                       [0 1 2] [-1 -1]
                        [0 1 2] [4 4]
                        [1 2] [1 3 3 5]
-                       [1 2] [-1 3 2 5]
-                       [1 2] [-1 3 3 5])))
+                       [1 2] [-1 3 3 5]
+                       #?@(:lpy []
+                           :default
+                           [[0 1 2] [-1 -1]
+                            [1 2]   [-1 3 2 5]]))))
 
     (testing "odd number of args"
       ; on the contrary to assoc, assoc! accepts an odd number (> 1) of args and assumes missing value is nil
@@ -49,11 +54,13 @@
                       [1] [0 1 1]
                       [1] [0 1 1 2 2]))
 
-    (testing "cannot assoc! transient after persistent! call"
-      (let [t (transient {:a 1}), _ (persistent! t)]
-        (is (thrown? #?(:cljs js/Error :cljr Exception :default Error) (assoc! t :b 2))))
-      (let [t (transient [1]), _ (persistent! t)]
-        (is (thrown? #?(:cljs js/Error :cljr Exception :default Error) (assoc! t 0 2)))))
+    #?@(:lpy []
+        :default
+        [(testing "cannot assoc! transient after persistent! call"
+           (let [t (transient {:a 1}), _ (persistent! t)]
+             (is (thrown? #?(:cljs js/Error :cljr Exception :lpy Exception :default Error) (assoc! t :b 2))))
+           (let [t (transient [1]), _ (persistent! t)]
+             (is (thrown? #?(:cljs js/Error :cljr Exception :lpy Exception :default Error) (assoc! t 0 2)))))])
 
     (testing "bad shape"
       (are [coll] (thrown? #?(:cljs js/Error :default Exception) (assoc! coll 1 3))