Move TH1IntegrateWithPartialBins from C++ to Python#52
Conversation
ROOT.HDTV.TH1IntegrateWithPartialBins() is only used in histogram.py. Since it is a small and easy function, it can be implemented directly in PyROOT and does not need to be compiled.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 63.07% 62.80% -0.28%
==========================================
Files 70 69 -1
Lines 10066 9880 -186
==========================================
- Hits 6349 6205 -144
+ Misses 3717 3675 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've found the trace from the shell to the modified function I've done the following A/B test to see if the modification produces a different result. hdtv> spectrum get o.mtx
hdtv> spectrum get o.tmtx
hdtv> spectrum add 0 1
hdtv> spectrum write o_add_test.mtx lcnow adding this patch and redoing the steps 1 .. 3. The 4th step is hdtv> spectrum write p_add_test.mtx lcSo we have Both have the same |
ROOT.HDTV.TH1IntegrateWithPartialBins() is only used in histogram.py.
Since it is a small and easy function, it can be implemented directly in PyROOT and does not need to be compiled.
This patch isn't covered by the test suite.
I'm also unsure how to trigger the function manually.Manual tested (#52 (comment))