Skip to content

Commit 3818e18

Browse files
committed
phy: apple: dptx: Add debug prints for unexpected values
Signed-off-by: Janne Grunau <[email protected]>
1 parent 5f9da41 commit 3818e18

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

drivers/phy/apple/dptx.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -364,15 +364,17 @@ static int dptx_phy_set_link_rate(struct apple_dptx_phy *phy, u32 link_rate)
364364

365365
// MMIO: R.4 0x23c541014 (dptx-phy[0], offset 0x1014) = 0x1
366366
sts_1014 = readl(phy->regs.dptx + 0x1014);
367-
/* TODO: assert(sts_1014 == 0x1); */
367+
if (sts_1014 != 0x1)
368+
dev_dbg(phy->dev, "unexpected?: dptx[0x1014]: %02x\n", sts_1014);
368369

369370
// MMIO: R.4 0x23c54100c (dptx-phy[0], offset 0x100c) = 0xf008
370371
// MMIO: W.4 0x23c54100c (dptx-phy[0], offset 0x100c) = 0xf000
371372
clear32(phy->regs.dptx + 0x100c, 0x0008);
372373

373374
// MMIO: R.4 0x23c541008 (dptx-phy[0], offset 0x1008) = 0x1
374375
sts_1008 = readl(phy->regs.dptx + 0x1008);
375-
/* TODO: assert(sts_1008 == 0x1); */
376+
if (sts_1008 != 0x1)
377+
dev_dbg(phy->dev, "unexpected?: dptx[0x1008]: %02x\n", sts_1008);
376378

377379
// MMIO: R.4 0x23c542220 (dptx-phy[0], offset 0x2220) = 0x11090a0
378380
// MMIO: W.4 0x23c542220 (dptx-phy[0], offset 0x2220) = 0x1109020
@@ -469,15 +471,17 @@ static int dptx_phy_set_link_rate(struct apple_dptx_phy *phy, u32 link_rate)
469471

470472
// MMIO: R.4 0x23c541014 (dptx-phy[0], offset 0x1014) = 0x38f
471473
sts_1014 = readl(phy->regs.dptx + 0x1014);
472-
/* TODO: assert(sts_1014 == 0x38f); */
474+
if (sts_1014 != 0x38f)
475+
dev_dbg(phy->dev, "unexpected?: dptx[0x1014]: %02x\n", sts_1014);
473476

474477
// MMIO: R.4 0x23c54100c (dptx-phy[0], offset 0x100c) = 0xf00f
475478
// MMIO: W.4 0x23c54100c (dptx-phy[0], offset 0x100c) = 0xf007
476479
clear32(phy->regs.dptx + 0x100c, 0x0008);
477480

478481
// MMIO: R.4 0x23c541008 (dptx-phy[0], offset 0x1008) = 0x9
479482
sts_1008 = readl(phy->regs.dptx + 0x1008);
480-
/* TODO: assert(sts_1008 == 0x9); */
483+
if (sts_1008 != 0x9)
484+
dev_dbg(phy->dev, "unexpected?: dptx[0x1008]: %02x\n", sts_1008);
481485

482486
// MMIO: R.4 0x23c542200 (dptx-phy[0], offset 0x2200) = 0x2000
483487
// MMIO: W.4 0x23c542200 (dptx-phy[0], offset 0x2200) = 0x2002

0 commit comments

Comments
 (0)