Skip to content

Commit b3e365e

Browse files
authored
Merge pull request #180 from janpfeifer/v0.11.2
V0.11.2 Fixed logging and gopls timeouts
2 parents f4bd8ad + 5ccdf8e commit b3e365e

25 files changed

+198
-154
lines changed

docs/CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,18 @@
22

33
## Next
44

5+
* Support Jupyter for more OSSes (thanks @yuce!)
6+
* Updated dependencies
7+
* Increased `gopls` timeout.
58
* Package `plotly`:
69
* Added `DisplayFigAsJSON` and `AppendFigAsJSON` to display Plotly figures directly from their
710
JSON rendering. This allows one to do arbitrary editions.
11+
* Installation:
12+
* Fixed the handling of the installation flags forwarded to the kernel execution.
13+
* Make a copy of the binary if the gonb binary is under a .cache directory. Same as is already done if
14+
the binary is in a temporary directory.
15+
* Fixed duplicate error logging issues.
16+
* Added internal `util` package. Improved error logging.
817

918
## v0.11.1, 2025/06/01
1019

docs/coverage.txt

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
github.com/janpfeifer/gonb/main.go init 100.0%
2-
github.com/janpfeifer/gonb/main.go main 63.2%
3-
github.com/janpfeifer/gonb/main.go install 66.7%
2+
github.com/janpfeifer/gonb/main.go main 55.0%
3+
github.com/janpfeifer/gonb/main.go install 80.0%
44
github.com/janpfeifer/gonb/main.go printVersion 42.9%
5-
github.com/janpfeifer/gonb/main.go setUpExtraLog 15.4%
6-
github.com/janpfeifer/gonb/main.go setUpLogging 66.7%
5+
github.com/janpfeifer/gonb/main.go setUpExtraLog 28.6%
76
github.com/janpfeifer/gonb/main.go prepend 100.0%
87
github.com/janpfeifer/gonb/main.go UniqueIDFilter.Filter 100.0%
98
github.com/janpfeifer/gonb/main.go UniqueIDFilter.FilterF 100.0%
109
github.com/janpfeifer/gonb/main.go UniqueIDFilter.FilterS 0.0%
11-
github.com/janpfeifer/gonb/main.go setUpKlog 83.3%
12-
github.com/janpfeifer/gonb/main.go runKernel 78.3%
10+
github.com/janpfeifer/gonb/main.go setUpKlog 100.0%
11+
github.com/janpfeifer/gonb/main.go runKernel 76.7%
1312
github.com/janpfeifer/gonb/version.go must 50.0%
1413
github.com/janpfeifer/gonb/version.go init 100.0%
1514
github.com/janpfeifer/gonb/cache/cache.go New 75.0%
@@ -153,8 +152,8 @@ github.com/janpfeifer/gonb/internal/comms/comms.go New 100.0%
153152
github.com/janpfeifer/gonb/internal/comms/comms.go getFromJson 62.5%
154153
github.com/janpfeifer/gonb/internal/comms/comms.go *State.InstallWebSocket 100.0%
155154
github.com/janpfeifer/gonb/internal/comms/comms.go *State.installWebSocketLocked 79.5%
156-
github.com/janpfeifer/gonb/internal/comms/comms.go *State.HandleOpen 68.9%
157-
github.com/janpfeifer/gonb/internal/comms/comms.go *State.HandleMsg 69.7%
155+
github.com/janpfeifer/gonb/internal/comms/comms.go *State.HandleOpen 64.4%
156+
github.com/janpfeifer/gonb/internal/comms/comms.go *State.HandleMsg 63.6%
158157
github.com/janpfeifer/gonb/internal/comms/comms.go *State.Close 100.0%
159158
github.com/janpfeifer/gonb/internal/comms/comms.go *State.closeLocked 100.0%
160159
github.com/janpfeifer/gonb/internal/comms/comms.go *State.Send 100.0%
@@ -171,7 +170,7 @@ github.com/janpfeifer/gonb/internal/comms/namedpipes.go *State.ProgramReadValu
171170
github.com/janpfeifer/gonb/internal/comms/namedpipes.go *State.ProgramSubscribeRequest 54.5%
172171
github.com/janpfeifer/gonb/internal/comms/namedpipes.go *State.ProgramUnsubscribeRequest 57.1%
173172
github.com/janpfeifer/gonb/internal/comms/namedpipes.go *State.deliverProgramSubscriptionsLocked 62.5%
174-
github.com/janpfeifer/gonb/internal/dispatcher/comms.go handleComms 66.7%
173+
github.com/janpfeifer/gonb/internal/dispatcher/comms.go handleComms 55.6%
175174
github.com/janpfeifer/gonb/internal/dispatcher/dispatcher.go RunKernel 80.0%
176175
github.com/janpfeifer/gonb/internal/dispatcher/dispatcher.go handleShellMsg 78.4%
177176
github.com/janpfeifer/gonb/internal/dispatcher/dispatcher.go handleBusyMessage 47.8%
@@ -351,7 +350,7 @@ github.com/janpfeifer/gonb/internal/jpyexec/namedpipes.go *Executor.openPipeWr
351350
github.com/janpfeifer/gonb/internal/jpyexec/namedpipes.go *Executor.pollPipeWriterFifo 66.7%
352351
github.com/janpfeifer/gonb/internal/kernel/encoding.go JupyterCursorPosToBytePos 0.0%
353352
github.com/janpfeifer/gonb/internal/kernel/encoding.go JupyterToLinesAndCursor 0.0%
354-
github.com/janpfeifer/gonb/internal/kernel/install.go Install 59.6%
353+
github.com/janpfeifer/gonb/internal/kernel/install.go Install 62.7%
355354
github.com/janpfeifer/gonb/internal/kernel/install.go copyFile 80.0%
356355
github.com/janpfeifer/gonb/internal/kernel/kernel.go *SyncSocket.RunLocked 100.0%
357356
github.com/janpfeifer/gonb/internal/kernel/kernel.go *Kernel.IsStopped 66.7%
@@ -425,6 +424,8 @@ github.com/janpfeifer/gonb/internal/specialcmd/specialcmd.go splitCmd 97.0%
425424
github.com/janpfeifer/gonb/internal/specialcmd/track.go execTrack 27.3%
426425
github.com/janpfeifer/gonb/internal/specialcmd/track.go execUntrack 54.5%
427426
github.com/janpfeifer/gonb/internal/specialcmd/track.go showTrackedList 91.7%
427+
github.com/janpfeifer/gonb/internal/util/util.go GetStackTrace 100.0%
428+
github.com/janpfeifer/gonb/internal/util/util.go ReportError 50.0%
428429
github.com/janpfeifer/gonb/internal/version/version.go AppVersion 66.7%
429430
github.com/janpfeifer/gonb/internal/version/version.go *VersionInfo.GetInfo 100.0%
430431
github.com/janpfeifer/gonb/internal/version/version.go *VersionInfo.String 100.0%

examples/tests/bash_script.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"name": "stdout",
3535
"output_type": "stream",
3636
"text": [
37-
"/tmp/gonb_2a008d65\n"
37+
"/tmp/gonb_24e6b823\n"
3838
]
3939
}
4040
],
@@ -59,7 +59,7 @@
5959
"output_type": "stream",
6060
"text": [
6161
"/home/janpf/Projects/gonb/examples/tests\n",
62-
"/tmp/gonb_2a008d65\n",
62+
"/tmp/gonb_24e6b823\n",
6363
"/home/janpf/Projects/gonb\n",
6464
"/home/janpf/Projects/gonb\n"
6565
]
@@ -86,7 +86,7 @@
8686
"name": "go",
8787
"nbconvert_exporter": "",
8888
"pygments_lexer": "",
89-
"version": "go1.24.2"
89+
"version": "go1.25.3"
9090
}
9191
},
9292
"nbformat": 4,

examples/tests/capture.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@
177177
"name": "go",
178178
"nbconvert_exporter": "",
179179
"pygments_lexer": "",
180-
"version": "go1.24.2"
180+
"version": "go1.25.3"
181181
}
182182
},
183183
"nbformat": 4,

examples/tests/comms.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@
308308
"name": "go",
309309
"nbconvert_exporter": "",
310310
"pygments_lexer": "",
311-
"version": "go1.24.2"
311+
"version": "go1.25.3"
312312
}
313313
},
314314
"nbformat": 4,

examples/tests/dom.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
{
8989
"data": {
9090
"text/html": [
91-
"<div id=\"dom.transient_div_02423362\"></div>"
91+
"<div id=\"dom.transient_div_a759e689\"></div>"
9292
]
9393
},
9494
"metadata": {},
@@ -152,7 +152,7 @@
152152
{
153153
"data": {
154154
"text/html": [
155-
"<div id=\"dom.transient_div_21d0ea97\"></div>"
155+
"<div id=\"dom.transient_div_4117637f\"></div>"
156156
]
157157
},
158158
"metadata": {},
@@ -197,7 +197,7 @@
197197
"name": "go",
198198
"nbconvert_exporter": "",
199199
"pygments_lexer": "",
200-
"version": "go1.24.2"
200+
"version": "go1.25.3"
201201
}
202202
},
203203
"nbformat": 4,

examples/tests/functions.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"name": "go",
6666
"nbconvert_exporter": "",
6767
"pygments_lexer": "",
68-
"version": "go1.24.2"
68+
"version": "go1.25.3"
6969
}
7070
},
7171
"nbformat": 4,

examples/tests/goflags.ipynb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,9 @@
153153
"name": "stdout",
154154
"output_type": "stream",
155155
"text": [
156-
"gonb_336aef0b/main.go:8:\tA\t\t100.0%\n",
157-
"gonb_336aef0b/main.go:12:\tB\t\t0.0%\n",
158-
"gonb_336aef0b/main.go:17:\tmain\t\t100.0%\n",
156+
"gonb_49622dd8/main.go:8:\tA\t\t100.0%\n",
157+
"gonb_49622dd8/main.go:12:\tB\t\t0.0%\n",
158+
"gonb_49622dd8/main.go:17:\tmain\t\t100.0%\n",
159159
"total\t\t\t\t(statements)\t75.0%\n"
160160
]
161161
}
@@ -238,7 +238,7 @@
238238
"name": "stderr",
239239
"output_type": "stream",
240240
"text": [
241-
"# gonb_336aef0b\n",
241+
"# gonb_49622dd8\n",
242242
"./main.go:10:6: can inline (*Point).ManhattanLen\n",
243243
"./main.go:16:12: inlining call to flag.Parse\n",
244244
"./main.go:18:27: inlining call to (*Point).ManhattanLen\n",
@@ -267,7 +267,7 @@
267267
"name": "go",
268268
"nbconvert_exporter": "",
269269
"pygments_lexer": "",
270-
"version": "go1.24.2"
270+
"version": "go1.25.3"
271271
}
272272
},
273273
"nbformat": 4,

examples/tests/gonbui.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"output_type": "stream",
2323
"text": [
2424
"%goflags=[\"--cover\" \"--covermode=set\"]\n",
25-
"GOCOVERDIR=/tmp/gonb_nbtests_gocoverdir_3978219183\n"
25+
"GOCOVERDIR=/tmp/gonb_test_coverage.6X8w4Qlxik\n"
2626
]
2727
}
2828
],
@@ -133,7 +133,7 @@
133133
"name": "go",
134134
"nbconvert_exporter": "",
135135
"pygments_lexer": "",
136-
"version": "go1.24.2"
136+
"version": "go1.25.3"
137137
}
138138
},
139139
"nbformat": 4,

examples/tests/gotest.ipynb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -287,12 +287,12 @@
287287
"text": [
288288
"goos: linux\n",
289289
"goarch: amd64\n",
290-
"pkg: gonb_4befbefa\n",
290+
"pkg: gonb_0591052b\n",
291291
"cpu: AMD Ryzen 9 9950X3D 16-Core Processor \n",
292292
"BenchmarkFibonacciA32\n",
293-
"BenchmarkFibonacciA32-32 \t 193\t 6359542 ns/op\n",
293+
"BenchmarkFibonacciA32-32 \t 192\t 6233978 ns/op\n",
294294
"BenchmarkFibonacciB32\n",
295-
"BenchmarkFibonacciB32-32 \t272287435\t 4.634 ns/op\n",
295+
"BenchmarkFibonacciB32-32 \t207941161\t 5.898 ns/op\n",
296296
"PASS\n",
297297
"coverage: [no statements]\n"
298298
]
@@ -334,10 +334,10 @@
334334
"text": [
335335
"goos: linux\n",
336336
"goarch: amd64\n",
337-
"pkg: gonb_4befbefa\n",
337+
"pkg: gonb_0591052b\n",
338338
"cpu: AMD Ryzen 9 9950X3D 16-Core Processor \n",
339-
"BenchmarkFibonacciA32-32 \t 190\t 6286586 ns/op\n",
340-
"BenchmarkFibonacciB32-32 \t355522092\t 3.356 ns/op\n",
339+
"BenchmarkFibonacciA32-32 \t 192\t 6382527 ns/op\n",
340+
"BenchmarkFibonacciB32-32 \t207262278\t 5.794 ns/op\n",
341341
"PASS\n",
342342
"coverage: [no statements]\n"
343343
]
@@ -361,7 +361,7 @@
361361
"name": "go",
362362
"nbconvert_exporter": "",
363363
"pygments_lexer": "",
364-
"version": "go1.24.2"
364+
"version": "go1.25.3"
365365
}
366366
},
367367
"nbformat": 4,

0 commit comments

Comments
 (0)