chore: bump rollup to v4 (#2630)

* chore: bump rollup to v4

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* chore: fix ts errors

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* chore: remove patch changeset

Signed-off-by: Kim Tsao <ktsao@redhat.com>

---------

Signed-off-by: Kim Tsao <ktsao@redhat.com>

Author: kim-tsao

.changeset/happy-monkeys-cover.md

@@ -0,0 +1,5 @@
+---
+"@janus-idp/cli": minor
+---
+
+Bump rollup to v4

packages/cli/package.json

@@ -74,7 +74,7 @@
     "react-dev-utils": "^12.0.0-next.60",
     "react-refresh": "^0.14.0",
     "recursive-readdir": "^2.2.2",
-    "rollup": "^2.78.0",
+    "rollup": "^4.0.0",
     "rollup-plugin-dts": "^4.0.1",
     "rollup-plugin-esbuild": "^4.7.2",
     "rollup-plugin-postcss": "^4.0.0",

packages/cli/src/commands/export-dynamic-plugin/backend-embed-as-code.ts

@@ -164,20 +164,22 @@ export async function backend(
   } = {};
 
   const rollupConfig = rollupConfigs[0];
-  rollupConfig.plugins?.push(
-    embedModules({
-      filter: filter,
-      addDependency: (embeddedModule, dependencyName, newDependencyVersion) =>
-        addToDependenciesForModule({
-          dependency: {
-            name: dependencyName,
-            version: newDependencyVersion,
-          },
-          dependencies: dependenciesToAdd,
-          module: embeddedModule,
-        }),
-    }),
-  );
+  if (Array.isArray(rollupConfig.plugins)) {
+    rollupConfig.plugins?.push(
+      embedModules({
+        filter: filter,
+        addDependency: (embeddedModule, dependencyName, newDependencyVersion) =>
+          addToDependenciesForModule({
+            dependency: {
+              name: dependencyName,
+              version: newDependencyVersion,
+            },
+            dependencies: dependenciesToAdd,
+            module: embeddedModule,
+          }),
+      }),
+    );
+  }
 
   if (Array.isArray(rollupConfig.output)) {
     rollupConfig.output.forEach(output => {
@@ -194,7 +196,7 @@ export async function backend(
             );
             return interopForPackage[id];
           }
-          return interopForAll || true; // true is the default value in Rollup.
+          return interopForAll || 'compat'; // compat is the default value in Rollup.
         };
       }
     });

packages/cli/src/lib/builder/config.ts

@@ -23,7 +23,7 @@ import yaml from '@rollup/plugin-yaml';
 import svgr from '@svgr/rollup';
 import chalk from 'chalk';
 import fs from 'fs-extra';
-import { OutputOptions, RollupOptions, RollupWarning } from 'rollup';
+import { OutputOptions, RollupLog, RollupOptions } from 'rollup';
 import dts from 'rollup-plugin-dts';
 import esbuild from 'rollup-plugin-esbuild';
 import postcss from 'rollup-plugin-postcss';
@@ -68,7 +68,7 @@ export async function makeRollupConfigs(
     targetPkg = (await fs.readJson(packagePath)) as BackstagePackageJson;
   }
 
-  const onwarn = ({ code, message }: RollupWarning) => {
+  const onwarn = ({ code, message }: RollupLog) => {
     if (code === 'EMPTY_BUNDLE') {
       return; // We don't care about this one
     }