Skip to content

Commit 9c7959d

Browse files
committed
[Island Browser] - Fix Cannot execute ILM policy delete step (elastic#134636)
This PR focuses on the short term solution which add the logs-island_browser.user-* and logs-island_browser.device-* indices under the kibana_system role with deletion privileges to prevent a failed deletion error when the index enters the deletion phase for the ILM lifecycle, in upcoming PR. As it ships transform pipeline too hence read, write permissions are also required. (cherry picked from commit ae63901)
1 parent 32b90cf commit 9c7959d

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed

docs/changelog/134636.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
pr: 134636
2+
summary: "[Island Browser] Add `manage`, `create_index`, `read`, `index`, `write`, `delete`, permission for third party agent indices `kibana_system`"
3+
area: Authorization
4+
type: enhancement
5+
issues:
6+
- 134136

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/KibanaOwnedReservedRoleDescriptors.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -535,11 +535,17 @@ static RoleDescriptor kibanaSystem(String name) {
535535
TransportDeleteIndexAction.TYPE.name()
536536
)
537537
.build(),
538-
// For ExtraHop, QualysGAV, and SentinelOne Application Dataset specific actions. Kibana reads, writes and manages this
539-
// index
538+
// For ExtraHop, QualysGAV, SentinelOne Application Dataset and Island Browser specific actions.
539+
// Kibana reads, writes and manages this index
540540
// for configured ILM policies.
541541
RoleDescriptor.IndicesPrivileges.builder()
542-
.indices("logs-extrahop.investigation-*", "logs-qualys_gav.asset-*", "logs-sentinel_one.application-*")
542+
.indices(
543+
"logs-extrahop.investigation-*",
544+
"logs-qualys_gav.asset-*",
545+
"logs-sentinel_one.application-*",
546+
"logs-island_browser.user-*",
547+
"logs-island_browser.device-*"
548+
)
543549
.privileges(
544550
"manage",
545551
"create_index",

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1914,12 +1914,15 @@ public void testKibanaSystemRole() {
19141914
assertThat(kibanaRole.indices().allowedIndicesMatcher(RolloverAction.NAME).test(indexAbstraction), is(true));
19151915
});
19161916

1917-
// Tests for third-party agent indices (ExtraHop, QualysGAV, SentinelOne) that `kibana_system` has full management access to
1917+
// Tests for third-party agent indices (ExtraHop, QualysGAV, SentinelOne, Island Browser) that `kibana_system`
1918+
// has full management access to
19181919
// This includes read, write, create, delete, and all ILM-related management actions.
19191920
Arrays.asList(
19201921
"logs-extrahop.investigation-" + randomAlphaOfLength(randomIntBetween(1, 10)),
19211922
"logs-qualys_gav.asset-" + randomAlphaOfLength(randomIntBetween(1, 10)),
1922-
"logs-sentinel_one.application-" + randomAlphaOfLength(randomIntBetween(1, 10))
1923+
"logs-sentinel_one.application-" + randomAlphaOfLength(randomIntBetween(1, 10)),
1924+
"logs-island_browser.user-" + randomAlphaOfLength(randomIntBetween(1, 10)),
1925+
"logs-island_browser.device-" + randomAlphaOfLength(randomIntBetween(1, 10))
19231926
).forEach((index_qualys_extra_hop) -> {
19241927
final IndexAbstraction indexAbstraction = mockIndexAbstraction(index_qualys_extra_hop);
19251928

0 commit comments

Comments
 (0)