Added liftR to functions as a workaround for Scala's poor type inference

You are currently cherry-picking commit 088ffad.

Conflicts:
	HISTORY.md

Author: japgolly

HISTORY.md

@@ -3,6 +3,8 @@ History
 
 ### 0.5.3 (unreleased)
 
+* Workaround for Scala's type inference failing with `StateT.liftR` on functions.
+  Instead of `f(_).liftR`, `f.liftR` is now available and is confirmed to work in `_runState`.
 
 ### 0.5.2 ([commit log](https://github.com/japgolly/scalajs-react/compare/v0.5.1...v0.5.2))
 

project/Build.scala

@@ -105,8 +105,10 @@ object ScalajsReact extends Build {
 
   lazy val test = project
     .configure(commonSettings, publicationSettings, utestSettings)
-    .dependsOn(core)
-    .settings(name := "test")
+    .dependsOn(core, scalaz71)
+    .settings(
+      name := "test",
+      scalacOptions += "-language:reflectiveCalls")
 
   // ==============================================================================================
   def scalazModule(name: String, version: String) = {

scalaz-7.0/src/main/scala/japgolly/scalajs/react/ScalazReact.scala

@@ -179,6 +179,11 @@ object ScalazReact {
       ReactS lift s
   }
 
+  implicit final class SzRExt__StateTOps[I, M[+_], S, A](val f: I => StateT[M, S, A]) extends AnyVal {
+    @inline def liftR(implicit M: Functor[M]): I => ReactST[M, S, A] =
+      f(_).liftR
+  }
+
   implicit final class SzRExt_ReactSTOps[M[+_], S, A](val s: ReactST[M,S,A]) extends AnyVal {
     def addCallback(c: OpCallbackIO)(implicit M: Monad[M]): ReactST[M,S,A] =
       s.flatMap(ReactS.callbackT(c))
@@ -218,7 +223,7 @@ object ScalazReact {
     def runStateS[M[+_], A](st: => StateT[M, S, A])(implicit C: CC, M: M ~> IO, N: Functor[M]): IO[A] =
       runState(st.liftR)
 
-    @deprecated("Instead of _runStateS(i ⇒ s | f), use _runState(i ⇒ s.liftR | f(_).liftR). _runStateS will be removed in 0.7.0.", "0.5.2")
+    @deprecated("Instead of _runStateS(f), use _runState(f.liftR). _runStateS will be removed in 0.7.0.", "0.5.2")
     def _runStateS[I, M[+_], A](f: I => StateT[M, S, A])(implicit C: CC, M: M ~> IO, N: Functor[M]): I => IO[A] =
       _runState(f(_).liftR)
 
@@ -235,7 +240,7 @@ object ScalazReact {
     def runStateFS[M[+_], A](st: => StateT[M, S, A])(implicit C: CC, M: M ~> IO, N: Functor[M], F: ChangeFilter[S]): IO[A] =
       runStateF(st.liftR)
 
-    @deprecated("Instead of _runStateFS(i ⇒ s | f), use _runStateF(i ⇒ s.liftR | f(_).liftR). _runStateFS will be removed in 0.7.0.", "0.5.2")
+    @deprecated("Instead of _runStateFS(f), use _runStateF(f.liftR). _runStateFS will be removed in 0.7.0.", "0.5.2")
     def _runStateFS[I, M[+_], A](f: I => StateT[M, S, A])(implicit C: CC, M: M ~> IO, N: Functor[M], F: ChangeFilter[S]): I => IO[A] =
       _runStateF(f(_).liftR)
   }

scalaz-7.1/src/main/scala/japgolly/scalajs/react/ScalazReact.scala

@@ -178,6 +178,11 @@ object ScalazReact {
       ReactS lift s
   }
 
+  implicit final class SzRExt__StateTOps[I, M[_], S, A](val f: I => StateT[M, S, A]) extends AnyVal {
+    @inline def liftR(implicit M: Functor[M]): I => ReactST[M, S, A] =
+      f(_).liftR
+  }
+
   implicit final class SzRExt_ReactSTOps[M[_], S, A](val s: ReactST[M,S,A]) extends AnyVal {
     def addCallback(c: OpCallbackIO)(implicit M: Monad[M]): ReactST[M,S,A] =
       s.flatMap(ReactS.callbackT(c))
@@ -217,7 +222,7 @@ object ScalazReact {
     def runStateS[M[_], A](st: => StateT[M, S, A])(implicit C: CC, M: M ~> IO, N: Functor[M]): IO[A] =
       runState(st.liftR)
 
-    @deprecated("Instead of _runStateS(i ⇒ s | f), use _runState(i ⇒ s.liftR | f(_).liftR). _runStateS will be removed in 0.7.0.", "0.5.2")
+    @deprecated("Instead of _runStateS(f), use _runState(f.liftR). _runStateS will be removed in 0.7.0.", "0.5.2")
     def _runStateS[I, M[_], A](f: I => StateT[M, S, A])(implicit C: CC, M: M ~> IO, N: Functor[M]): I => IO[A] =
       _runState(f(_).liftR)
 
@@ -234,7 +239,7 @@ object ScalazReact {
     def runStateFS[M[_], A](st: => StateT[M, S, A])(implicit C: CC, M: M ~> IO, N: Functor[M], F: ChangeFilter[S]): IO[A] =
       runStateF(st.liftR)
 
-    @deprecated("Instead of _runStateFS(i ⇒ s | f), use _runStateF(i ⇒ s.liftR | f(_).liftR). _runStateFS will be removed in 0.7.0.", "0.5.2")
+    @deprecated("Instead of _runStateFS(f), use _runStateF(f.liftR). _runStateFS will be removed in 0.7.0.", "0.5.2")
     def _runStateFS[I, M[_], A](f: I => StateT[M, S, A])(implicit C: CC, M: M ~> IO, N: Functor[M], F: ChangeFilter[S]): I => IO[A] =
       _runStateF(f(_).liftR)
   }

test/src/test/scala/japgolly/scalajs/react/ScalazTest.scala

@@ -0,0 +1,31 @@
+package japgolly.scalajs.react
+
+import utest._
+import scalaz.{~>, StateT, Monad}
+import scalaz.effect.IO
+import ScalazReact._
+
+/**
+ * Scala's type inference can be pretty weak sometimes.
+ * Successful compilation will suffice as proof for most of these tests.
+ */
+object ScalazTest extends TestSuite {
+
+  def test[A] = new {
+    def apply[B](f: A => B) = new {
+      def expect[C](implicit ev: B =:= C): Unit = ()
+    }
+  }
+
+  trait M[A]
+  implicit val mMonad = null.asInstanceOf[Monad[M] with (M ~> IO)]
+  trait S
+  trait A
+  trait B
+  val c = null.asInstanceOf[ComponentScopeM[Unit, S, Unit]]
+
+  val tests = TestSuite {
+    "runState(StateT.liftR)"      - test[StateT[M,S,A]     ](s => c.runState(s.liftR) ).expect[IO[A]]
+    "_runState((I→StateT).liftR)" - test[B => StateT[M,S,A]](s => c._runState(s.liftR)).expect[B => IO[A]]
+  }
+}