Type {min,max}Length attributes to ints

Author: japgolly

core/src/main/scala/japgolly/scalajs/react/vdom/HtmlAttrs.scala

@@ -546,7 +546,7 @@ trait HtmlAttrs {
     */
   final def max = VdomAttr("max")
 
-  final def maxLength = VdomAttr("maxLength")
+  final def maxLength = VdomAttr[Int]("maxLength")
 
   /**
     * This attribute specifies the media which the linked resource applies to.
@@ -583,7 +583,7 @@ trait HtmlAttrs {
     */
   final def min = VdomAttr("min")
 
-  final def minLength = VdomAttr("minLength")
+  final def minLength = VdomAttr[Int]("minLength")
 
   final def multiple = VdomAttr[Boolean]("multiple")
 

doc/changelog/1.4.2.md

@@ -12,7 +12,9 @@
 * Add an immediately-deprecated `AsyncCallback.fromCallback[A](c: CallbackTo[A]): AsyncCallback[A]`
   which points users to use `c.asAsyncCallback`.
 
-* Add helper methods to the `autoComplete` attribute, eg. `^.autoComplete.currentPassword`
+* VDOM improvements
+  * Add helper methods to the `autoComplete` attribute, eg. `^.autoComplete.currentPassword`
+  * `minLength` and `maxLength` now only accept ints
 
 * Dependency upgrades
   * Cats 1.6.0