Remove japgolly.scalajs.react.test.warnings.react

Removing from documentation and downstream tests

Author: japgolly

doc/CONFIG.md

@@ -6,7 +6,6 @@
   * [`.component.names.all`](#componentnamesall)
   * [`.component.names.implicit`](#componentnamesimplicit)
   * [`.config.class` *(Scala 3 only)*](#configclass-scala-3-only)
-  * [`.test.warnings.react`](#testwarningsreact)
 * Runtime Settings *(development-mode only)*
   * [Usage](#runtime-settings-usage)
   * [`Reusability.disableGloballyInDev()`](#reusabilitydisablegloballyindev)
@@ -161,59 +160,6 @@ object CustomConfig extends ScalaJsReactConfig.Defaults {
 }
 ```
 
-
-# `.test.warnings.react`
-
-When using `ReactTestUtils` or `LegacyReactTestUtils`, this setting can be used to catch React warnings and turn them into exceptions.
-
-### Usage:
-
-```
-sbt -Djapgolly.scalajs.react.test.warnings.react=warn|fatal
-```
-
-| Setting | Outcome |
-| -- | -- |
-| `warn` (default) | Print warnings and move on |
-| `fatal`  | Throw warnings as exceptions |
-
-### Example:
-
-```
-sbt -Djapgolly.scalajs.react.test.warnings.react=fatal
-```
-
-```scala
-package com.example
-
-import japgolly.scalajs.react._
-import japgolly.scalajs.react.test._
-import japgolly.scalajs.react.vdom.html_<^._
-import utest._
-
-object ExampleTest extends TestSuite {
-
-  override def tests = Tests {
-    "example" - {
-      val comp = ScalaFnComponent[Int](i => <.p(<.td(s"i = $i")))
-      ReactTestUtils.withRenderedSync(comp(123)) { t =>
-        t.outerHTML.assert("<p><td>i = 123</td></p>")
-      }
-    }
-  }
-}
-```
-
-Running the above test will fail with this error message:
-
-```
-scala.scalajs.js.JavaScriptException: Warning: validateDOMNesting(...): <td> cannot appear as a child of <p>.
-  at td
-  at p
-  at $c_sjs_js_Any$.fromFunction1__F1__sjs_js_Function1
-```
-
-
 # Runtime Settings: Usage
 
 Runtime settings are designed for use in development-mode only (`fastOptJS`).

downstream-tests/js/src/test/scala/downstream/RuntimeTests.scala

@@ -7,7 +7,6 @@ import japgolly.scalajs.react._
 import japgolly.scalajs.react.vdom.html_<^._
 import japgolly.scalajs.react.test.ReactTestUtils
 import japgolly.scalajs.react.util.JsUtil
-import org.scalajs.dom.console
 import scala.scalajs.js
 import scala.scalajs.LinkingInfo.developmentMode
 import scala.util.Try
@@ -16,10 +15,9 @@ import japgolly.scalajs.react.AsyncTestSuite
 
 object RuntimeTests extends AsyncTestSuite {
 
-  val compNameAuto      = CompileTimeInfo.sysProp("japgolly.scalajs.react.component.names.implicit")
-  val compNameAll       = CompileTimeInfo.sysProp("japgolly.scalajs.react.component.names.all")
-  val configClass       = CompileTimeInfo.sysProp("japgolly.scalajs.react.config.class")
-  val testWarningsReact = CompileTimeInfo.sysProp("japgolly.scalajs.react.test.warnings.react")
+  val compNameAuto = CompileTimeInfo.sysProp("japgolly.scalajs.react.component.names.implicit")
+  val compNameAll  = CompileTimeInfo.sysProp("japgolly.scalajs.react.component.names.all")
+  val configClass  = CompileTimeInfo.sysProp("japgolly.scalajs.react.config.class")
 
   val dsCfg1 = configClass.contains("downstream.DownstreamConfig1")
   val dsCfg2 = configClass.contains("downstream.DownstreamConfig2")
@@ -91,28 +89,5 @@ object RuntimeTests extends AsyncTestSuite {
       } yield ()
     }
 
-    "testWarnings" - {
-
-      "react" - {
-        val c = ScalaFnComponent[Int](i => <.p(<.td(s"i = $i")))
-        ReactTestUtils.withRendered_(c(123))(_ => ()).attemptTry.map { t =>
-          println(testWarningsReact)
-          println(t.toEither)
-          assertEq(t.isFailure, testWarningsReact.contains("fatal"))
-        }
-      }
-
-      "unlreated" - {
-        val c = ScalaFnComponent[Int](i => <.p(s"i = $i"))
-        ReactTestUtils.withRendered_(c(123)) { _ =>
-          console.info(".")
-          console.log(".")
-          console.warn(".")
-          console.error(".")
-        }.attemptTry.map { t =>
-          assertEq(t.isFailure, false)
-        }
-      }
-    }
   }
 }

downstream-tests/run

@@ -6,7 +6,7 @@ skip2=skip2
 
 # Tests
 all_tests_values=(
-  "-Ddownstream_tests.enableJSCE -Djapgolly.scalajs.react.test.warnings.react=fatal"
+  "-Ddownstream_tests.enableJSCE"
   "-Djapgolly.scalajs.react.config.class=downstream.DownstreamConfig1 -Ddownstream_tests.reusability.dev=disable $skip2"
   "-Djapgolly.scalajs.react.component.names.implicit=blank -Djapgolly.scalajs.react.component.names.all=allow"
   "-Djapgolly.scalajs.react.component.names.implicit=short -Ddownstream_tests.reusability.dev=disable"