Skip to content

Commit aa688c7

Browse files
committed
@nowarns aren't needed in Reusability.derive any more
Cos I switched over to using the lazy vals instead of the vars in the sum type cases
1 parent 36580c5 commit aa688c7

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

core/src/main/scala/japgolly/scalajs/react/internal/ReusabilityMacros.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class ReusabilityMacros(val c: Context) extends MacroUtils {
9393
val typ = weakTypeOf[A]
9494
val ra = ReusabilityA(typ)
9595
val prep = init1.varDef(ra, q"new Reusability(null)")
96-
lazies += q"""@_root_.scala.annotation.nowarn("cat=unused") implicit lazy val ${TermName("_" + prep.decodedName)}: $ra = $Reusability.byName($prep)"""
96+
lazies += q"""implicit lazy val ${TermName("_" + prep.decodedName)}: $ra = $Reusability.byName($prep)"""
9797
lazy val completed: c.Expr[Reusability[A]] = {
9898
val inner = complete
9999
val impl = q"$prep = $inner"

doc/changelog/1.7.2.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# 1.7.2
2+
3+
* Fix: no longer generate warnings when `-Wunused:nowarn` is enabled

test/src/test/scala/japgolly/scalajs/react/core/ReusabilityTest.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,15 @@ object ReusabilityTest extends TestSuite {
8181
final case class Suite[+Z](bms: Vector[BM[Z]]) extends Item[Z]
8282
final case class Blah1[+B](blah: Option[Blah1[B]]) extends Item[B]
8383
final case class Blah2[+C](blah: Option[Blah2[C]], i: Int) extends Item[C]
84+
final case class Blah3(i: Int) extends Item[Nothing]
8485

8586
final case class BM[+W](value: W)
8687

8788
implicit def reusabilityBM[A: Reusability]: Reusability[BM[A]] =
8889
Reusability.derive
8990

90-
implicit def reusability[H: Reusability]: Reusability[Item[H]] = {
91+
implicit def reusability[H: Reusability]: Reusability[Item[H]] =
9192
Reusability.derive
92-
}
9393
}
9494
}
9595

0 commit comments

Comments
 (0)