Test scalafix downstream

Couldn't work out how to check inferred types.

Author: japgolly

downstream-tests/.scalafix.conf

@@ -0,0 +1,3 @@
+rules = [
+  ScalaJsReactEffectAgnosticism,
+]

downstream-tests/build.sbt

@@ -174,3 +174,17 @@ lazy val jsCE = project
     },
     jsDependencies += (ProvidedJS / "polyfill.js") % Test,
   )
+
+lazy val generic = project
+  .enablePlugins(ScalaJSPlugin)
+  .configure(commonSettings)
+  .settings(
+    scalaJSStage := jsStage,
+    libraryDependencies ++= {
+      val ver = version.value.stripSuffix("-SNAPSHOT") + "-SNAPSHOT"
+      Seq(
+        "com.github.japgolly.scalajs-react" %%% "core-generic" % ver,
+        "com.github.japgolly.scalajs-react" %%% "util-dummy-defaults" % ver % Provided,
+      )
+    },
+  )

downstream-tests/generic/src/main/scala/downstream/ScalafixTest.scala

@@ -0,0 +1,7 @@
+package downstream
+
+import japgolly.scalajs.react.util.DefaultEffects._
+
+object ScalafixTest {
+  def x: Sync[Int] = Sync.delay(1)
+}

downstream-tests/scalafix.sbt

@@ -0,0 +1,20 @@
+// This is here just to manually test using the ScalaJsReactEffectAgnosticism
+// scalafix rule downstream.
+
+ThisBuild / scalacOptions ++= {
+  if (scalaVersion.value startsWith "2")
+    "-Yrangepos" :: Nil
+  else
+    Nil
+}
+
+ThisBuild / semanticdbEnabled := true
+
+ThisBuild / semanticdbVersion := "4.4.23"
+
+ThisBuild / scalafixScalaBinaryVersion := "2.13"
+
+ThisBuild / scalafixDependencies += {
+  val ver = version.value.stripSuffix("-SNAPSHOT") + "-SNAPSHOT"
+  "com.github.japgolly.scalajs-react" %% "scalafix" % ver
+}

scalafixRules/src/main/scala/sjr/ProhibitDefaultEffects.scala

@@ -9,20 +9,28 @@ class ProhibitDefaultEffects extends SemanticRule("ProhibitDefaultEffects") {
 
   override def fix(implicit doc: SemanticDocument): Patch = {
     doc.tree.collect {
-      case a: Decl.Def   => check(a.decltpe)
-      case a: Decl.Val   => check(a.decltpe)
-      case a: Decl.Var   => check(a.decltpe)
-      case a: Defn.Def   => check(a.decltpe)
-      case a: Defn.Val   => check(a.decltpe)
-      case a: Defn.Var   => check(a.decltpe)
-      case a: Term.Param => check(a.decltpe)
+
+      // case Defn.Def(_, name, _, _, None, body)                 => checkImplicit(name, body)
+      // case Defn.Val(_, Pat.Var(name) :: Nil, None, body)       => checkImplicit(name, body)
+      // case Defn.Var(_, Pat.Var(name) :: Nil, None, Some(body)) => checkImplicit(name, body)
+
+      case a: Decl.Def   => checkExplicit(a.decltpe)
+      case a: Decl.Val   => checkExplicit(a.decltpe)
+      case a: Decl.Var   => checkExplicit(a.decltpe)
+      case a: Defn.Def   => checkExplicit(a.decltpe)
+      case a: Defn.Val   => checkExplicit(a.decltpe)
+      case a: Defn.Var   => checkExplicit(a.decltpe)
+      case a: Term.Param => checkExplicit(a.decltpe)
     }.asPatch
   }
 
-  private def check(o: Option[Type])(implicit doc: SemanticDocument): Patch =
-    o.fold(Patch.empty)(check(_))
+  // private def checkImplicit(name: Name, body: Term)(implicit doc: SemanticDocument): Patch = {
+  // }
+
+  private def checkExplicit(o: Option[Type])(implicit doc: SemanticDocument): Patch =
+    o.fold(Patch.empty)(checkExplicit(_))
 
-  private def check(t: Type)(implicit doc: SemanticDocument): Patch =
+  private def checkExplicit(t: Type)(implicit doc: SemanticDocument): Patch =
     if (isDefaultEffect(t.symbol))
       Patch.lint(DefaultEffectDetected(t.pos))
     else