Skip to content

Commit 49e9a18

Browse files
committed
Clarify error messages.
1 parent c15eba3 commit 49e9a18

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/state/session.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var uid = require('uid2');
2020
* @api public
2121
*/
2222
function SessionStore(options) {
23-
if (!options.key) { throw new TypeError('SessionStateStore requires a key'); }
23+
if (!options.key) { throw new TypeError('Session-based state store requires a session key'); }
2424
this._key = options.key;
2525
}
2626

@@ -36,7 +36,7 @@ function SessionStore(options) {
3636
* @api protected
3737
*/
3838
SessionStore.prototype.store = function(req, callback) {
39-
if (!req.session) { return callback(new Error('OAuth2Strategy requires session support when using state. Did you forget app.use(express.session(...))?')); }
39+
if (!req.session) { return callback(new Error('OAuth 2.0 authentication requires session support when using state. Did you forget to use express-session middleware?')); }
4040

4141
var key = this._key;
4242
var state = uid(24);
@@ -57,7 +57,7 @@ SessionStore.prototype.store = function(req, callback) {
5757
* @api protected
5858
*/
5959
SessionStore.prototype.verify = function(req, providedState, callback) {
60-
if (!req.session) { return callback(new Error('OAuth2Strategy requires session support when using state. Did you forget app.use(express.session(...))?')); }
60+
if (!req.session) { return callback(new Error('OAuth 2.0 authentication requires session support when using state. Did you forget to use express-session middleware?')); }
6161

6262
var key = this._key;
6363
if (!req.session[key]) {

test/oauth2.state.session.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ describe('OAuth2Strategy', function() {
103103

104104
it('should error', function() {
105105
expect(err).to.be.an.instanceof(Error)
106-
expect(err.message).to.equal('OAuth2Strategy requires session support when using state. Did you forget app.use(express.session(...))?');
106+
expect(err.message).to.equal('OAuth 2.0 authentication requires session support when using state. Did you forget to use express-session middleware?');
107107
});
108108
}); // that errors due to lack of session support in app
109109

@@ -343,7 +343,7 @@ describe('OAuth2Strategy', function() {
343343

344344
it('should error', function() {
345345
expect(err).to.be.an.instanceof(Error)
346-
expect(err.message).to.equal('OAuth2Strategy requires session support when using state. Did you forget app.use(express.session(...))?');
346+
expect(err.message).to.equal('OAuth 2.0 authentication requires session support when using state. Did you forget to use express-session middleware?');
347347
});
348348
}); // that errors due to lack of session support in app
349349

0 commit comments

Comments
 (0)