From c297c1bf76b24119ac631b73d9e3129a3660287b Mon Sep 17 00:00:00 2001 From: Harshit Gambhir <33486439+harshitgambhir@users.noreply.github.com> Date: Thu, 11 Jan 2018 22:13:00 +0530 Subject: [PATCH] check for empty success and failure redirect in authenticate.js check for empty success and failure redirect in authenticate.js so that passport.authenticate can call next() if we pass successRedirect or failureRedirect as an empty string. --- lib/middleware/authenticate.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/middleware/authenticate.js b/lib/middleware/authenticate.js index ccc9b2ac..4af4d8f0 100644 --- a/lib/middleware/authenticate.js +++ b/lib/middleware/authenticate.js @@ -141,7 +141,7 @@ module.exports = function authenticate(passport, name, options, callback) { req.session.messages.push(msg); } } - if (options.failureRedirect) { + if (options.failureRedirect !== '') { return res.redirect(options.failureRedirect); } @@ -257,7 +257,7 @@ module.exports = function authenticate(passport, name, options, callback) { } return res.redirect(url); } - if (options.successRedirect) { + if (options.successRedirect !== '') { return res.redirect(options.successRedirect); } next();