Second attempt to fix #417 (and fix #458 too) (#460)

* Revert "Hide lowercase modules. (#418)"

This reverts commit a8458b1.

* Omit lowercase modules in value completions.

Author: fhammerschmidt

src/analyze/NewCompletions.re

@@ -358,7 +358,11 @@ let valueCompletions = (~env: Query.queryEnv, suffix) => {
   Log.log(" - Completing in " ++ env.file.uri);
   let results = [];
   let results =
-    if (isCapitalized(suffix)) {
+    if (suffix == "" || isCapitalized(suffix)) {
+
+      // Get rid of lowercase modules (#417)
+      env.exported.modules |> Hashtbl.filter_map_inplace((name, key) => isCapitalized(name) ? Some(key) : None);
+
       let moduleCompletions = completionForExporteds(
           env.exported.modules, env.file.stamps.modules, suffix, m =>
           Module(m)