cacheable - feat: moving to native Keyv deleteMany (#1318)

Author: jaredwray

packages/cacheable/src/index.ts

@@ -770,15 +770,15 @@ export class Cacheable extends Hookified {
 			}
 		}
 
-		const result = await this.deleteManyKeyv(this._primary, keys);
+		const result = await this._primary.deleteMany(keys);
 		if (this._secondary) {
 			if (this._nonBlocking) {
 				// Catch any errors to avoid unhandled promise rejections
-				this.deleteManyKeyv(this._secondary, keys).catch((error) => {
+				this._secondary.deleteMany(keys).catch((error) => {
 					this.emit(CacheableEvents.ERROR, error);
 				});
 			} else {
-				await this.deleteManyKeyv(this._secondary, keys);
+				await this._secondary.deleteMany(keys);
 			}
 		}
 
@@ -935,17 +935,6 @@ export class Cacheable extends Hookified {
 		return result;
 	}
 
-	private async deleteManyKeyv(keyv: Keyv, keys: string[]): Promise<boolean> {
-		const promises = [];
-		for (const key of keys) {
-			promises.push(keyv.delete(key));
-		}
-
-		await Promise.all(promises);
-
-		return true;
-	}
-
 	private async setManyKeyv(
 		keyv: Keyv,
 		items: CacheableItem[],

packages/cacheable/test/index.test.ts

@@ -1271,8 +1271,8 @@ describe("Non-blocking error handling", () => {
 		await primary.set("key1", "value1");
 		await primary.set("key2", "value2");
 
-		// Make secondary.delete throw an error
-		vi.spyOn(secondary, "delete").mockRejectedValue(
+		// Make secondary.deleteMany throw an error
+		vi.spyOn(secondary, "deleteMany").mockRejectedValue(
 			new Error("Secondary deleteMany error"),
 		);