AST: add params to scope (#5252)

* astNode()

* no override ast()

* add suggested comments

* astInitialize()

* astAddReturns()

* separate step

* recognize quoted constructor

* add params to scope

Author: helixbass

lib/coffeescript/nodes.js

@@ -4059,8 +4059,14 @@ exports.Code = class Code extends Base
     for {name} in @params when name instanceof Arr or name instanceof Obj
       name.propagateLhs yes
 
+  astAddParamsToScope: (o) ->
+    for param in @params
+      param.eachName (name) ->
+        o.scope.add name, 'param'
+
   astNode: (o) ->
     @updateOptions o
+    @astAddParamsToScope o
     @body.makeReturn null, yes unless @body.isEmpty() or @noReturn
 
     super o

src/nodes.coffee

@@ -2565,6 +2565,84 @@ test "AST as expected for Code node", ->
     async: no
     id: null
 
+  testExpression '(a) -> a = 1',
+    type: 'FunctionExpression'
+    body:
+      type: 'BlockStatement'
+      body: [
+        type: 'ExpressionStatement'
+        expression:
+          type: 'AssignmentExpression'
+          left:
+            ID 'a', declaration: no
+      ]
+
+  testExpression '(...a) -> a = 1',
+    type: 'FunctionExpression'
+    body:
+      type: 'BlockStatement'
+      body: [
+        type: 'ExpressionStatement'
+        expression:
+          type: 'AssignmentExpression'
+          left:
+            ID 'a', declaration: no
+      ]
+
+  testExpression '({a}) -> a = 1',
+    type: 'FunctionExpression'
+    body:
+      type: 'BlockStatement'
+      body: [
+        type: 'ExpressionStatement'
+        expression:
+          type: 'AssignmentExpression'
+          left:
+            ID 'a', declaration: no
+      ]
+
+  testExpression '([a]) -> a = 1',
+    type: 'FunctionExpression'
+    body:
+      type: 'BlockStatement'
+      body: [
+        type: 'ExpressionStatement'
+        expression:
+          type: 'AssignmentExpression'
+          left:
+            ID 'a', declaration: no
+      ]
+
+  testExpression '(a = 1) -> a = 1',
+    type: 'FunctionExpression'
+    body:
+      type: 'BlockStatement'
+      body: [
+        type: 'ExpressionStatement'
+        expression:
+          type: 'AssignmentExpression'
+          left:
+            ID 'a', declaration: no
+      ]
+    generator: no
+    async: no
+    id: null
+
+  testExpression '({a} = 1) -> a = 1',
+    type: 'FunctionExpression'
+    body:
+      type: 'BlockStatement'
+      body: [
+        type: 'ExpressionStatement'
+        expression:
+          type: 'AssignmentExpression'
+          left:
+            ID 'a', declaration: no
+      ]
+    generator: no
+    async: no
+    id: null
+
 test "AST as expected for Splat node", ->
   testExpression '[a...]',
     type: 'ArrayExpression'