Skip to content

Commit ce66a49

Browse files
rdeforestGeoffreyBooth
authored andcommitted
Make node --harmony bin/cake test pass on Node 9 (#5012)
* Make `node --harmony bin/cake test` pass on Node 9 Make classMaker() explicitly return an object * Update Travis and AppVeyor to use --harmony and v9
1 parent 0268505 commit ce66a49

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

.travis.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ language: node_js
33
node_js:
44
- 6
55
- 8
6+
- 9
67

78
cache:
89
directories:
@@ -14,5 +15,6 @@ script:
1415
- node ./bin/cake build:full
1516
- node ./bin/cake build:browser
1617
- node ./bin/cake test
18+
- node --harmony ./bin/cake test
1719
- node ./bin/cake test:browser
1820
- node ./bin/cake test:integrations

appveyor.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ environment:
22
matrix:
33
- nodejs_version: '6'
44
- nodejs_version: '8'
5+
- nodejs_version: '9'
56
- nodejs_version: '' # Installs latest.
67

78
install:
@@ -19,6 +20,7 @@ test_script:
1920
- node ./bin/cake build:full
2021
- node ./bin/cake build:browser
2122
- node ./bin/cake test
23+
- node --harmony ./bin/cake test
2224
- node ./bin/cake test:browser
2325
- node ./bin/cake test:integrations
2426

test/classes.coffee

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,7 @@ test "classes with value'd constructors", ->
266266
inner = ++counter
267267
->
268268
@value = inner
269+
@
269270

270271
class One
271272
constructor: classMaker()

0 commit comments

Comments
 (0)