Merge pull request #2840 from jgonggrijp/empty-validation-warning

Author: jgonggrijp

index.html

@@ -1732,11 +1732,13 @@ <h2 id="objects">Object Functions</h2>
 </pre>
 
       <p id="isEmpty">
-        <b class="header">isEmpty</b><code>_.isEmpty(object)</code>
+        <b class="header">isEmpty</b><code>_.isEmpty(collection)</code>
         <br />
-        Returns <i>true</i> if an enumerable <b>object</b> contains no
-        values (no enumerable own-properties). For strings and array-like
-        objects <tt>_.isEmpty</tt> checks if the length property is 0.
+        Returns <i>true</i> if <b>collection</b> has no elements. For strings
+        and array-like objects <tt>_.isEmpty</tt> checks if the length property
+        is 0. For other objects, it returns <i>true</i> if the object has no
+        enumerable own-properties. Note that primitive numbers, booleans and
+        symbols are always empty by this definition.
       </p>
       <pre>
 _.isEmpty([1, 2, 3]);

modules/index.js

@@ -1296,6 +1296,8 @@ export function isEqual(a, b) {
 // An "empty" object has no enumerable own-properties.
 export function isEmpty(obj) {
   if (obj == null) return true;
+  // Skip the more expensive `toString`-based type checks if `obj` has no
+  // `.length`.
   if (isArrayLike(obj) && (isArray(obj) || isString(obj) || isArguments(obj))) return obj.length === 0;
   return keys(obj).length === 0;
 }