Don't report expected and actual properties of expectations results

These have never been reliable due to serializability issues, appear
to have never been used, and are deprecated in jasmine-core. Removing
them entirely fixes an un-catchable error when Selenium tries to
serialize detatched DOM nodes, and generally ends the game of
serialization error whack-a-mole.

Fixes #67.

Author: sgravrock

lib/runner.js

@@ -8,11 +8,6 @@ function getBatch(driver) {
       'if (results[i][1].passedExpectations) {\n' +
       'expectations = expectations.concat(results[i][1].passedExpectations);\n' +
       '}\n' +
-      'for (var j = 0; j < expectations.length; j++) {\n' +
-      'var expectation = expectations[j];\n' +
-      "try { JSON.stringify(expectation.expected); } catch (e) { expectation.expected = '<circular expected>'; }\n" +
-      "try { JSON.stringify(expectation.actual); } catch (e) { expectation.actual = '<circular actual>'; }\n" +
-      '}\n' +
       '}\n' +
       'return results;'
   );

lib/support/batchReporter.js

@@ -21,16 +21,31 @@ function BatchReporter() {
   };
 
   this.jasmineDone = function(info) {
+    deleteExpectedAndActual(info);
     events.push(['jasmineDone', info]);
   };
 
   this.suiteDone = function(info) {
+    deleteExpectedAndActual(info);
     events.push(['suiteDone', info]);
   };
 
   this.specDone = function(info) {
+    deleteExpectedAndActual(info);
     events.push(['specDone', info]);
   };
+
+  function deleteExpectedAndActual(info) {
+    for (const e of info.failedExpectations) {
+      // Delete expected and actual. Not all JS objects are serializable, we
+      // don't have a reliable way to determine what Selenium can and can't
+      // serialize, not everything that's serializable survives the process
+      // intact, and there are no known reporters that use the expected or
+      // actual properties of expectation results.
+      delete e.expected;
+      delete e.actual;
+    }
+  }
 }
 
 window.batchReporter = new BatchReporter();